From: Ivan Shmakov <ivan@siamics.net>
To: 16279-done@debbugs.gnu.org
Subject: bug#16279: 24.3.50; [PATCH] eww: eww-history-mode fixup.
Date: Thu, 17 Jul 2014 07:06:57 +0000 [thread overview]
Message-ID: <87mwc8319s.fsf@violet.siamics.net> (raw)
In-Reply-To: <87ha9tdnq3.fsf@dhcp-193-97.nrt.redhat.com> (Kenjiro NAKAYAMA's message of "Sun, 29 Dec 2013 00:00:52 +0900")
[-- Attachment #1: Type: text/plain, Size: 1176 bytes --]
>>>>> Kenjiro NAKAYAMA <nakayamakenjiro@gmail.com> writes:
> Date: Sun, 29 Dec 2013 00:00:52 +0900
> Since current eww-history does not work well, I fixed. Please review
> and install it to the official tree if appreciated.
> Signed-off-by: Kenjiro NAKAYAMA <nakayamakenjiro@gmail.com>
> * net/eww.el (eww-list-histories,eww-history-browse): Fixup.
> (eww-history-quit): Delete and use quit-window.
> (eww-history-kill): Delete, because it doesn't work well and
> not necessary.
> (eww-history-mode-map): Delete some keys and add easy-menu.
[…]
Except for the line numbers and such, this exact diff was
applied as e8fcf8ca81c8 back in January. Thus I guess this bug
report may safely be closed.
That being said, I’d disagree that eww-history-kill is not
necessary: the eww-history records contain pages’ DOMs, sources,
and rendered texts (as :dom, :source and :text properties,
respectively), and the only currently “supported” way to clear
that is to kill a specific EWW buffer and create one anew, which
isn’t all that fine-grained, as it seems.
--
FSF associate member #7257 http://boycottsystemd.org/
[-- Attachment #2: Type: application/octet-stream, Size: 559 bytes --]
commit e8fcf8ca81c802c30f2e2f7d10490ff9c950c12c
Author: Kenjiro NAKAYAMA <nakayamakenjiro@gmail.com>
AuthorDate: Sun Jan 5 10:27:26 2014 +0100
Commit: Lars Magne Ingebrigtsen <larsi@gnus.org>
CommitDate: Sun Jan 5 10:27:26 2014 +0100
Make the eww history browsing work again
* net/eww.el (eww-list-histories,eww-history-browse): Fixup.
(eww-history-quit): Delete and use quit-window.
(eww-history-kill): Delete, because it doesn't work well and
not necessary.
(eww-history-mode-map): Delete some keys and add easy-menu.
prev parent reply other threads:[~2014-07-17 7:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-24 7:37 bug#16236: 24.3.50; [PATCH] eww: Don't set local value Kenjiro NAKAYAMA
2013-12-24 7:54 ` Lars Ingebrigtsen
2013-12-28 15:00 ` bug#16236: 24.3.50; [PATCH] eww: eww-history-mode fixup Kenjiro NAKAYAMA
2014-01-05 9:27 ` Lars Magne Ingebrigtsen
2014-07-17 7:06 ` Ivan Shmakov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mwc8319s.fsf@violet.siamics.net \
--to=ivan@siamics.net \
--cc=16279-done@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).