From: Lars Ingebrigtsen <larsi@gnus.org>
To: Dima Kogan <dima@secretsauce.net>
Cc: 22591@debbugs.gnu.org
Subject: bug#22591: 25.0.50; [PATCH] imagemagick orientation EXIF tag is respected
Date: Wed, 10 Feb 2016 15:40:25 +1100 [thread overview]
Message-ID: <87mvr9i3eu.fsf@gnus.org> (raw)
In-Reply-To: <8737t2lh5y.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 09 Feb 2016 14:02:49 +1100")
Lars Ingebrigtsen <larsi@gnus.org> writes:
> Dima Kogan <dima@secretsauce.net> writes:
>
>> Hi. Here are two small patches to improve handling of images loaded with
>> the imagemagick backend. They are:
>>
>> 1. Accept integer :rotation parameters. Previously only floating-point
>> ones worked
>>
>> 2. If an EXIF orientation tag exists and no explicit :rotation exists,
>> use the orientation. This happens early in the processing, so all the
>> data (width, height, etc) that emacs sees applies to the rotated image.
>>
>> The motivation for this was that I was tired of seeing upside-down
>> photos in my mu4e mail.
>
> Looks good. I wonder whether this should go in the trunk, though? It's
> a new feature of sorts. But we could consider not showing images
> correctly rotated a bug...
I applied it to emacs-25. Not respecting EXIF rotations is kinda a bug.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2016-02-10 4:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-07 22:54 bug#22591: 25.0.50; [PATCH] imagemagick orientation EXIF tag is respected Dima Kogan
2016-02-09 3:02 ` Lars Ingebrigtsen
2016-02-10 4:40 ` Lars Ingebrigtsen [this message]
2016-02-10 16:35 ` Glenn Morris
2016-02-11 2:28 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mvr9i3eu.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=22591@debbugs.gnu.org \
--cc=dima@secretsauce.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).