From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Andreas Politz Newsgroups: gmane.emacs.bugs Subject: bug#24213: 25.1.50; Fishy use of delete-window in register.el Date: Thu, 01 Sep 2016 13:22:08 +0200 Message-ID: <87mvjreufz.fsf@hochschule-trier.de> References: <87mvkhivpu.fsf@hochschule-trier.de> <57AED93A.4090902@gmx.at> <878tw1kqby.fsf@hochschule-trier.de> <57AEF063.6070907@gmx.at> <8760qg69q3.fsf@hochschule-trier.de> <57C7DB54.6000605@gmx.at> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1472729013 26876 195.159.176.226 (1 Sep 2016 11:23:33 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 1 Sep 2016 11:23:33 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) Cc: 24213@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Sep 01 13:23:27 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bfQ5Z-0005gn-Nw for geb-bug-gnu-emacs@m.gmane.org; Thu, 01 Sep 2016 13:23:21 +0200 Original-Received: from localhost ([::1]:36343 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bfQ5X-00005m-NR for geb-bug-gnu-emacs@m.gmane.org; Thu, 01 Sep 2016 07:23:20 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58132) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bfQ5M-0008UU-Kv for bug-gnu-emacs@gnu.org; Thu, 01 Sep 2016 07:23:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bfQ5G-0001NE-JM for bug-gnu-emacs@gnu.org; Thu, 01 Sep 2016 07:23:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:48223) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bfQ5G-0001N8-8V for bug-gnu-emacs@gnu.org; Thu, 01 Sep 2016 07:23:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bfQ5F-0005ME-Vj for bug-gnu-emacs@gnu.org; Thu, 01 Sep 2016 07:23:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andreas Politz Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 01 Sep 2016 11:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24213 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24213-submit@debbugs.gnu.org id=B24213.147272895720551 (code B ref 24213); Thu, 01 Sep 2016 11:23:01 +0000 Original-Received: (at 24213) by debbugs.gnu.org; 1 Sep 2016 11:22:37 +0000 Original-Received: from localhost ([127.0.0.1]:45935 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bfQ4m-0005LL-Gy for submit@debbugs.gnu.org; Thu, 01 Sep 2016 07:22:36 -0400 Original-Received: from gateway-a.fh-trier.de ([143.93.54.181]:39638) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bfQ4f-0005L0-OK for 24213@debbugs.gnu.org; Thu, 01 Sep 2016 07:22:30 -0400 X-Virus-Scanned: by Amavisd-new + McAfee uvscan + ClamAV [Rechenzentrum Hochschule Trier (RZ/HT)] Original-Received: from localhost (ip5f5bdf67.dynamic.kabel-deutschland.de [95.91.223.103]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: politza) by gateway-a.fh-trier.de (Postfix) with ESMTPSA id 44F881798AB0; Thu, 1 Sep 2016 13:22:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha1; c=simple/simple; d=hochschule-trier.de; s=default; t=1472728929; bh=GQHdfcjFFA7JSSORvT8XYgb4U3c=; h=From:To:Cc:Subject:References:Date:In-Reply-To:Message-ID: MIME-Version:Content-Type; b=but0PimMANGtUHPpA2eRh/DDU5GN0hkx47tm5dtKfbM8fIMypCd5hyrhtWMCMACFk R8BahwSLf+dMmHPvlp92QLa/jOYTEF8BwGhsdNbsuSWK4jbP7ClmAK/fMubtVZ0K9K iwUcs/KDGzyMUdPZTTVVVGafdvSWBM1+qMt014fQ= In-Reply-To: <57C7DB54.6000605@gmx.at> (martin rudalics's message of "Thu, 01 Sep 2016 09:40:04 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:122822 Archived-At: martin rudalics writes: >> "Exit Finder mode. >> Delete the window and kill all Finder-related buffers." > > Maybe we should say that we "Quit" the window [...] Yes, I missed that. >> (interactive) >> - (ignore-errors (delete-window)) >> + (quit-window) >> (let ((buf "*Finder*")) >> (and (get-buffer buf) (kill-buffer buf)))) > > How about using (quit-window t) right away as in the next case? The resulting function would be quite murderous and try to kill any buffer regardless of Finder. I tried to modify the functions semantics as little as possible. Who knows in what way people are using them, right ? >> diff --git a/lisp/image-dired.el b/lisp/image-dired.el >> index 67b023d..36f148b 100644 >> --- a/lisp/image-dired.el >> +++ b/lisp/image-dired.el >> @@ -2445,13 +2445,9 @@ image-dired-gallery-generate >> (insert "")))) >> >> (defun image-dired-kill-buffer-and-window () >> - "Kill the current buffer and, if possible, also the window." >> + "Kill the current buffer and quit it's window." > > "its" not "it's". I think I'm using this false possessive apostrophe for years, without realizing its ambiguity. Thank you. More to come. -ap