From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.bugs Subject: bug#25391: 24.5; ffap-guesser "stack overflow in regexp matcher" error may crash emacs. Date: Tue, 10 Jan 2017 08:17:27 +0100 Message-ID: <87mveztmd4.fsf@gmail.com> References: <87vatqc8j1.fsf@gmail.com> <87y3yl1tdp.fsf@users.sourceforge.net> <8760lp8nqv.fsf@gmail.com> <87lgul167v.fsf@users.sourceforge.net> <87y3yk67l8.fsf@gmail.com> <87eg0b1qfj.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1484032702 24713 195.159.176.226 (10 Jan 2017 07:18:22 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 10 Jan 2017 07:18:22 +0000 (UTC) User-Agent: mu4e 0.9.19; emacs 24.5.1 Cc: 25391@debbugs.gnu.org To: npostavs@users.sourceforge.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jan 10 08:18:15 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cQqhA-0004rA-2v for geb-bug-gnu-emacs@m.gmane.org; Tue, 10 Jan 2017 08:18:12 +0100 Original-Received: from localhost ([::1]:45354 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cQqhC-0000eD-69 for geb-bug-gnu-emacs@m.gmane.org; Tue, 10 Jan 2017 02:18:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35001) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cQqh6-0000e5-CQ for bug-gnu-emacs@gnu.org; Tue, 10 Jan 2017 02:18:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cQqh1-0004WW-Cz for bug-gnu-emacs@gnu.org; Tue, 10 Jan 2017 02:18:08 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:32958) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cQqh1-0004WO-8z for bug-gnu-emacs@gnu.org; Tue, 10 Jan 2017 02:18:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cQqgz-0007DU-TH for bug-gnu-emacs@gnu.org; Tue, 10 Jan 2017 02:18:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Thierry Volpiatto Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 10 Jan 2017 07:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25391 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 25391-submit@debbugs.gnu.org id=B25391.148403265827709 (code B ref 25391); Tue, 10 Jan 2017 07:18:01 +0000 Original-Received: (at 25391) by debbugs.gnu.org; 10 Jan 2017 07:17:38 +0000 Original-Received: from localhost ([127.0.0.1]:48357 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cQqgc-0007Cr-7f for submit@debbugs.gnu.org; Tue, 10 Jan 2017 02:17:38 -0500 Original-Received: from mail-wj0-f178.google.com ([209.85.210.178]:33557) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cQqga-0007Ce-Or for 25391@debbugs.gnu.org; Tue, 10 Jan 2017 02:17:37 -0500 Original-Received: by mail-wj0-f178.google.com with SMTP id kq3so31756174wjc.0 for <25391@debbugs.gnu.org>; Mon, 09 Jan 2017 23:17:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=37fRGvMPDAjYG49al80kb2e6ZGjVYGC8QMeWqd8uSrA=; b=CWcYnqQm1ewTVlrdf07cOnGtt8FGY0Os0zPkM4Oep/7s+t05aIVJWLTNyY7qfPccCF siII6vgVFHdDePDxvAlN13U2+MAmtMsfIYhzxLbLdQHoa3hnLpkQTFUOiLbZPsJG8H+L Lb90PM9Alnf6jB+aFlh8RxnwrKUAPQWukS2KuTOEMqqLpvTQmeO/+z7IHgqv+vIfipwI hUzukuDNeiw+Am/BGktCcQaaJ5QNOQnzZ2PcEHcJ1gmzGh2oJLD0B3NMj5ByDNMqa/Q/ XV6ehGFVCrwIHQyPFY+8oYILlwjmWMybl41LsEq4FQlL17jJpzj4/yViTHikrQFU28dy X+5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=37fRGvMPDAjYG49al80kb2e6ZGjVYGC8QMeWqd8uSrA=; b=nlOLo29pn70z972GqHraCgGHdKXf6XITV6LXkKbe3BSzuMjemnVRN/QuswQBhPIxDq GBbjxqoBMSE4lj0meW8c4TtbZ1w47s3EMYG9zU3t5QFHmAKb+Guz/MkTg/pGj5Am3lvb 6l2Mb85+UTFonMsm2C/jEg7sSYZ/Zd2p4Sd7PnOoIerKFslbvn2EmiovalgATrcGxt9v GF1aZFTsyt0iRDBg9gTDw5tGuJR0Z2qvrB6nHh2yUqtK7ZoymnfiWTXExI4P35kjoIOk KXuSJuThqrXAW7auCdx6I7slUbg97lKTGZ0gDMCXyd+WUeeXl9hDq1U5HO+XxPQLrcny ioig== X-Gm-Message-State: AIkVDXLu7v77udM9MDLU5F/qyZSYAJs1onPDFHc8OvNC625m7tuaQAt5wLh/Yy4xLsg8Bg== X-Received: by 10.194.94.132 with SMTP id dc4mr797060wjb.231.1484032651151; Mon, 09 Jan 2017 23:17:31 -0800 (PST) Original-Received: from dell-14z ([37.167.8.80]) by smtp.gmail.com with ESMTPSA id 204sm22878855wmj.7.2017.01.09.23.17.29 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Mon, 09 Jan 2017 23:17:30 -0800 (PST) In-reply-to: <87eg0b1qfj.fsf@users.sourceforge.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:127951 Archived-At: npostavs@users.sourceforge.net writes: > Hmm, well I've meanwhile merged the fix for the regex stack limit, if > you can still crash emacs this way, open a new bug. Ok. >> I don't know `let-alist`, but looks good, however keeping >> `ffap-gopher-regexp` instead of hardcoding it and returning nil when the >> regexp is nil would allow users to disable the feature. > > Makes sense, here's an update: Thanks, however AFAIU your patch, when `ffap-gopher-regexp` is nil, `ffap-gopher-at-point` will return with an error but not nil isn't it ? -- Thierry