unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Thierry Volpiatto <thierry.volpiatto@gmail.com>
To: npostavs@users.sourceforge.net
Cc: 25391@debbugs.gnu.org
Subject: bug#25391: 24.5; ffap-guesser "stack overflow in regexp matcher" error may crash emacs.
Date: Tue, 10 Jan 2017 08:17:27 +0100	[thread overview]
Message-ID: <87mveztmd4.fsf@gmail.com> (raw)
In-Reply-To: <87eg0b1qfj.fsf@users.sourceforge.net>


npostavs@users.sourceforge.net writes:

> Hmm, well I've meanwhile merged the fix for the regex stack limit, if
> you can still crash emacs this way, open a new bug.

Ok.

>> I don't know `let-alist`, but looks good, however keeping
>> `ffap-gopher-regexp` instead of hardcoding it and returning nil when the
>> regexp is nil would allow users to disable the feature.
>
> Makes sense, here's an update:

Thanks, however AFAIU your patch, when `ffap-gopher-regexp` is nil,
`ffap-gopher-at-point` will return with an error but not nil isn't it ?


-- 
Thierry





  reply	other threads:[~2017-01-10  7:17 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-08  7:31 bug#25391: 24.5; ffap-guesser "stack overflow in regexp matcher" error may crash emacs Thierry Volpiatto
2017-01-08 15:08 ` npostavs
2017-01-08 17:28   ` Thierry Volpiatto
2017-01-08 23:29     ` npostavs
2017-01-09  7:00       ` Thierry Volpiatto
2017-01-10  4:37         ` npostavs
2017-01-10  7:17           ` Thierry Volpiatto [this message]
2017-01-10 13:37             ` npostavs
2017-01-10 14:42               ` Thierry Volpiatto
2017-01-14  2:25                 ` npostavs
2017-01-14  6:57                   ` npostavs
     [not found]                   ` <874m12t57f.fsf@gmail.com>
2017-01-14 14:43                     ` Noam Postavsky
     [not found]                       ` <8737gltvw8.fsf@gmail.com>
2017-01-15 19:08                         ` Noam Postavsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mveztmd4.fsf@gmail.com \
    --to=thierry.volpiatto@gmail.com \
    --cc=25391@debbugs.gnu.org \
    --cc=npostavs@users.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).