* bug#18257: C-h b mentions "C-c C-f" as a valid binding in gnus-article-mode. [not found] ` <87fuk7lygr.fsf@gnus.org> @ 2017-01-25 21:55 ` Lars Ingebrigtsen 2017-01-26 8:10 ` Katsumi Yamaoka 0 siblings, 1 reply; 5+ messages in thread From: Lars Ingebrigtsen @ 2017-01-25 21:55 UTC (permalink / raw To: Nicolas Richard; +Cc: 18257 Lars Ingebrigtsen <larsi@gnus.org> writes: > Nicolas Richard <theonewiththeevillook@yahoo.fr> writes: > >> 1. open gnus (e.g. "emacs -Q -f gnus-no-server") >> 2. open a group and an article in it >> 3. hit C-x o to select the article window. >> 4. hit C-h b to show the available bindings >> 4bis. in the list, "C-c C-f" is mentionned (at line 201 here) >> 5. hit C-c C-f >> >> Result: "C-c C-f is undefined" >> Expected result: prepare a buffer for forwarding the selected message. > > Fixed on the Emacs trunk now. Just binding "C-c" in the article buffer (like other prefixed) led to problems in other parts of Emacs somehow, so I've reverted that patch and will have to implement it a different way. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no ^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#18257: C-h b mentions "C-c C-f" as a valid binding in gnus-article-mode. 2017-01-25 21:55 ` bug#18257: C-h b mentions "C-c C-f" as a valid binding in gnus-article-mode Lars Ingebrigtsen @ 2017-01-26 8:10 ` Katsumi Yamaoka 2017-01-26 8:55 ` Katsumi Yamaoka 0 siblings, 1 reply; 5+ messages in thread From: Katsumi Yamaoka @ 2017-01-26 8:10 UTC (permalink / raw To: Lars Ingebrigtsen; +Cc: Nicolas Richard, 18257 [-- Attachment #1: Type: text/plain, Size: 440 bytes --] On Wed, 25 Jan 2017 22:55:15 +0100, Lars Ingebrigtsen wrote: > Just binding "C-c" in the article buffer (like other prefixed) led to > problems in other parts of Emacs somehow, so I've reverted that patch > and will have to implement it a different way. Sorry, that is my fault. How about this patch? * lisp/gnus/gnus-art.el (gnus-article-describe-bindings): Ignore summary commands that aren't bound to gnus-article-read-summary-keys. [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #2: Type: text/x-patch, Size: 966 bytes --] --- gnus-art.el~ 2017-01-25 22:07:29.825734200 +0000 +++ gnus-art.el 2017-01-26 08:10:00.743177500 +0000 @@ -6846,16 +6846,20 @@ (let ((keymap (copy-keymap gnus-article-mode-map)) (map (copy-keymap gnus-article-send-map)) (sumkeys (where-is-internal 'gnus-article-read-summary-keys)) + (summap (make-sparse-keymap)) parent agent draft) (define-key keymap "S" map) (define-key map [t] nil) + (define-key summap [t] 'undefined) (with-current-buffer gnus-article-current-summary + (dolist (key sumkeys) + (define-key summap key (key-binding key (current-local-map)))) (set-keymap-parent keymap (if (setq parent (keymap-parent gnus-article-mode-map)) (prog1 (setq parent (copy-keymap parent)) - (set-keymap-parent parent (current-local-map))) + (set-keymap-parent parent summap)) (current-local-map))) (set-keymap-parent map (key-binding "S")) (let (key def gnus-pick-mode) ^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#18257: C-h b mentions "C-c C-f" as a valid binding in gnus-article-mode. 2017-01-26 8:10 ` Katsumi Yamaoka @ 2017-01-26 8:55 ` Katsumi Yamaoka 2017-01-26 17:12 ` Lars Ingebrigtsen 0 siblings, 1 reply; 5+ messages in thread From: Katsumi Yamaoka @ 2017-01-26 8:55 UTC (permalink / raw To: Lars Ingebrigtsen; +Cc: Nicolas Richard, 18257 [-- Attachment #1: Type: text/plain, Size: 305 bytes --] On Thu, 26 Jan 2017 17:10:51 +0900, Katsumi Yamaoka wrote: > Sorry, that is my fault. How about this patch? I'm sorry again. This is the right one: * lisp/gnus/gnus-art.el (gnus-article-describe-bindings): Ignore summary commands that aren't bound to gnus-article-read-summary-keys keys (bug#18257). [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #2: Type: text/x-patch, Size: 995 bytes --] --- gnus-art.el~ 2017-01-25 22:07:29.825734200 +0000 +++ gnus-art.el 2017-01-26 08:54:39.004906700 +0000 @@ -6846,17 +6846,21 @@ (let ((keymap (copy-keymap gnus-article-mode-map)) (map (copy-keymap gnus-article-send-map)) (sumkeys (where-is-internal 'gnus-article-read-summary-keys)) + (summap (make-sparse-keymap)) parent agent draft) (define-key keymap "S" map) (define-key map [t] nil) + (define-key summap [t] 'undefined) (with-current-buffer gnus-article-current-summary + (dolist (key sumkeys) + (define-key summap key (key-binding key (current-local-map)))) (set-keymap-parent keymap (if (setq parent (keymap-parent gnus-article-mode-map)) (prog1 (setq parent (copy-keymap parent)) - (set-keymap-parent parent (current-local-map))) - (current-local-map))) + (set-keymap-parent parent summap)) + summap)) (set-keymap-parent map (key-binding "S")) (let (key def gnus-pick-mode) (while sumkeys ^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#18257: C-h b mentions "C-c C-f" as a valid binding in gnus-article-mode. 2017-01-26 8:55 ` Katsumi Yamaoka @ 2017-01-26 17:12 ` Lars Ingebrigtsen 2017-01-26 22:44 ` Katsumi Yamaoka 0 siblings, 1 reply; 5+ messages in thread From: Lars Ingebrigtsen @ 2017-01-26 17:12 UTC (permalink / raw To: Katsumi Yamaoka; +Cc: Nicolas Richard, 18257 Katsumi Yamaoka <yamaoka@jpl.org> writes: > On Thu, 26 Jan 2017 17:10:51 +0900, Katsumi Yamaoka wrote: >> Sorry, that is my fault. How about this patch? > > I'm sorry again. This is the right one: > > * lisp/gnus/gnus-art.el (gnus-article-describe-bindings): > Ignore summary commands that aren't bound to > gnus-article-read-summary-keys keys (bug#18257). Great; can you apply it to the Emacs trunk? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no ^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#18257: C-h b mentions "C-c C-f" as a valid binding in gnus-article-mode. 2017-01-26 17:12 ` Lars Ingebrigtsen @ 2017-01-26 22:44 ` Katsumi Yamaoka 0 siblings, 0 replies; 5+ messages in thread From: Katsumi Yamaoka @ 2017-01-26 22:44 UTC (permalink / raw To: Lars Ingebrigtsen; +Cc: Nicolas Richard, 18257 On Thu, 26 Jan 2017 18:12:43 +0100, Lars Ingebrigtsen wrote: > Great; can you apply it to the Emacs trunk? Done. Thanks. ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-01-26 22:44 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <87tx5gfyx5.fsf@yahoo.fr>
[not found] ` <87fuk7lygr.fsf@gnus.org>
2017-01-25 21:55 ` bug#18257: C-h b mentions "C-c C-f" as a valid binding in gnus-article-mode Lars Ingebrigtsen
2017-01-26 8:10 ` Katsumi Yamaoka
2017-01-26 8:55 ` Katsumi Yamaoka
2017-01-26 17:12 ` Lars Ingebrigtsen
2017-01-26 22:44 ` Katsumi Yamaoka
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).