From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tom Tromey Newsgroups: gmane.emacs.bugs Subject: bug#25525: 25.1.90; add color highlighting to css mode Date: Fri, 10 Feb 2017 21:11:48 -0700 Message-ID: <87mvdt5ptn.fsf@tromey.com> References: <87mvefh8br.fsf@tromey.com> <83inp32l50.fsf@gnu.org> <87inp3gigu.fsf@tromey.com> <8737g6hfyv.fsf@tromey.com> <83d1f93iyz.fsf@gnu.org> <874m0l4ude.fsf@tromey.com> <834m0l39co.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1486786396 18858 195.159.176.226 (11 Feb 2017 04:13:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 11 Feb 2017 04:13:16 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.91 (gnu/linux) Cc: 25525@debbugs.gnu.org, Tom Tromey To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Feb 11 05:13:11 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ccP3e-0004Sn-DK for geb-bug-gnu-emacs@m.gmane.org; Sat, 11 Feb 2017 05:13:10 +0100 Original-Received: from localhost ([::1]:47041 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ccP3i-0000GB-FJ for geb-bug-gnu-emacs@m.gmane.org; Fri, 10 Feb 2017 23:13:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51185) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ccP3Z-0000G0-Ii for bug-gnu-emacs@gnu.org; Fri, 10 Feb 2017 23:13:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ccP3W-0000AZ-Dg for bug-gnu-emacs@gnu.org; Fri, 10 Feb 2017 23:13:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:37046) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ccP3W-0000AT-9t for bug-gnu-emacs@gnu.org; Fri, 10 Feb 2017 23:13:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ccP3W-00029e-4A for bug-gnu-emacs@gnu.org; Fri, 10 Feb 2017 23:13:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Tom Tromey Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 11 Feb 2017 04:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25525 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 25525-submit@debbugs.gnu.org id=B25525.14867863278206 (code B ref 25525); Sat, 11 Feb 2017 04:13:02 +0000 Original-Received: (at 25525) by debbugs.gnu.org; 11 Feb 2017 04:12:07 +0000 Original-Received: from localhost ([127.0.0.1]:35245 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ccP2d-00028I-08 for submit@debbugs.gnu.org; Fri, 10 Feb 2017 23:12:07 -0500 Original-Received: from gproxy7-pub.mail.unifiedlayer.com ([70.40.196.235]:54827) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1ccP2b-00027o-A8 for 25525@debbugs.gnu.org; Fri, 10 Feb 2017 23:12:05 -0500 Original-Received: (qmail 26539 invoked by uid 0); 11 Feb 2017 04:11:54 -0000 Original-Received: from unknown (HELO cmgw3) (10.0.90.84) by gproxy7.mail.unifiedlayer.com with SMTP; 11 Feb 2017 04:11:54 -0000 Original-Received: from box522.bluehost.com ([74.220.219.122]) by cmgw3 with id jGBp1u00J2f2jeq01GBsYq; Fri, 10 Feb 2017 21:11:54 -0700 X-Authority-Analysis: v=2.1 cv=WOnsABcR c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=n2v9WMKugxEA:10 a=mDV3o1hIAAAA:8 a=Jyo5vD-BFT8nKQQ6RR0A:9 a=_FVE-zBwftR9WsbkzFJk:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=JrGpEyrwa6X0tbwABTRe9d34FPwkWT8qXb36KsEpdJU=; b=D8nstcsJP6IiBBnbLwrrLTxyO1 oInnFSPPW33blePpEb8AL0HSNK6llPVfgPzgTEfz6nx1bjTMmdlgrSh8y5JkWkAe/bJqcjlbYslDs Q87TQadgvX/u5caAE5j9siXcs; Original-Received: from 75-171-188-196.hlrn.qwest.net ([75.171.188.196]:49630 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1ccP2L-0005fG-48; Fri, 10 Feb 2017 21:11:49 -0700 X-Attribution: Tom In-Reply-To: <834m0l39co.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 26 Jan 2017 21:32:55 +0200") X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box522.bluehost.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.171.188.196 X-Exim-ID: 1ccP2L-0005fG-48 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-171-188-196.hlrn.qwest.net (bapiya) [75.171.188.196]:49630 X-Source-Auth: tom+tromey.com X-Email-Count: 5 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:129231 Archived-At: >>>>> "Eli" == Eli Zaretskii writes: Eli> I thought about something like Eli> (if (> (color-distance color "black") 292485) "black" "white") Eli> I think this is the equivalent of your test. I tried this. In particular with the patch applied, I did this in a temporary (fundamental-mode) buffer: (mapcar (lambda (c) (insert (propertize (car c) 'font-lock-face (list :background (cdr c) :foreground (css--contrasty-color (cdr c)))) " " (propertize (car c) 'font-lock-face (list :background (cdr c) :foreground (if (> (color-distance (cdr c) "black") 292485) "black" "white"))) "\n")) css--color-map) ... then I looked at all the pairs. For the most part I think they are all ok. Occasionally color-distance picks a different color, sometimes a mildly worse one IMO, though at least in one case ("grey") a mildly better one. Anyway, I think it's good enough, and if someone trips across a difficult case and files a bug, we can revisit it at that time. Tom