From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tom Tromey Newsgroups: gmane.emacs.bugs Subject: bug#25525: 25.1.90; add color highlighting to css mode Date: Sat, 04 Mar 2017 19:42:34 -0700 Message-ID: <87mvd0igv9.fsf@tromey.com> References: <87mvefh8br.fsf@tromey.com> <1485375833.1960.0@smtp.gmail.com> <1485455113.4245.1@smtp.gmail.com> <1487359774.1998.0@smtp.gmail.com> <1488653191.6153.0@smtp.gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1488681793 4149 195.159.176.226 (5 Mar 2017 02:43:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 5 Mar 2017 02:43:13 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) Cc: 25525@debbugs.gnu.org, Tom Tromey To: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Mar 05 03:43:09 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ckM8Z-0000Bj-DT for geb-bug-gnu-emacs@m.gmane.org; Sun, 05 Mar 2017 03:43:07 +0100 Original-Received: from localhost ([::1]:37325 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ckM8e-0002V2-0v for geb-bug-gnu-emacs@m.gmane.org; Sat, 04 Mar 2017 21:43:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39958) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ckM8Y-0002Um-87 for bug-gnu-emacs@gnu.org; Sat, 04 Mar 2017 21:43:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ckM8V-0001WD-0k for bug-gnu-emacs@gnu.org; Sat, 04 Mar 2017 21:43:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:42240) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ckM8U-0001W0-Tg for bug-gnu-emacs@gnu.org; Sat, 04 Mar 2017 21:43:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ckM8U-0000Ft-HY for bug-gnu-emacs@gnu.org; Sat, 04 Mar 2017 21:43:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Tom Tromey Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 Mar 2017 02:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25525 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 25525-submit@debbugs.gnu.org id=B25525.1488681775966 (code B ref 25525); Sun, 05 Mar 2017 02:43:02 +0000 Original-Received: (at 25525) by debbugs.gnu.org; 5 Mar 2017 02:42:55 +0000 Original-Received: from localhost ([127.0.0.1]:40439 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ckM8N-0000FW-21 for submit@debbugs.gnu.org; Sat, 04 Mar 2017 21:42:55 -0500 Original-Received: from gproxy7-pub.mail.unifiedlayer.com ([70.40.196.235]:41881) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1ckM8L-0000FG-OA for 25525@debbugs.gnu.org; Sat, 04 Mar 2017 21:42:54 -0500 Original-Received: (qmail 17195 invoked by uid 0); 5 Mar 2017 02:42:41 -0000 Original-Received: from unknown (HELO cmgw2) (10.0.90.83) by gproxy7.mail.unifiedlayer.com with SMTP; 5 Mar 2017 02:42:41 -0000 Original-Received: from box522.bluehost.com ([74.220.219.122]) by cmgw2 with id s2ic1u0032f2jeq012ifhW; Sat, 04 Mar 2017 19:42:41 -0700 X-Authority-Analysis: v=2.1 cv=H5NInYoi c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=IkcTkHD0fZMA:10 a=6Iz7jQTuP9IA:10 a=pGLkceISAAAA:8 a=32JuczK8xAGvGqqeEKgA:9 a=QEXdDO2ut3YA:10 a=6kGIvZw6iX1k4Y-7sg4_:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=aRS65hMy3hnX8iP36AsOiCceRfqrWdYWpTEvs9dO1eY=; b=b0GDbUDX7vzBptg4yunPOsMUws mjb5V9UKtmV+b0jj6ikhuePYfeM1PZZkj0hvmJulXX81m87LUVLodZ6/bDEof5S1PPDE6vVBmrOQ8 HzMcANNIeHosh2TlA79Qa8Mvf; Original-Received: from 71-218-43-111.hlrn.qwest.net ([71.218.43.111]:52940 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1ckM83-0004BN-Pq; Sat, 04 Mar 2017 19:42:35 -0700 X-Attribution: Tom In-Reply-To: <1488653191.6153.0@smtp.gmail.com> ("Simen \=\?utf-8\?Q\?Heggest\?\= \=\?utf-8\?Q\?\=C3\=B8yl\=22's\?\= message of "Sat, 04 Mar 2017 19:46:31 +0100") X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box522.bluehost.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.218.43.111 X-Exim-ID: 1ckM83-0004BN-Pq X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-218-43-111.hlrn.qwest.net (bapiya) [71.218.43.111]:52940 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:130202 Archived-At: >>>>> "Simen" =3D=3D Simen Heggest=C3=B8yl writes: Simen> There is also a test failure when you rebase the patch on the latest Simen> master due to the changes in 7b00e956b4. It can be fixed by passing 2 Simen> as the last argument to `color-rgb-to-hex' in `css--hsl-color'. This happens due to the change in 7b00e956b485d8ade03c870cbdd0ae086348737b, which changed color-name-to-rgb in a backward-incompatible way. Eli, you made this change -- it seems to me that it would be safer if it defaulted to 2 digits, which was how it worked previously. This would be backward-compatible and allow the new functionality as well. Tom