From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#26126: 26.0.50; file-notify-rm-watch removes arbitrary watches Date: Fri, 17 Mar 2017 17:08:10 +0100 Message-ID: <87mvcjophx.fsf@detlef> References: <87r31x9ulw.fsf@luca> <87shmcney8.fsf@detlef> <87efxw7xvc.fsf@luca> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1489766966 32642 195.159.176.226 (17 Mar 2017 16:09:26 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 17 Mar 2017 16:09:26 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: 26126@debbugs.gnu.org To: Andreas Politz Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Mar 17 17:09:20 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1couRE-0007B4-F4 for geb-bug-gnu-emacs@m.gmane.org; Fri, 17 Mar 2017 17:09:12 +0100 Original-Received: from localhost ([::1]:49777 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1couRI-0006hR-RD for geb-bug-gnu-emacs@m.gmane.org; Fri, 17 Mar 2017 12:09:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47306) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1couR9-0006fx-Sx for bug-gnu-emacs@gnu.org; Fri, 17 Mar 2017 12:09:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1couR4-0007SQ-RE for bug-gnu-emacs@gnu.org; Fri, 17 Mar 2017 12:09:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:34615) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1couR4-0007SK-Nb for bug-gnu-emacs@gnu.org; Fri, 17 Mar 2017 12:09:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1couR4-0002fv-Io for bug-gnu-emacs@gnu.org; Fri, 17 Mar 2017 12:09:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 17 Mar 2017 16:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26126 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 26126-submit@debbugs.gnu.org id=B26126.148976690110228 (code B ref 26126); Fri, 17 Mar 2017 16:09:02 +0000 Original-Received: (at 26126) by debbugs.gnu.org; 17 Mar 2017 16:08:21 +0000 Original-Received: from localhost ([127.0.0.1]:32814 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1couQO-0002eu-Tm for submit@debbugs.gnu.org; Fri, 17 Mar 2017 12:08:21 -0400 Original-Received: from mout.gmx.net ([212.227.17.21]:62971) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1couQN-0002eg-91 for 26126@debbugs.gnu.org; Fri, 17 Mar 2017 12:08:19 -0400 Original-Received: from detlef.gmx.de ([93.209.75.8]) by mail.gmx.com (mrgmx102 [212.227.17.168]) with ESMTPSA (Nemesis) id 0LuJDv-1c6sk03GiN-011meL; Fri, 17 Mar 2017 17:08:11 +0100 In-Reply-To: <87efxw7xvc.fsf@luca> (Andreas Politz's message of "Fri, 17 Mar 2017 15:59:19 +0100") X-Provags-ID: V03:K0:Nu9e19Xnqh4DpdPHxGgjsXLjxAsW6zlIWbkEP25XeACtxm/UrLP xR0Gw/EjIvgw7jQze3MPdUMiIquHjHCnTIrALAL5kpMoTs/iyLZB9TCh9rys2j9wniUInaA l7L2sJZF6mAUIDSs+vC3L2SVrJU1X1z4ZTYxxipC7lKJH+F/fdTHlk/SCHeCZOWQ+tF3I4e 2jpD7jZujxTvlJThY724g== X-UI-Out-Filterresults: notjunk:1;V01:K0:hpDwCde6o5A=:7cLWxd2VmZjaS3l3w/DYOB ywFV9dq6/yBvpIe04fAvLYRNnlaKE17OP+U6lwtnk+mo4ua/PLlO85uMbf52JRJpja7L/TDUx TIKvp9WjPj5bQ/pWOXB1rDlwKSNUL3uZcWsIulCRCXxLTVL3XErCKRpsEYRjOQz7aj/Eo/LhI /DWHKxkYFKZ0h3RL/3xlzL2vQg9EYvPf8dDGQKGv0gF1/kuGIh6KZDbOQgUkb9pFTR0opB7An aYLuaX6N493txaUDAe9Fo8XEKFmD/SBbmDqL3OrwxGkKlMZZS8Ly4PgI9wvVQ9lPc99WejI1Z 1wSm1VEq2XfPaZVPiDxvPq41toAy9U/RvoF6yjKgF+Civv3sx9/h2t4L2ccUnfnQsOTECKPBc NifypVWxibVjdJcS9Lycgv0UDJlq5yoAGYxFFOqM0iUwX+ncDoxdYhACIrmYLr9ek766RCsPl d8jNjJO59UfFhmV5rpz0/ZYbOKXTlb3y//e1SFdGWaW1KRMKQIRsRpbgcTD6jks9WjJw0ZeWZ L/+HHIYgVnBwlmCOEfkVyhTHEdLNaSzc8fXEw3Lj+33LFoEk5xI/+keq6yUDbQ3NIqYqssBnE S8CSUOCF+IkaantYQyN/f8PJ3Lls2Cb/y7JefwIwAswHVFFMHEmA3q0mS9AKhdE4pKcbsqtUO yJpiuYYiSdr5SEUck14yUZxBCQBOdrN7cZyvEi8Pt3hwZ1x90rmNGnPZoO1wNl3StbCjjwk4P QsWMf8E0tkQWTIU6mBOlRhyCOfQ6jn0EPFJBgTPbUw0VamndJxnAmqvcPfjEqv4duFqfBxLL X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:130678 Archived-At: Andreas Politz writes: Hi Andreas, > Michael Albinus writes: > >> With the returned descriptors, it cannot be decided which watch has to >> be removed, because both descriptors are equal. So we could decide >> either to remove all watches for a given file if such a descriptor is >> passed to `file-notify-rm-watch', or we must adapt >> `file-notify-add-watch' to return different descriptors. I'm undecided >> yet. > > Surely, we want the ability of two or more different packages being able > to watch the same file, without interfering with each other. Why are > you undecided ? I need to dig into inotify.c. IIRC, it wasn't simple to achieve this; that's why we have this crude solution. Maybe it could be solved only on filenotify.el level, don't remember the details. > I could try and find a solution, if you don't have time or anything. I don't have time, indeed. If you want to work on this, I would appreciate. You could always ping me if you have questions. Pls don't forget, whatever you propose must work for at least 6 different backends: inotify, kqueue, gfilenotify, w32notify and the remote gvfs-monitor-dir and inotifywait. Heavy tests, always. > -ap Best regards, Michael.