From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tom Tromey Newsgroups: gmane.emacs.bugs Subject: bug#28427: 26.0.50; revert-buffer and git vc-outgoing Date: Mon, 11 Sep 2017 21:36:10 -0600 Message-ID: <87mv60fv11.fsf@bapiya> References: <87r2vcg9gy.fsf@bapiya> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1505187446 7340 195.159.176.226 (12 Sep 2017 03:37:26 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 12 Sep 2017 03:37:26 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: 28427@debbugs.gnu.org To: Tom Tromey Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Sep 12 05:37:22 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1drc0Y-0000qr-3n for geb-bug-gnu-emacs@m.gmane.org; Tue, 12 Sep 2017 05:37:06 +0200 Original-Received: from localhost ([::1]:33410 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1drc0d-0000QY-Qc for geb-bug-gnu-emacs@m.gmane.org; Mon, 11 Sep 2017 23:37:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51948) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1drc0X-0000Nm-ML for bug-gnu-emacs@gnu.org; Mon, 11 Sep 2017 23:37:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1drc0U-0005C3-E4 for bug-gnu-emacs@gnu.org; Mon, 11 Sep 2017 23:37:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:54034) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1drc0U-0005Bf-A6 for bug-gnu-emacs@gnu.org; Mon, 11 Sep 2017 23:37:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1drc0U-0000OB-4A for bug-gnu-emacs@gnu.org; Mon, 11 Sep 2017 23:37:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tom Tromey Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 12 Sep 2017 03:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28427 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-Cc: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.15051873931458 (code B ref -1); Tue, 12 Sep 2017 03:37:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 12 Sep 2017 03:36:33 +0000 Original-Received: from localhost ([127.0.0.1]:34482 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1drc00-0000NS-Sm for submit@debbugs.gnu.org; Mon, 11 Sep 2017 23:36:33 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:60844) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1drbzz-0000NG-BM for submit@debbugs.gnu.org; Mon, 11 Sep 2017 23:36:31 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1drbzt-0004q4-FW for submit@debbugs.gnu.org; Mon, 11 Sep 2017 23:36:26 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:46054) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1drbzt-0004q0-CJ for submit@debbugs.gnu.org; Mon, 11 Sep 2017 23:36:25 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51811) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1drbzs-00009E-6E for bug-gnu-emacs@gnu.org; Mon, 11 Sep 2017 23:36:25 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1drbzo-0004oT-VR for bug-gnu-emacs@gnu.org; Mon, 11 Sep 2017 23:36:24 -0400 Original-Received: from gproxy7-pub.mail.unifiedlayer.com ([70.40.196.235]:42689) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1drbzo-0004o0-Lt for bug-gnu-emacs@gnu.org; Mon, 11 Sep 2017 23:36:20 -0400 Original-Received: from cmgw4 (unknown [10.0.90.85]) by gproxy7.mail.unifiedlayer.com (Postfix) with ESMTP id E4DEE215D47 for ; Mon, 11 Sep 2017 21:36:16 -0600 (MDT) Original-Received: from box522.bluehost.com ([74.220.219.122]) by cmgw4 with id 8TcC1w00t2f2jeq01TcFV7; Mon, 11 Sep 2017 21:36:16 -0600 X-Authority-Analysis: v=2.2 cv=OZLoNlbY c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=2JCJgTwv5E4A:10 a=zstS-IiYAAAA:8 a=wOBWjrf1j9wxlOkZBnoA:9 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=kDmnuRlIu8ZOFXXNlPIzIwxuzUGvYpLuDyamlg4Eu9U=; b=KHaWXyc73iO6tVv5AKCoXMI+a2 3E+lwPa2RlkkDKE9tTj56kQ9sO/PcRFa+oadFhvYEUw7m0KiDffcMKqtUnxtGdUQbuy6j0NbhCZr3 cFQSOHVsEwddgC1xpwEMCzAWL; Original-Received: from 75-166-76-94.hlrn.qwest.net ([75.166.76.94]:53074 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1drbzg-0023Ms-FA; Mon, 11 Sep 2017 21:36:12 -0600 X-Attribution: Tom In-Reply-To: <87r2vcg9gy.fsf@bapiya> (Tom Tromey's message of "Mon, 11 Sep 2017 16:24:13 -0600") X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box522.bluehost.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.76.94 X-Exim-ID: 1drbzg-0023Ms-FA X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-76-94.hlrn.qwest.net (bapiya) [75.166.76.94]:53074 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-Local-Domain: yes X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:136821 Archived-At: >>>>> "Tom" == Tom Tromey writes: Tom> I have a local git branch. I open vc-dir and use "O" to get the Tom> outgoing revisions. Tom> In *vc-outgoing*, if I type 'g' (revert-buffer), it doesn't first erase Tom> the buffer, so all the outgoing revisions are repeated. This patch seems to do it. I changed vc-git-log-incoming as well since it looks like it should have the same problem. Tom diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el index cc3e295..47b661a 100644 --- a/lisp/vc/vc-git.el +++ b/lisp/vc/vc-git.el @@ -1029,6 +1030,7 @@ vc-git-print-log '("--"))))))) (defun vc-git-log-outgoing (buffer remote-location) + (vc-setup-buffer buffer) (interactive) (vc-git-command buffer 'async nil @@ -1043,6 +1045,7 @@ vc-git-log-outgoing (defun vc-git-log-incoming (buffer remote-location) (interactive) + (vc-setup-buffer buffer) (vc-git-command nil 0 nil "fetch") (vc-git-command buffer 'async nil