From: Juri Linkov <juri@linkov.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 30215-done@debbugs.gnu.org
Subject: bug#30215: Visiting files from zip archives should not modify directory time
Date: Thu, 25 Jan 2018 23:41:10 +0200 [thread overview]
Message-ID: <87mv114nwp.fsf@mail.linkov.net> (raw)
In-Reply-To: <83o9limx84.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 25 Jan 2018 05:30:19 +0200")
>> > If that's the problem, then I think it would be cleaner to disable
>> > creation of lock files and backup files by less subtle means -- by
>> > let-binding create-lockfiles and make-backup-files. Doing that by
>> > leaving buffer-file-truename at nil leaves the code less clear IMO,
>> > and relies on assumptions that might not hold at some future point.
>>
>> Thanks for the suggestion, this is better indeed:
>>
>> diff --git a/lisp/arc-mode.el b/lisp/arc-mode.el
>> index adb3669..4fe1b03 100644
>> --- a/lisp/arc-mode.el
>> +++ b/lisp/arc-mode.el
>> @@ -807,7 +807,7 @@ archive-summarize
>> Optional argument SHUT-UP, if non-nil, means don't print messages
>> when parsing the archive."
>> (widen)
>> - (let ((buffer-file-truename nil) ; avoid changing dir mtime by lock_file
>> + (let ((create-lockfiles nil) ; avoid changing dir mtime by lock_file
>
> This LGTM,
Installed.
> but wasn't the problem also with creation of a backup file?
Creation of a backup file is not a problem, because backups are created
on saving. Visiting a file from a zip archive doesn't save it, and
thus doesn't create a backup. But when the user explicitly saves
a file inside a zip archive, only then it should modify the time
of its directory.
next prev parent reply other threads:[~2018-01-25 21:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-22 21:52 bug#30215: Visiting files from zip archives should not modify directory time Juri Linkov
2018-01-23 16:41 ` Eli Zaretskii
2018-01-23 21:29 ` Juri Linkov
2018-01-24 18:44 ` Eli Zaretskii
2018-01-24 21:36 ` Juri Linkov
2018-01-25 3:30 ` Eli Zaretskii
2018-01-25 21:41 ` Juri Linkov [this message]
2018-01-26 7:59 ` Eli Zaretskii
2018-01-27 21:16 ` Juri Linkov
2018-01-28 17:23 ` Eli Zaretskii
2018-01-28 21:28 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mv114nwp.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=30215-done@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).