From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#31742: 26.1.50; excorporate.elc byte-compiled in Emacs 25.x fails in Emacs 26.1 Date: Sat, 09 Jun 2018 08:13:03 -0400 Message-ID: <87muw417lc.fsf@gmail.com> References: <87po132y9k.fsf@gmail.com> <87h8me3hyw.fsf@gmail.com> <87zi0611m6.fsf@gmail.com> <87vaat1ndq.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1528546328 28084 195.159.176.226 (9 Jun 2018 12:12:08 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 9 Jun 2018 12:12:08 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Cc: Alex Harsanyi , 31742@debbugs.gnu.org To: Thomas Fitzsimmons Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jun 09 14:12:03 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRciw-00078t-W9 for geb-bug-gnu-emacs@m.gmane.org; Sat, 09 Jun 2018 14:12:03 +0200 Original-Received: from localhost ([::1]:40196 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fRcl2-00047A-9z for geb-bug-gnu-emacs@m.gmane.org; Sat, 09 Jun 2018 08:14:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44282) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fRckv-00046r-9L for bug-gnu-emacs@gnu.org; Sat, 09 Jun 2018 08:14:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fRcks-0002kT-5G for bug-gnu-emacs@gnu.org; Sat, 09 Jun 2018 08:14:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60747) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fRcks-0002kK-1D for bug-gnu-emacs@gnu.org; Sat, 09 Jun 2018 08:14:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fRckr-0002tP-MS for bug-gnu-emacs@gnu.org; Sat, 09 Jun 2018 08:14:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 09 Jun 2018 12:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31742 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 31742-submit@debbugs.gnu.org id=B31742.152854639311052 (code B ref 31742); Sat, 09 Jun 2018 12:14:01 +0000 Original-Received: (at 31742) by debbugs.gnu.org; 9 Jun 2018 12:13:13 +0000 Original-Received: from localhost ([127.0.0.1]:40411 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRck4-0002sC-QE for submit@debbugs.gnu.org; Sat, 09 Jun 2018 08:13:12 -0400 Original-Received: from mail-io0-f172.google.com ([209.85.223.172]:35225) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRck3-0002rz-BT for 31742@debbugs.gnu.org; Sat, 09 Jun 2018 08:13:11 -0400 Original-Received: by mail-io0-f172.google.com with SMTP id u4-v6so18868712iof.2 for <31742@debbugs.gnu.org>; Sat, 09 Jun 2018 05:13:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=TWcd8vxb63d1zKB5WIPNf8rc7ddX3SXx1BskJzZVETs=; b=rGJUFqf2mcSopvf8gaV6zLwh+j9bsbvQvdPZfppvaVAh2uKnLZrOs+UdH79mnkfiPK R1KNMZ1DAf+K+rXH+/d5Odkmpgv8pFsgOK4x6o1pzXcn9wgNIMMZICF2fVCLA+e6/mjU l15x5SoKKcI6HREPc9KCdtd9fiyCm7GUkGEh6jYejDnymEHFCF64MhY5FsgjCVWCuMqV 79PSVF+IFeBafZXfx5P6t9ww9+QY/S7wCIApTECFxVPIj1paD02pbxYw0GrhXyzlq5yA ADZjTNYmXoBrNGYKRAZLChGfq8siOwZeV/i8KrqET95I319dS8jbA+zb68NwovM4CBgq Ah1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=TWcd8vxb63d1zKB5WIPNf8rc7ddX3SXx1BskJzZVETs=; b=BASxcmMVnH3rOjFbMqwN45KV+oLeiqnJPVkqn9SPh7d8/Wy6mKMsouV7TB1hEdL0Nc ANb0wZ6S8SZ87XJHwJggacoIiiJFg1DOIPts0PYa7u71QBBPuqmwwFqVz3uNDHnNQqgc 2zpZMbNI5z1510ZVCHO0AVidHIRucQZJmHJOMOzxsfCZzRPdVknG428JiT+32Aehk/vF bbE5mJrF2aJD0n1pejg6ElCoap3tfKCwnFZN5jjW2aTy4ihNezwxtcF3t43/wW+MUOez o8xhuCgEfFRlSyyNpbOKsR0fkwKDrLNvXqlxyeQtiLiX4QYbZp4UWUGnDEpkusTVlBjB CAeQ== X-Gm-Message-State: APt69E22/21tn5n7nB0XSIQHKHtYyYdlC21EAPoY2KplLfshkV++1hcb r1HIVdsJ39V0vuP7BwHlloCBxA== X-Google-Smtp-Source: ADUXVKIRNqn4mKO9+tl4ehEpSaJvm7fcz9iTi8p99Nlqw6a0xRxssC00kMCqxPiBRVAF8t0ZJR+O0A== X-Received: by 2002:a6b:214a:: with SMTP id h71-v6mr7810598ioh.229.1528546385572; Sat, 09 Jun 2018 05:13:05 -0700 (PDT) Original-Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id z70-v6sm1983890itb.14.2018.06.09.05.13.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 09 Jun 2018 05:13:04 -0700 (PDT) In-Reply-To: (Thomas Fitzsimmons's message of "Sat, 09 Jun 2018 06:30:21 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:147237 Archived-At: >> The `(aref element 0)` trick is the only one that `soap-client` uses. All >> other struct usage is via accessor functions, the rest of the code does not >> assume they are vectors. It seems to me that `cl-old-struct-compat-mode` is >> not needed. > I went back and tested with cl-old-struct-compat-mode disabled, with the > soap-type-of patch, and I get an earlier failure, via M-x excorporate: > So at least for Excorporate, cl-old-struct-compat-mode is > needed (in addition to the (aref ... 0) -> (soap-type-of ...) > soap-client change). Yeah, and for (type-of element) to properly substitute for (aref element 0) without cl-old-struct-compat-mode you would need (defun soap-type-of (element) "Return the type of ELEMENT." (let ((type (type-of element))) (unless (eq type 'vector) ; For Emacs 25 and earlier. (setq type (aref element 0))) (if (string-match "\\`cl-struct-" (symbol-name type)) ; Old-style struct. (intern (substring (symbol-name type) (match-end 0))) type))) But since cl-old-struct-compat-mode activates automagically, may as well take advantage of it.