From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#22978: 25.0.92; log-view-diff: TMM required for non-consecutive revisions Date: Wed, 20 Jun 2018 00:00:25 -0400 Message-ID: <87muvqrtt2.fsf@gmail.com> References: <22241.43759.289350.874836@gargle.gargle.HOWL> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1529467155 23965 195.159.176.226 (20 Jun 2018 03:59:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 20 Jun 2018 03:59:15 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Cc: 22978@debbugs.gnu.org To: Bob Rogers Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jun 20 05:59:11 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fVUH0-0006AC-Kg for geb-bug-gnu-emacs@m.gmane.org; Wed, 20 Jun 2018 05:59:10 +0200 Original-Received: from localhost ([::1]:45960 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fVUJ7-0004dn-VZ for geb-bug-gnu-emacs@m.gmane.org; Wed, 20 Jun 2018 00:01:22 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53425) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fVUIr-0004ZB-E5 for bug-gnu-emacs@gnu.org; Wed, 20 Jun 2018 00:01:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fVUIo-0007D0-CQ for bug-gnu-emacs@gnu.org; Wed, 20 Jun 2018 00:01:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:48922) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fVUIo-0007Cq-7x for bug-gnu-emacs@gnu.org; Wed, 20 Jun 2018 00:01:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fVUIn-0007dH-Qj for bug-gnu-emacs@gnu.org; Wed, 20 Jun 2018 00:01:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 20 Jun 2018 04:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22978 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 22978-submit@debbugs.gnu.org id=B22978.152946723629298 (code B ref 22978); Wed, 20 Jun 2018 04:01:01 +0000 Original-Received: (at 22978) by debbugs.gnu.org; 20 Jun 2018 04:00:36 +0000 Original-Received: from localhost ([127.0.0.1]:56819 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fVUIN-0007cU-Nb for submit@debbugs.gnu.org; Wed, 20 Jun 2018 00:00:35 -0400 Original-Received: from mail-it0-f42.google.com ([209.85.214.42]:33835) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fVUIM-0007cH-23 for 22978@debbugs.gnu.org; Wed, 20 Jun 2018 00:00:34 -0400 Original-Received: by mail-it0-f42.google.com with SMTP id y127-v6so16591431itd.1 for <22978@debbugs.gnu.org>; Tue, 19 Jun 2018 21:00:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=r8nuZnMXVPqlUEPHwY22Wmop8bNwrhuUUTDQ5sSppec=; b=qvSK4RBT/BEpUnRbwuF/FG35qPm/A1nIbct5pHW/ZWm49B744K6tvI2BtusntjaRZ9 pMDolcIl/jLdVXaJfhvvgBtE3db4RYG5bS54N/U24JYWYOIu2TD4Wuv2gNrzHASPf8LJ OUj17KJkIpzmbDdja27V2IPe9ZdgDk00jLtJbo86ZvjBtkU2pnEI8mstLxlffnP6ap7r lpM5rEObhMVD7TGx8IqS+gsKzKYi4YF+jT+nCTayj++XnLNwex7CRWk1KqM5bttlNMwr 75CgJyLNg9u0whcWVSFGH6B5AyVt/cRfxXDEb8lXYNJuFq/3UNccUkGtJ8rtNSXM0rZL fgHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=r8nuZnMXVPqlUEPHwY22Wmop8bNwrhuUUTDQ5sSppec=; b=ZcchjJAnk8/5XLw03RHE5nnDp+U2cKgH5dnkrqddgw+wgLkCOuoFji3A4U+AUS6BS1 B72kyVSdYJSF7rB08p8YO2aLC8HlPq2N2S0CoTHuJqUqmhADHNS3zZ2/6xheOjqCJn/4 2X7hi6As4zU6M7s4fnh5tFHf+bvJ0GCpVlo3CMbr3ei2OpsN06l/ByUpGANQnFMQDqOl AX0ucZ2NDBS9xqgsaX2o7ULFWlVsCBEMTXYtc5OVaviI0JZlgdFm1EZhDVpE8gQTdqnY rmQVDFu1ClmbPl/nysVlM3xZuMW7bprA5elCLiBgXG1lMi+AQ3BiQp0Vi2k11KR8ywqs kFCA== X-Gm-Message-State: APt69E0pDDERKGC65wZXC4i9ApCv8Jf0UDmCpeJDRZHt4wNCvFBB/tbR NMkHGMFFZan9eqbFh8OTHwwg0A== X-Google-Smtp-Source: ADUXVKIKfhy9p9yca+q4vDAlfWZu53fNVFFL3Htfl9jBi/u1E0kpffg65XohwIfWis0D9Vnoz5e5lQ== X-Received: by 2002:a24:68a:: with SMTP id 132-v6mr301608itv.44.1529467228231; Tue, 19 Jun 2018 21:00:28 -0700 (PDT) Original-Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id h2-v6sm858125itb.20.2018.06.19.21.00.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 19 Jun 2018 21:00:27 -0700 (PDT) In-Reply-To: <22241.43759.289350.874836@gargle.gargle.HOWL> (Bob Rogers's message of "Thu, 10 Mar 2016 12:12:15 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:147643 Archived-At: Bob Rogers writes: > The documentation for log-view-diff implies that this is the correct > behavior (since the region is perpetually inactive if TMM is disabled), > but this is extremely non-featureful, as there is then no way to find > the diff between two non-consecutive revisions without enabling TMM. You can still use C-SPC C-SPC to activate the mark temporarily. > The patch included at the bottom restores the original behavior for us > non-TMM users while keeping TMM behavior. Not sure if it makes sense to change this. > --- /usr/share/emacs/25.0.92/lisp/vc/log-view.el.gz > +++ # > @@ -591,7 +591,9 @@ > file(s)." > (interactive > (list (if (use-region-p) (region-beginning) (point)) > - (if (use-region-p) (region-end) (point)))) > + (if (use-region-p) > + (region-end) > + (or (and (not transient-mark-mode) (mark)) (point))))) > (log-view-diff-common beg end))