From: Noam Postavsky <npostavs@gmail.com>
To: Bob Rogers <rogers@modulargenetics.com>
Cc: 22978@debbugs.gnu.org
Subject: bug#22978: 25.0.92; log-view-diff: TMM required for non-consecutive revisions
Date: Wed, 20 Jun 2018 00:00:25 -0400 [thread overview]
Message-ID: <87muvqrtt2.fsf@gmail.com> (raw)
In-Reply-To: <22241.43759.289350.874836@gargle.gargle.HOWL> (Bob Rogers's message of "Thu, 10 Mar 2016 12:12:15 -0500")
Bob Rogers <rogers@modulargenetics.com> writes:
> The documentation for log-view-diff implies that this is the correct
> behavior (since the region is perpetually inactive if TMM is disabled),
> but this is extremely non-featureful, as there is then no way to find
> the diff between two non-consecutive revisions without enabling TMM.
You can still use C-SPC C-SPC to activate the mark temporarily.
> The patch included at the bottom restores the original behavior for us
> non-TMM users while keeping TMM behavior.
Not sure if it makes sense to change this.
> --- /usr/share/emacs/25.0.92/lisp/vc/log-view.el.gz
> +++ #<buffer log-view.el.gz>
> @@ -591,7 +591,9 @@
> file(s)."
> (interactive
> (list (if (use-region-p) (region-beginning) (point))
> - (if (use-region-p) (region-end) (point))))
> + (if (use-region-p)
> + (region-end)
> + (or (and (not transient-mark-mode) (mark)) (point)))))
> (log-view-diff-common beg end))
next prev parent reply other threads:[~2018-06-20 4:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-10 17:12 bug#22978: 25.0.92; log-view-diff: TMM required for non-consecutive revisions Bob Rogers
2018-06-20 4:00 ` Noam Postavsky [this message]
2018-06-20 16:25 ` Eli Zaretskii
2018-06-27 20:04 ` Bob Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87muvqrtt2.fsf@gmail.com \
--to=npostavs@gmail.com \
--cc=22978@debbugs.gnu.org \
--cc=rogers@modulargenetics.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).