From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Alex Branham Newsgroups: gmane.emacs.bugs Subject: bug#34419: 27.0.50; [PATCH] Use lexical-binding in conf-mode.el Date: Fri, 15 Feb 2019 07:26:36 -0600 Message-ID: <87mumxnpwz.fsf@gmail.com> References: <87o97jnzw9.fsf@gmail.com> <83sgwul3wc.fsf@gnu.org> <87va1qm05q.fsf@gmail.com> <834l95o2v1.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="185287"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: mu4e 1.1.0; emacs 27.0.50 Cc: 34419@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Feb 15 14:27:26 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gudWX-000m4A-P0 for geb-bug-gnu-emacs@m.gmane.org; Fri, 15 Feb 2019 14:27:25 +0100 Original-Received: from localhost ([127.0.0.1]:39865 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gudWT-0002jM-24 for geb-bug-gnu-emacs@m.gmane.org; Fri, 15 Feb 2019 08:27:21 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:45123) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gudWH-0002i1-3D for bug-gnu-emacs@gnu.org; Fri, 15 Feb 2019 08:27:10 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gudWB-0008D7-Du for bug-gnu-emacs@gnu.org; Fri, 15 Feb 2019 08:27:09 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49401) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gudWB-0008Cw-A9 for bug-gnu-emacs@gnu.org; Fri, 15 Feb 2019 08:27:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gudWA-0006B9-Vx for bug-gnu-emacs@gnu.org; Fri, 15 Feb 2019 08:27:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alex Branham Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 15 Feb 2019 13:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34419 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 34419-submit@debbugs.gnu.org id=B34419.155023721023727 (code B ref 34419); Fri, 15 Feb 2019 13:27:02 +0000 Original-Received: (at 34419) by debbugs.gnu.org; 15 Feb 2019 13:26:50 +0000 Original-Received: from localhost ([127.0.0.1]:48682 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gudVy-0006Ac-7p for submit@debbugs.gnu.org; Fri, 15 Feb 2019 08:26:50 -0500 Original-Received: from mail-ot1-f47.google.com ([209.85.210.47]:42728) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gudVu-0006AG-QH for 34419@debbugs.gnu.org; Fri, 15 Feb 2019 08:26:47 -0500 Original-Received: by mail-ot1-f47.google.com with SMTP id i5so16414003oto.9 for <34419@debbugs.gnu.org>; Fri, 15 Feb 2019 05:26:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=2LBJgiUZJnjfPc+UHhzkXt7MNhshndExFC1V0GAoEOA=; b=tkvK3HRRS4kGyLFJIXz1IOSZNg062iIRYE29JYYsKBSyprNMEejlVRCcIlWd21+mv0 MiHakMRZX0SklXJDnYlXtohc/uw+gfxSJbRco6Q/5B7TyOrnGl3/1rou32Y+3H3HccPh bcnEmvqP87a92Ncm3GTHRMu955adtI8adaqwj2wVALULLKXsFk4IQ4sfMTxYJNOc5vOr XxTeeBg0lv9sobprH9M4/BHQHMYMutoMsJGng3NpbfiZhQhbVC8t7vUbtU+lNUTJA5l9 uxsRmVk7Ro+4VN4GQeMBIrj/hryWVLc9PZMrDXzyPz6SOdCc4l0A1/9DxoDMN5/nr17Q mVaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=2LBJgiUZJnjfPc+UHhzkXt7MNhshndExFC1V0GAoEOA=; b=hy5Xj2vUDZDCtGn76GDunFUOXXYldypYT97DKYmfvLF2i1QrPBApZWYgBUzmguZ2zy MVZLWC0vyPRCF14tGnWkvoc3RzRRhMhVdKAygHhFGw/HEfWipuQ/YBSyqNy4w+Lyi+pQ PLnSCoWjH+NU3TEDPysBCOUdmfixyoNoGkQzoKY48+REI5h3J8/7Ds6vaK3vVrpSUUv+ 3kxb0VVi1/LPTky8FlZR3s3ol7fIiu68t0hj1MUmMup+loRUvDtWsb52kV8enf4xterM fg2bzLjjcCDggAz0DYRXiumqbNyJS/YUyZLfETeFQwX20TIppMT+WM8y32Qf7VQXP0qW SN9g== X-Gm-Message-State: AHQUAuYs1tI5g8R3xkrcA/hg9Lom5emqnH7daLCuAaOSQYfhMvnbpfK+ 25Ytr2g1v9nC33nKSM96kp0LmWd9 X-Google-Smtp-Source: AHgI3IbkNePCPPPQ2DZk8WCwTmPLb8w/ngmGdCqsoTQG1BkfZr2ysmuAgnc6qiWMrr75RdUPq/UQZA== X-Received: by 2002:aca:5c88:: with SMTP id q130mr5526972oib.79.1550237200536; Fri, 15 Feb 2019 05:26:40 -0800 (PST) Original-Received: from earth (cpe-70-114-192-208.austin.res.rr.com. [70.114.192.208]) by smtp.gmail.com with ESMTPSA id f7sm2627922otb.56.2019.02.15.05.26.39 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 15 Feb 2019 05:26:39 -0800 (PST) In-reply-to: <834l95o2v1.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:155435 Archived-At: --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Fri 15 Feb 2019 at 02:46, Eli Zaretskii wrote: >> Either way, the attached patch should be OK I think. > > Thanks. As a further nit, please mention the bug number in the log > message when you know it (as you usually do when posting a second > version of the patches). Otherwise I need to add that manually with > "git commit --amend". I'm not sure why this is so hard for me to remember, sorry. Will try harder in the future (including the attached patch!). > Here's the diagnostics from the failed test; can you spot the problem? Have you changed `conf-assignment-column'? That would cause issues I guess. Here's a patch that sets it in the test: From=20bbc00e4f70425618f5a6ed59a00afe1d1fcf9427 Mon Sep 17 00:00:00 2001 From: Alex Branham Date: Fri, 15 Feb 2019 07:17:49 -0600 Subject: [PATCH] Fix a conf-mode test * test/lisp/textmodes/conf-mode-tests.el (conf-test-align-assignments): Set `conf-assignment-column'. Bug#34419 =2D-- test/lisp/textmodes/conf-mode-tests.el | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/test/lisp/textmodes/conf-mode-tests.el b/test/lisp/textmodes/c= onf-mode-tests.el index 5d79ceec96..effe8de397 100644 =2D-- a/test/lisp/textmodes/conf-mode-tests.el +++ b/test/lisp/textmodes/conf-mode-tests.el @@ -29,11 +29,12 @@ (ert-deftest conf-test-align-assignments () "Test for `conf-align-assignments'." (with-temp-buffer =2D (insert "foo: bar\nbar: baz") =2D (conf-colon-mode) =2D (conf-align-assignments) =2D (should (equal (buffer-string) =2D "foo: bar\nbar: = baz")))) + (let ((conf-assignment-column 24)) + (insert "foo: bar\nbar: baz") + (conf-colon-mode) + (conf-align-assignments) + (should (equal (buffer-string) + "foo: bar\nbar: = baz"))))) =20 (ert-deftest conf-test-font-lock () (with-temp-buffer =2D-=20 2.19.2 --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Fix-a-conf-mode-test.patch Content-Transfer-Encoding: quoted-printable From=20bbc00e4f70425618f5a6ed59a00afe1d1fcf9427 Mon Sep 17 00:00:00 2001 From: Alex Branham Date: Fri, 15 Feb 2019 07:17:49 -0600 Subject: [PATCH] Fix a conf-mode test * test/lisp/textmodes/conf-mode-tests.el (conf-test-align-assignments): Set `conf-assignment-column'. Bug#34419 =2D-- test/lisp/textmodes/conf-mode-tests.el | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/test/lisp/textmodes/conf-mode-tests.el b/test/lisp/textmodes/c= onf-mode-tests.el index 5d79ceec96..effe8de397 100644 =2D-- a/test/lisp/textmodes/conf-mode-tests.el +++ b/test/lisp/textmodes/conf-mode-tests.el @@ -29,11 +29,12 @@ (ert-deftest conf-test-align-assignments () "Test for `conf-align-assignments'." (with-temp-buffer =2D (insert "foo: bar\nbar: baz") =2D (conf-colon-mode) =2D (conf-align-assignments) =2D (should (equal (buffer-string) =2D "foo: bar\nbar: = baz")))) + (let ((conf-assignment-column 24)) + (insert "foo: bar\nbar: baz") + (conf-colon-mode) + (conf-align-assignments) + (should (equal (buffer-string) + "foo: bar\nbar: = baz"))))) =20 (ert-deftest conf-test-font-lock () (with-temp-buffer =2D-=20 2.19.2 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEeEJ4XAMgliXNXicpHkInolPpmscFAlxmvgwACgkQHkInolPp msehAgf+IKY7gZX1eDEHld+pk3P+W2aDHMDbXv3VTfoMB0cyNcWRgWSvM1epbUkg Io6Mz5qFoOzsQf6iyBwcDADwKu8Fx39Wf/43T5AKPrUKeHLFIulPMHERKAuW2hSW BOuGPnHVmWXh3uKGjNlHO6VtmZDKRbtRnYfaErqADC9rC7v/DqNlpALjkHdIfcfX AkytJi9GXhFe04B7IWF6z4TzaS1j3Mwr8buQ33D2J2mL/ukfej9CAeLaeh2yNjn1 Mkulld2ho67j9UjUrOLEIjGprNuICLUOS4Tn0hNapiUzSS2CP8upUTl7RzQGb90P 6VmRx4EppwMkphoGv5heGR1uNmciNg== =xbGv -----END PGP SIGNATURE----- --==-=-=--