From: Alex Branham <alex.branham@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 34419@debbugs.gnu.org
Subject: bug#34419: 27.0.50; [PATCH] Use lexical-binding in conf-mode.el
Date: Fri, 15 Feb 2019 07:26:36 -0600 [thread overview]
Message-ID: <87mumxnpwz.fsf@gmail.com> (raw)
In-Reply-To: <834l95o2v1.fsf@gnu.org>
[-- Attachment #1.1: Type: text/plain, Size: 2039 bytes --]
On Fri 15 Feb 2019 at 02:46, Eli Zaretskii <eliz@gnu.org> wrote:
>> Either way, the attached patch should be OK I think.
>
> Thanks. As a further nit, please mention the bug number in the log
> message when you know it (as you usually do when posting a second
> version of the patches). Otherwise I need to add that manually with
> "git commit --amend".
I'm not sure why this is so hard for me to remember, sorry. Will try
harder in the future (including the attached patch!).
> Here's the diagnostics from the failed test; can you spot the problem?
Have you changed `conf-assignment-column'? That would cause issues I
guess. Here's a patch that sets it in the test:
From bbc00e4f70425618f5a6ed59a00afe1d1fcf9427 Mon Sep 17 00:00:00 2001
From: Alex Branham <alex.branham@gmail.com>
Date: Fri, 15 Feb 2019 07:17:49 -0600
Subject: [PATCH] Fix a conf-mode test
* test/lisp/textmodes/conf-mode-tests.el (conf-test-align-assignments):
Set `conf-assignment-column'.
Bug#34419
---
test/lisp/textmodes/conf-mode-tests.el | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/test/lisp/textmodes/conf-mode-tests.el b/test/lisp/textmodes/conf-mode-tests.el
index 5d79ceec96..effe8de397 100644
--- a/test/lisp/textmodes/conf-mode-tests.el
+++ b/test/lisp/textmodes/conf-mode-tests.el
@@ -29,11 +29,12 @@
(ert-deftest conf-test-align-assignments ()
"Test for `conf-align-assignments'."
(with-temp-buffer
- (insert "foo: bar\nbar: baz")
- (conf-colon-mode)
- (conf-align-assignments)
- (should (equal (buffer-string)
- "foo: bar\nbar: baz"))))
+ (let ((conf-assignment-column 24))
+ (insert "foo: bar\nbar: baz")
+ (conf-colon-mode)
+ (conf-align-assignments)
+ (should (equal (buffer-string)
+ "foo: bar\nbar: baz")))))
(ert-deftest conf-test-font-lock ()
(with-temp-buffer
--
2.19.2
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-Fix-a-conf-mode-test.patch --]
[-- Type: text/x-patch, Size: 1338 bytes --]
From bbc00e4f70425618f5a6ed59a00afe1d1fcf9427 Mon Sep 17 00:00:00 2001
From: Alex Branham <alex.branham@gmail.com>
Date: Fri, 15 Feb 2019 07:17:49 -0600
Subject: [PATCH] Fix a conf-mode test
* test/lisp/textmodes/conf-mode-tests.el (conf-test-align-assignments):
Set `conf-assignment-column'.
Bug#34419
---
test/lisp/textmodes/conf-mode-tests.el | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/test/lisp/textmodes/conf-mode-tests.el b/test/lisp/textmodes/conf-mode-tests.el
index 5d79ceec96..effe8de397 100644
--- a/test/lisp/textmodes/conf-mode-tests.el
+++ b/test/lisp/textmodes/conf-mode-tests.el
@@ -29,11 +29,12 @@
(ert-deftest conf-test-align-assignments ()
"Test for `conf-align-assignments'."
(with-temp-buffer
- (insert "foo: bar\nbar: baz")
- (conf-colon-mode)
- (conf-align-assignments)
- (should (equal (buffer-string)
- "foo: bar\nbar: baz"))))
+ (let ((conf-assignment-column 24))
+ (insert "foo: bar\nbar: baz")
+ (conf-colon-mode)
+ (conf-align-assignments)
+ (should (equal (buffer-string)
+ "foo: bar\nbar: baz")))))
(ert-deftest conf-test-font-lock ()
(with-temp-buffer
--
2.19.2
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2019-02-15 13:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-10 20:37 bug#34419: 27.0.50; [PATCH] Use lexical-binding in conf-mode.el Alex Branham
2019-02-11 15:51 ` Eli Zaretskii
2019-02-11 22:26 ` Alex Branham
2019-02-15 8:46 ` Eli Zaretskii
2019-02-15 13:26 ` Alex Branham [this message]
2019-02-15 14:10 ` Eli Zaretskii
2019-02-18 17:17 ` Alex Branham
2019-02-18 17:44 ` Eli Zaretskii
2019-02-19 15:52 ` Alex Branham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mumxnpwz.fsf@gmail.com \
--to=alex.branham@gmail.com \
--cc=34419@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).