From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Alex Branham Newsgroups: gmane.emacs.bugs Subject: bug#33975: [PATCH] inhibit read-only text properties in comint-interrupt-subjob Date: Thu, 21 Feb 2019 10:32:16 -0600 Message-ID: <87mumpgl0v.fsf@gmail.com> References: <87d0pcfkjq.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="69208"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: mu4e 1.1.0; emacs 27.0.50 To: 33975@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Feb 21 17:33:26 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gwrHo-000HnI-TP for geb-bug-gnu-emacs@m.gmane.org; Thu, 21 Feb 2019 17:33:25 +0100 Original-Received: from localhost ([127.0.0.1]:34654 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gwrHn-0001id-RN for geb-bug-gnu-emacs@m.gmane.org; Thu, 21 Feb 2019 11:33:23 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:49566) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gwrHa-0001gr-7Z for bug-gnu-emacs@gnu.org; Thu, 21 Feb 2019 11:33:11 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gwrHY-0004f6-R7 for bug-gnu-emacs@gnu.org; Thu, 21 Feb 2019 11:33:10 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59007) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gwrHT-0004at-1n for bug-gnu-emacs@gnu.org; Thu, 21 Feb 2019 11:33:05 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gwrHS-0005M7-Hj for bug-gnu-emacs@gnu.org; Thu, 21 Feb 2019 11:33:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alex Branham Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 21 Feb 2019 16:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33975 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.155076676720565 (code B ref -1); Thu, 21 Feb 2019 16:33:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 21 Feb 2019 16:32:47 +0000 Original-Received: from localhost ([127.0.0.1]:59773 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gwrHD-0005Lc-4J for submit@debbugs.gnu.org; Thu, 21 Feb 2019 11:32:47 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:34993) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gwrHC-0005LQ-1s for submit@debbugs.gnu.org; Thu, 21 Feb 2019 11:32:46 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:55303) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gwrH6-0004No-Qa for submit@debbugs.gnu.org; Thu, 21 Feb 2019 11:32:40 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:49325) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gwrH5-0001Of-8h for bug-gnu-emacs@gnu.org; Thu, 21 Feb 2019 11:32:40 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gwrH4-0004JK-5P for bug-gnu-emacs@gnu.org; Thu, 21 Feb 2019 11:32:39 -0500 Original-Received: from mail-oi1-x243.google.com ([2607:f8b0:4864:20::243]:39530) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gwrH3-0004AT-Uo for bug-gnu-emacs@gnu.org; Thu, 21 Feb 2019 11:32:38 -0500 Original-Received: by mail-oi1-x243.google.com with SMTP id b4so1881642oif.6 for ; Thu, 21 Feb 2019 08:32:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:subject:in-reply-to:date:message-id :mime-version; bh=zolwCdh9kXkOMMg8gsZDCLzBhVWUMIwp6U9u11PbFiU=; b=JCgO3gxE8kJ/L/gbYPA6XoP0fThSxZ+5bVX46dYBWXfcX9niERuI48oIHwyhsTcHHc wA6ivtkqSkofm00lVTI1qxT4WQY9JDLRi+Vb4OSaIS7XemHI73mqEvV9tyWgkQK25g4z bjljUVZXSpNij8fVmT0fE7vB9/3J20FbdHqPX0vaXK5cxXemadgLKsoJtKIOwoLtmKtQ VkWaeq9O+NmgbvQD9uX5CCdBl03PE68t/9y4eRRcccmrkZPYQKaHzQFw8aI9B1u+9bJM bhQDXYWXgRGBEsf7wQzUo+/SkZL0Ug8Svg3ZteicHQwbNqWiiKvM7xbhZxwY8YFbwfDA 46BQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:subject :in-reply-to:date:message-id:mime-version; bh=zolwCdh9kXkOMMg8gsZDCLzBhVWUMIwp6U9u11PbFiU=; b=KcvUnvcruiBNnLERdZ8JjLfjQ4Z0ah0IbXBh6Opfzr8B4dBF0djYqYKCF8sm7YIFCg W/CdwEcRZDLN1PrQfNK3bFjRwer6eEjjPlMXxu5gKegjTd6B3VnPtMtW1FSUOFhyYezU BYUUnq+e8+gAUdK6D3rBzqrD6o1aBb0VLRY6N7nWSMj7KYZVQWekSqwRN+6JK+Vnt+hV xJ1Hh2AAzB5SMdraD8m2docCsh8l2bRVnGPxNu2mWyzlPuNPkmHCmkLWYDbB3ZCM5Z2e G2pzNzXe1M4Bd+xJ4d7hB7AtA+SomO1oeNGxYAhckwj1simFwU3AVlN26wsvOxabQGMS F3Zw== X-Gm-Message-State: AHQUAuZrfk8dHjTQzsNxG9a19OgMyB2NK9EkRUK0WisOrjGnHjhSFjyP BKZl5+a3zxp/uhTO6Sl4Pw58VtRm X-Google-Smtp-Source: AHgI3Iaf5aCwH3BN1aDGMzHqwhn7EB4XDBDAGixUlNDcbzoh+uvNlWkJZpRpdRxAmWApq2rtmkLKPw== X-Received: by 2002:aca:de84:: with SMTP id v126mr10258576oig.5.1550766738429; Thu, 21 Feb 2019 08:32:18 -0800 (PST) Original-Received: from mars (nat-128-62-60-177.public.utexas.edu. [128.62.60.177]) by smtp.gmail.com with ESMTPSA id b63sm11034418oih.24.2019.02.21.08.32.17 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 21 Feb 2019 08:32:17 -0800 (PST) In-reply-to: <87d0pcfkjq.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:155621 Archived-At: Hi all - Is this patch OK for Emacs? Or should we figure it out downstream? Thanks, Alex On Fri 04 Jan 2019 at 10:35, Alex Branham wrote: > Hi - > > This patch inhibits read-only properties during comint-interrupt-subjob. > I ran across this while using ESS and (setq comint-prompt-read-only t). > There's a little more info (including a reproducible example) on ESS's > bugtracker.[1] > > Thanks, > Alex > > From 8e3885c5b9747987cacd3b17b9de29975e7691e3 Mon Sep 17 00:00:00 2001 > From: Alex Branham > Date: Fri, 4 Jan 2019 10:28:09 -0600 > Subject: [PATCH] * lisp/comint.el (comint-interrupt-subjob): Inhibit read only > > Otherwise with comint-prompt-read-only set to t users can be incapable > of interrupting running busy processes. See ESS's issue tracker for > details: https://github.com/emacs-ess/ESS/issues/792 > --- > lisp/comint.el | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/lisp/comint.el b/lisp/comint.el > index 0a6aff2e73..2ed65c1c1c 100644 > --- a/lisp/comint.el > +++ b/lisp/comint.el > @@ -2500,8 +2500,9 @@ comint-clear-buffer > (defun comint-interrupt-subjob () > "Interrupt the current subjob." > (interactive) > - (comint-skip-input) > - (interrupt-process nil comint-ptyp) > + (let ((inhibit-read-only t)) > + (comint-skip-input) > + (interrupt-process nil comint-ptyp)) > ;; (process-send-string nil "\n") > ) > > -- > 2.19.2 > > > From 8e3885c5b9747987cacd3b17b9de29975e7691e3 Mon Sep 17 00:00:00 2001 > From: Alex Branham > Date: Fri, 4 Jan 2019 10:28:09 -0600 > Subject: [PATCH] * lisp/comint.el (comint-interrupt-subjob): Inhibit read only > > Otherwise with comint-prompt-read-only set to t users can be incapable > of interrupting running busy processes. See ESS's issue tracker for > details: https://github.com/emacs-ess/ESS/issues/792 > --- > lisp/comint.el | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/lisp/comint.el b/lisp/comint.el > index 0a6aff2e73..2ed65c1c1c 100644 > --- a/lisp/comint.el > +++ b/lisp/comint.el > @@ -2500,8 +2500,9 @@ comint-clear-buffer > (defun comint-interrupt-subjob () > "Interrupt the current subjob." > (interactive) > - (comint-skip-input) > - (interrupt-process nil comint-ptyp) > + (let ((inhibit-read-only t)) > + (comint-skip-input) > + (interrupt-process nil comint-ptyp)) > ;; (process-send-string nil "\n") > )