unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Alex Branham <alex.branham@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 33975@debbugs.gnu.org
Subject: bug#33975: [PATCH] inhibit read-only text properties in comint-interrupt-subjob
Date: Fri, 22 Feb 2019 15:26:00 -0600	[thread overview]
Message-ID: <87mumncy6v.fsf@gmail.com> (raw)
In-Reply-To: <83bm34fccz.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 642 bytes --]


On Fri 22 Feb 2019 at 02:37, Eli Zaretskii <eliz@gnu.org> wrote:

>> From: Alex Branham <alex.branham@gmail.com>
>> Date: Thu, 21 Feb 2019 10:32:16 -0600
>>
>> Is this patch OK for Emacs? Or should we figure it out downstream?
>
> Can you explain how having comint-prompt-read-only interferes with
> interrupt-process in this case?  I don't think I understand the
> connection, and neither this bug report nor the ESS issue do, AFAICT.

Sure thing. `comint-interrupt-subjob' calls `comint-skip-input', which
tries to do this:

(insert "  " (key-description (this-command-keys)))

Which fails if the text at point is read only.

Thanks,
Alex

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

  reply	other threads:[~2019-02-22 21:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-04 16:35 bug#33975: [PATCH] inhibit read-only text properties in comint-interrupt-subjob Alex Branham
2019-02-21 16:32 ` Alex Branham
2019-02-22  8:37   ` Eli Zaretskii
2019-02-22 21:26     ` Alex Branham [this message]
2019-02-23  8:51       ` Eli Zaretskii
2019-02-23 13:36         ` Alex Branham
2019-02-23 17:01           ` Eli Zaretskii
2019-02-24 14:47             ` Alex Branham
2019-02-25  1:11             ` Alex Branham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mumncy6v.fsf@gmail.com \
    --to=alex.branham@gmail.com \
    --cc=33975@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).