From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Ulf Jasper Newsgroups: gmane.emacs.bugs Subject: bug#35645: Fix icalendar--add-diary-entry/diary-make-entry interaction Date: Mon, 13 May 2019 19:53:25 +0200 Message-ID: <87mujqdywa.fsf@panama> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="141309"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Cc: 35645@debbugs.gnu.org To: Thomas Fitzsimmons Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon May 13 19:54:17 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hQF9U-000ac9-OA for geb-bug-gnu-emacs@m.gmane.org; Mon, 13 May 2019 19:54:16 +0200 Original-Received: from localhost ([127.0.0.1]:32866 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQF9T-0007Tq-N0 for geb-bug-gnu-emacs@m.gmane.org; Mon, 13 May 2019 13:54:15 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:48139) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQF9I-0007SR-Ds for bug-gnu-emacs@gnu.org; Mon, 13 May 2019 13:54:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hQF9H-0007dK-FO for bug-gnu-emacs@gnu.org; Mon, 13 May 2019 13:54:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60753) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hQF9H-0007d3-7u for bug-gnu-emacs@gnu.org; Mon, 13 May 2019 13:54:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hQF9G-0002U8-W4 for bug-gnu-emacs@gnu.org; Mon, 13 May 2019 13:54:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ulf Jasper Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 13 May 2019 17:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35645 X-GNU-PR-Package: emacs Original-Received: via spool by 35645-submit@debbugs.gnu.org id=B35645.15577700229515 (code B ref 35645); Mon, 13 May 2019 17:54:02 +0000 Original-Received: (at 35645) by debbugs.gnu.org; 13 May 2019 17:53:42 +0000 Original-Received: from localhost ([127.0.0.1]:46064 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQF8w-0002TP-EB for submit@debbugs.gnu.org; Mon, 13 May 2019 13:53:42 -0400 Original-Received: from mout.web.de ([212.227.15.3]:49991) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQF8t-0002T9-Ez for 35645@debbugs.gnu.org; Mon, 13 May 2019 13:53:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1557770012; bh=GX2zrvCz2IMEaaJiPO2sG/OuZCX607Dn9Ke9S7chqJo=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=G029mQm/U8ai5J+77+ZrS09SbRUWdNgWSHLaweIpPMdXDs5RhheeCLn+kRYro8FKd +dkZiVuLKLHa5g8Zq4pGamf3S+1Tk89PcttY7251ZxQAZg4Vk5ObUsdExBc2o4NQiS lDHMQUeJ5gaV0vd2DfnemCPfRh9inQKK8Cd43sQU= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Original-Received: from udesktop ([217.226.75.182]) by smtp.web.de (mrweb001 [213.165.67.108]) with ESMTPSA (Nemesis) id 0MUEoU-1hI1hG0DkA-00R1UT; Mon, 13 May 2019 19:53:32 +0200 In-Reply-To: (Thomas Fitzsimmons's message of "Wed, 08 May 2019 23:40:30 -0400") X-Provags-ID: V03:K1:+mRqvYWY9bCSIUK8XJKknXJBsY+Vg7JGzdrVuGkAIGMwNe46dHP WQFK/KfL2CitMybW6CzeH++/G3FXnH6Oz6fggieBxBjXcL4o6kZI8u/SdfSZRK9YkvH7tps utbUuz+vspn9BXGgQamDWUjGD+/sxk5PNACc6QjIxg50fjOb/5C7ZCD6jKgrTG6naWbaZAk wlwWFpPj/xtySYsk1vtmw== X-UI-Out-Filterresults: notjunk:1;V03:K0:N8l6pnPB4Cw=:1o+z9HvSw8Xnyl2gNqa/GA 2dlRnoC0S1MMXA5gaXRapxYFBLZwpu8FPgILQohAeIAvo5rSmCQ8Y2PSYcyvtgXowe78sTCyP 1Zc0zNgqsuNJLGEgVg1Fgrr7DOoQACe4trKcL1hvR0DkdDnEgWg4s2iTWzPvni+78CJYoVA4K 3FMxdQQisJiRL9ZBvZia4CxPO2du0QSnHhtZmRXATG0ileET/MtwZ7p2zHooBOyBc/InwPEct 5PT1/k10fDRkf0MA9jPFvOova81OzuBO+XTjDX7gjK+NfTu/Z4xz3kNSmaFMvvdrUT4OfgnjK S4gIs0a0L6USqXg+5m4OWohaAb8hzku+uzMH+BDJjn8lQCMQHHcNeKd0UknPzH5daDVF+0UXv V2poPZAEAPefBtFYrI66ZsXSEQmwjeJ8iOIKWIzsN2/1bm6jYcPi2BiOTy/rA+IP8CnY74Py7 j23F7za7rT1yib05hgffcBALVatsaFlVdffMSP485R24fZYXRnQXNx/rmyfkA/YvCdnFuyphL WbBRZvnKtxuUzAaFb3pIQ5BPil9tFj1K3W/BF8cHjabI88nDhTEXtlRgskyb2eqkm5ZjQzahf dMgFSslkmqpBKZrL9jQI6/90l6yRaDQHBJI7laEubkfNQy7ZXkX32TAD00oJDdMdtpDdTp8Sg b+EKiwFDK6pBteNmu6AVKN8evNioXeWy1UMp4rivhd6iywtdTG2cayVWtxJi0BQ4H08SYBbP9 njSM44I9XJZ5Drm4d2PcYW+KHRGCB3VL/ub8buaggfGuly/nhhc7GZPca2k2IIyLrVxf1oJS X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:159190 Archived-At: Hi Thomas, thanks for the patch(es)! Am 08.05.2019 um 23:40 (-0400) schrieb Thomas Fitzsimmons: > The attached patch, icalendar-diary-make-entry-fix-1.patch, adds > omit-trailing-space and do-not-show parameters to diary-make-entry to > allow it to operate more like a library function and less like an > interactive function. This patch (icalendar-diary-make-entry-fix-1.patch) looks good to me, particulary from icalendar's point of view. Unit tests are not affected. > To keep the code mostly the same (so that I don't need to factor out > another function), I've changed the original logic by adding a > with-current-buffer wrapper, as shown in simplified form in > diary-make-entry-with-current-buffer.patch. I'm hoping this keeps the > default diary-make-entry logic exactly the same, but I'd like > confirmation from someone more familiar with the subtleties of window > and buffer manipulation. The other patch file (diary-make-entry-with-current-buffer.patch) need not be applied. Maybe someone could confirm that the diary and the window/buffer things are ok. I could then apply the patch.