From: Michael Albinus <michael.albinus@gmx.de>
To: "Mattias Engdegård" <mattiase@acm.org>
Cc: 36159@debbugs.gnu.org
Subject: bug#36159: [PATCH] auto-revert mode doesn't work when changing buffer file name
Date: Sat, 15 Jun 2019 11:56:25 +0200 [thread overview]
Message-ID: <87muij41fa.fsf@gmx.de> (raw)
In-Reply-To: <36A5F0D3-C244-4B22-B7C7-A40DF1166D2D@acm.org> ("Mattias \=\?utf-8\?Q\?Engdeg\=C3\=A5rd\=22's\?\= message of "Sat, 15 Jun 2019 11:26:06 +0200")
Mattias Engdegård <mattiase@acm.org> writes:
Hi Mattias,
> I'm so sorry for having put you through all this, and I wish there
> were anything I could do to make the tests more robust. Does
> autorevert 'feel' reliable and responsive for remote files when you
> use it manually, or is there anything that could cast the
> implementation in doubt?
Don't worry, that's what tests are good for :-)
The basic autorevert part seems to be OK even for remote files. The
trouble comes when file deletion happens;
auto-revert-test02-auto-revert-deleted-file-remote,
auto-revert-test05-global-notify-remote and
auto-revert-test06-write-file-remote become flaky. That is, sometimes
they pass, and sometimes not. I suppose problems in tramp-sh.el, but I
couldn't nail it down yet.
Likely, the combination of file deletion and autorevert hasn't been
tested thoroughly yet for remote files. OTOH, filenotify tests pass all,
also for remote files.
>> For the time being I've marked remote autorevert tests as unstable, so
>> they won't fail in Emacs CI tests. I hope to fix them in the future.
>
> Thank you once again; I suppose that will have to do for now.
Yes. I believe I give myself a timeout for this, some days. After hours
of unsuccessful debugging, I need a restart in mind for that problem.
Best regards, Michael.
prev parent reply other threads:[~2019-06-15 9:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-10 16:57 bug#36159: [PATCH] auto-revert mode doesn't work when changing buffer file name Mattias Engdegård
2019-06-11 13:15 ` Michael Albinus
2019-06-11 16:55 ` Mattias Engdegård
2019-06-11 18:02 ` Michael Albinus
2019-06-11 20:17 ` Mattias Engdegård
2019-06-15 9:16 ` Michael Albinus
2019-06-15 9:26 ` Mattias Engdegård
2019-06-15 9:56 ` Michael Albinus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87muij41fa.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=36159@debbugs.gnu.org \
--cc=mattiase@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).