From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#24978: 25.1; Bad interaction between nxml-auto-insert-xml-declaration-flag and archive-extract Date: Sat, 27 Jul 2019 14:02:48 +0200 Message-ID: <87mugzit1z.fsf@mouse.gnus.org> References: <790b5bcd-716f-b4b2-31e8-2fe0c512405c@h-rommerskirchen.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="196922"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 24978@debbugs.gnu.org To: Heinz Rommerskirchen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jul 27 14:03:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hrLPo-000p4m-5m for geb-bug-gnu-emacs@m.gmane.org; Sat, 27 Jul 2019 14:03:08 +0200 Original-Received: from localhost ([::1]:45526 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hrLPn-0001EC-4k for geb-bug-gnu-emacs@m.gmane.org; Sat, 27 Jul 2019 08:03:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42513) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hrLPj-0001Dc-Bd for bug-gnu-emacs@gnu.org; Sat, 27 Jul 2019 08:03:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hrLPi-0007qR-8p for bug-gnu-emacs@gnu.org; Sat, 27 Jul 2019 08:03:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34974) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hrLPi-0007qI-3J for bug-gnu-emacs@gnu.org; Sat, 27 Jul 2019 08:03:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hrLPh-0002Xt-TD for bug-gnu-emacs@gnu.org; Sat, 27 Jul 2019 08:03:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 27 Jul 2019 12:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24978 X-GNU-PR-Package: emacs Original-Received: via spool by 24978-submit@debbugs.gnu.org id=B24978.15642289759759 (code B ref 24978); Sat, 27 Jul 2019 12:03:01 +0000 Original-Received: (at 24978) by debbugs.gnu.org; 27 Jul 2019 12:02:55 +0000 Original-Received: from localhost ([127.0.0.1]:43792 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hrLPa-0002XL-Sr for submit@debbugs.gnu.org; Sat, 27 Jul 2019 08:02:55 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:37094) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hrLPZ-0002XB-2C for 24978@debbugs.gnu.org; Sat, 27 Jul 2019 08:02:53 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hrLPV-0007be-6v; Sat, 27 Jul 2019 14:02:51 +0200 In-Reply-To: <790b5bcd-716f-b4b2-31e8-2fe0c512405c@h-rommerskirchen.de> (Heinz Rommerskirchen's message of "Mon, 21 Nov 2016 14:41:24 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:163852 Archived-At: Heinz Rommerskirchen writes: > If the variable nxml-auto-insert-xml-declaration-flag is set, an XML > declaration is inserted into non-empty XML files inside a zip archive. > > To reproduce this bug create the valid XML file foo.xml containing > === start foo.xml === > > y > === end foo.xml === > and pack it into a zip-archive: > $ zip -m bar.zip foo.xml > Now start "emacs -Q", evaluate > "(setq nxml-auto-insert-xml-declaration-flag 't)" in the *scratch* > buffer, visit bar.zip with C-x C-f, and press Enter on the entry > "foo.xml". foo.xml will be opened and an additional XML declaration is > inserted into the buffer rendering the file invalid and marking the > buffer as modified. (I'm going through older Emacs bug reports that have received no response.) I was able to reproduce the bug in Emacs 27, too. > The following simple patch solved the problem for me. [...] > - (when (not (and (buffer-file-name) (file-exists-p (buffer-file-name)))) > + (when (and (not (and (buffer-file-name) (file-exists-p (buffer-file-name)))) > + (not archive-superior-buffer)) Thanks for the patch, but I think the problem is a bit more general. The intention seems to be to insert the declaration whenever you're starting a new file, so I think a more general solution is to just check whether the buffer is empty before inserting the declaration. I've now done this change on the Emacs trunk. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no