From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#23488: 25.0.93; Modules: inconsistent return types for error reporting Date: Sun, 28 Jul 2019 14:45:08 +0200 Message-ID: <87mugyba5n.fsf@mouse.gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="59213"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 23488@debbugs.gnu.org To: Philipp Stephani Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jul 28 14:46:14 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hriZ1-000FD5-4j for geb-bug-gnu-emacs@m.gmane.org; Sun, 28 Jul 2019 14:46:11 +0200 Original-Received: from localhost ([::1]:45130 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hriYz-0008Ar-Ea for geb-bug-gnu-emacs@m.gmane.org; Sun, 28 Jul 2019 08:46:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53931) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hriYu-0008AX-82 for bug-gnu-emacs@gnu.org; Sun, 28 Jul 2019 08:46:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hriYt-0002mN-7F for bug-gnu-emacs@gnu.org; Sun, 28 Jul 2019 08:46:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37086) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hriYt-0002lx-3w for bug-gnu-emacs@gnu.org; Sun, 28 Jul 2019 08:46:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hriYs-0004De-3l for bug-gnu-emacs@gnu.org; Sun, 28 Jul 2019 08:46:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 28 Jul 2019 12:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23488 X-GNU-PR-Package: emacs Original-Received: via spool by 23488-submit@debbugs.gnu.org id=B23488.156431791413083 (code B ref 23488); Sun, 28 Jul 2019 12:46:02 +0000 Original-Received: (at 23488) by debbugs.gnu.org; 28 Jul 2019 12:45:14 +0000 Original-Received: from localhost ([127.0.0.1]:45907 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hriY6-0003Oa-7G for submit@debbugs.gnu.org; Sun, 28 Jul 2019 08:45:14 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:55408) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hriY5-0003N5-5I for 23488@debbugs.gnu.org; Sun, 28 Jul 2019 08:45:13 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hriY0-00042d-QO; Sun, 28 Jul 2019 14:45:11 +0200 In-Reply-To: (Philipp Stephani's message of "Mon, 09 May 2016 18:49:04 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:163952 Archived-At: Philipp Stephani writes: > Of the module environment functions, 'copy_string_contents' is > inconsistent with all the other functions in that it returns a boolean > to indicate success/failure. All other functions only set the last > error status, to be checked with non_local_exit_check etc. This should > be made consistent, e.g. my having copy_string_contents return void. Is that possible to do at this late date? It's part of the advertised API, I think, and changing it sounds like it'd break modules. > Furthermore, the comment for copy_string_contents is incorrect. If > BUFFER is NULL, it returns true, not false. I see you've fixed this later... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no