From: Lars Ingebrigtsen <larsi@gnus.org>
To: martin rudalics <rudalics@gmx.at>
Cc: Christoph Scholtes <cschol2112@googlemail.com>, 9867@debbugs.gnu.org
Subject: bug#9867: 24.0.90; quit-window should provide quit-window-hook
Date: Wed, 21 Aug 2019 13:18:59 -0700 [thread overview]
Message-ID: <87mug2xoek.fsf@mouse.gnus.org> (raw)
In-Reply-To: <761cfbbf-88ef-d161-fb7b-a906c12e5307@gmx.at> (martin rudalics's message of "Tue, 20 Aug 2019 10:19:29 +0200")
martin rudalics <rudalics@gmx.at> writes:
> If people really need such a hook at all, please
>
> - Make it either an abnormal hook run with the window quit as argument
> or run it from 'quit-window' but then only if it quits the selected
> window.
I was going back and forth on whether to call the hook from
`quit-window' or `quit-restore-window', so I ended up with invalid vode
in the latter. Thinking about it a bit more, I think it makes more
sense to just run it from the former command -- other callers that call
`quit-restore-window' should perhaps call that hook manually (or not) at
all.
I'll move the hook over.
> - Fix the reference to the non-existent function 'quit-buffer'.
OK; done.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2019-08-21 20:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-25 4:04 bug#9867: 24.0.90; quit-window should provide quit-window-hook Christoph Scholtes
2019-08-20 2:22 ` Lars Ingebrigtsen
2019-08-20 8:19 ` martin rudalics
2019-08-20 14:25 ` Eli Zaretskii
2019-08-21 20:23 ` Lars Ingebrigtsen
2019-08-21 20:18 ` Lars Ingebrigtsen [this message]
2019-08-22 8:08 ` martin rudalics
2019-08-23 0:08 ` Lars Ingebrigtsen
2019-08-23 7:46 ` martin rudalics
2019-08-23 8:05 ` Lars Ingebrigtsen
2019-08-23 8:42 ` martin rudalics
2019-08-25 5:24 ` Lars Ingebrigtsen
2019-08-25 8:11 ` martin rudalics
2019-08-30 9:40 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mug2xoek.fsf@mouse.gnus.org \
--to=larsi@gnus.org \
--cc=9867@debbugs.gnu.org \
--cc=cschol2112@googlemail.com \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).