From: Lars Ingebrigtsen <larsi@gnus.org>
To: Wolfgang Scherer <Wolfgang.Scherer@gmx.de>
Cc: 37216@debbugs.gnu.org
Subject: bug#37216: [PATCH] vc-svn-ignore sets incorrect properties for relative filenames
Date: Sun, 15 Sep 2019 15:07:46 +0200 [thread overview]
Message-ID: <87muf5wvvh.fsf@gnus.org> (raw)
In-Reply-To: <3df2dec6-18c5-ff65-cfa0-408bc5212b4e@gmx.de> (Wolfgang Scherer's message of "Thu, 29 Aug 2019 01:39:48 +0200")
Wolfgang Scherer <Wolfgang.Scherer@gmx.de> writes:
> If a relative filename has at least one level of parent
> directories, `vc-svn-ignore' fails to add the ignore spec to the
> correct subdirectory.
>
> The attached patch fixes that error.
[...]
> +FILE is a wildcard specification, either relative to
> +DIRECTORY or absolute."
> + (let* ((path (directory-file-name (expand-file-name file directory)))
> + (directory (file-name-directory path))
> + (file (file-name-nondirectory path))
> + (ignores (vc-svn-ignore-completion-table directory))
> (ignores (if remove
> (delete file ignores)
> (push file ignores))))
> (vc-svn-command nil 0 nil nil "propset" "svn:ignore"
> (mapconcat #'identity ignores "\n")
> - (expand-file-name directory))))
> + directory)))
I don't have any svn trees to test with, but if I understand the code
here, then this seems correct.
Does anybody else have an opinion?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2019-09-15 13:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-28 23:39 bug#37216: [PATCH] vc-svn-ignore sets incorrect properties for relative filenames Wolfgang Scherer
2019-09-15 13:07 ` Lars Ingebrigtsen [this message]
2019-10-07 4:59 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87muf5wvvh.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=37216@debbugs.gnu.org \
--cc=Wolfgang.Scherer@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).