From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#37395: [PATCH v4] diff-mode.el: take into account patch separators Date: Wed, 09 Oct 2019 21:36:57 +0200 Message-ID: <87mue9678m.fsf@gnus.org> References: <1568323985.28657.0@yandex.ru> <20191008193420.193239-1-Hi-Angel@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="104633"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 37395@debbugs.gnu.org To: Konstantin Kharlamov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 09 22:43:17 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iIInl-000R6H-0b for geb-bug-gnu-emacs@m.gmane.org; Wed, 09 Oct 2019 22:43:17 +0200 Original-Received: from localhost ([::1]:57514 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIInj-0002r8-PU for geb-bug-gnu-emacs@m.gmane.org; Wed, 09 Oct 2019 16:43:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55864) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIHmd-0006y7-VC for bug-gnu-emacs@gnu.org; Wed, 09 Oct 2019 15:38:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iIHmc-0007nW-N5 for bug-gnu-emacs@gnu.org; Wed, 09 Oct 2019 15:38:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45332) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iIHmb-0007n2-W1 for bug-gnu-emacs@gnu.org; Wed, 09 Oct 2019 15:38:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iIHmb-0008Tb-Qb for bug-gnu-emacs@gnu.org; Wed, 09 Oct 2019 15:38:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 09 Oct 2019 19:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37395 X-GNU-PR-Package: emacs Original-Received: via spool by 37395-submit@debbugs.gnu.org id=B37395.157064982832513 (code B ref 37395); Wed, 09 Oct 2019 19:38:01 +0000 Original-Received: (at 37395) by debbugs.gnu.org; 9 Oct 2019 19:37:08 +0000 Original-Received: from localhost ([127.0.0.1]:54153 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iIHli-0008SJ-C2 for submit@debbugs.gnu.org; Wed, 09 Oct 2019 15:37:08 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:42448) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iIHld-0008Rl-Ei for 37395@debbugs.gnu.org; Wed, 09 Oct 2019 15:37:02 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iIHlZ-0003hY-OH; Wed, 09 Oct 2019 21:37:00 +0200 In-Reply-To: <20191008193420.193239-1-Hi-Angel@yandex.ru> (Konstantin Kharlamov's message of "Tue, 8 Oct 2019 22:34:20 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:168779 Archived-At: Konstantin Kharlamov writes: > * lisp/vc/diff-mode.el (diff-prev-line-if-patch-separator): > A function to return prev. line if it has git-format-patch > separator. > (diff-end-of-hunk): Make use of > diff-prev-line-if-patch-separator > diff-buffer-type: whether a buffer is a git-diff > (define-derived-mode): set diff-buffer-type to appropriate > value Byte-compiling gives: In diff-prev-line-if-patch-separator: vc/diff-mode.el:516:10:Warning: reference to free variable `diff-buffer-type' vc/diff-mode.el:517:7:Warning: `previous-line' is for interactive use only; use `forward-line' with negative argument instead. So you have to move the defvar earlier and adjust the previous-line, but otherwise I think it looks OK... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no