From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#37774: 27.0.50; new :extend attribute broke visuals of all themes and other packages Date: Wed, 16 Oct 2019 23:23:14 +0300 Organization: LINKOV.NET Message-ID: <87mue01lu5.fsf@mail.linkov.net> References: <83bluhf7nz.fsf@gnu.org> <20191016111004.oialbyleokafpccz@Ergus> <87k194fvn7.fsf@mail.linkov.net> <83y2xkcyu9.fsf@gnu.org> <87o8yg5v80.fsf@mail.linkov.net> <83o8ygcvb0.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="76476"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: andreyorst@gmail.com, spacibba@aol.com, 37774@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 16 22:24:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iKpq6-000JjD-Iv for geb-bug-gnu-emacs@m.gmane.org; Wed, 16 Oct 2019 22:24:10 +0200 Original-Received: from localhost ([::1]:47942 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKpq5-00017v-Er for geb-bug-gnu-emacs@m.gmane.org; Wed, 16 Oct 2019 16:24:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40454) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKppz-00017c-Aw for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2019 16:24:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iKppy-0000f4-7S for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2019 16:24:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37818) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iKppy-0000ex-4B for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2019 16:24:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iKppx-00028q-Te for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2019 16:24:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 16 Oct 2019 20:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37774 X-GNU-PR-Package: emacs Original-Received: via spool by 37774-submit@debbugs.gnu.org id=B37774.15712574358218 (code B ref 37774); Wed, 16 Oct 2019 20:24:01 +0000 Original-Received: (at 37774) by debbugs.gnu.org; 16 Oct 2019 20:23:55 +0000 Original-Received: from localhost ([127.0.0.1]:46639 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKppq-00028U-Js for submit@debbugs.gnu.org; Wed, 16 Oct 2019 16:23:54 -0400 Original-Received: from bonobo.elm.relay.mailchannels.net ([23.83.212.22]:24446) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKppo-00028L-KC for 37774@debbugs.gnu.org; Wed, 16 Oct 2019 16:23:53 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 405DB8C21D5; Wed, 16 Oct 2019 20:23:51 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a85.g.dreamhost.com (100-96-87-223.trex.outbound.svc.cluster.local [100.96.87.223]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id C2A228C03CE; Wed, 16 Oct 2019 20:23:50 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from pdx1-sub0-mail-a85.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.5); Wed, 16 Oct 2019 20:23:51 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Decisive-Spicy: 088d20526df3f091_1571257431044_4108667815 X-MC-Loop-Signature: 1571257431044:3316950542 X-MC-Ingress-Time: 1571257431044 Original-Received: from pdx1-sub0-mail-a85.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a85.g.dreamhost.com (Postfix) with ESMTP id 045BE872DF; Wed, 16 Oct 2019 13:23:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=mvVNfInPU4PUxt84cme+8aPIH8Y=; b= wb+fT0cV7e1bkGSZvIGJkTRhXwyY6ePBn7Luvg8AbAr9YWaupFHP0bC1lVgy1LrK KvMW9KTcm+cj6ZBey6ZF+TKYJ0noVm/y6AnTZchymXLURrBQehVacDDuYre0ZuvX XQTLEdBlvasaTDcoPp4CAVJOef+Amv9w+NjolWXLr3E= Original-Received: from mail.jurta.org (m91-129-98-153.cust.tele2.ee [91.129.98.153]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a85.g.dreamhost.com (Postfix) with ESMTPSA id ABCDA872E2; Wed, 16 Oct 2019 13:23:43 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a85 In-Reply-To: <83o8ygcvb0.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 16 Oct 2019 23:03:15 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:169495 Archived-At: >> > I'm not sure I understand: the region face is defined to be extended >> > beyond EOL. How does custom-set-faces enter this picture, and why did >> > you need to do anything about the customized faces? >> >> The region face customized long ago in the init file >> has no ':extend t' face attribute, e.g. >> >> (custom-set-faces >> '(region ((((class color) (background light)) (:background "gray90")))) > > So maybe we should modify custom-set-faces to preserve the :extend > attribute? Would that solve the problem? I don't know how feasible this is. This looks like a hack. >> All diff faces and faces that have a distinct background color >> like 'comint-highlight-input' (should extend to window edge >> to help locating visually the command line in shell buffers), >> 'org-block' (because it highlights code blocks), 'xref-file-header' >> for the same reason as diff faces, i.e. faces that highlights blocks. > > I don't think I agree. I'm not convinced by the reasons, and I find > the new appearance not worse (and sometimes better) than the old. I find the new appearance better too in most cases, but not for background colors. >> Because there is no distinctive rectangular header anymore, >> and no diff hunk blocks. > > Sorry, I don't think I follow: how do you mean there's no distinctive > header and no diff hunk blocks? I see them quite clearly. I meant a rectangular header like in other applications. >> Extending to the fill-column could be an optional feature. > > But above you mention it as the default. If it's an option, then it > cannot be a solution to the problems we are discussing. Extending to fill-column could be optional. Extending to window edge could be default for faces with distinct background colors. Extending to EOL could be default for all other faces.