From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#21922: Fwd: bug#21922: Fwd: Patch for fixing "straigh-quote" case Date: Tue, 22 Oct 2019 20:55:55 -0400 Message-ID: <87mudscmas.fsf@gmail.com> References: <871rv4e3gk.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="213049"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) Cc: 21922@debbugs.gnu.org To: Luis Henriquez-Perez Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 23 02:57:17 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iN4xh-000tJS-6R for geb-bug-gnu-emacs@m.gmane.org; Wed, 23 Oct 2019 02:57:17 +0200 Original-Received: from localhost ([::1]:50052 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iN4xg-0007oa-2U for geb-bug-gnu-emacs@m.gmane.org; Tue, 22 Oct 2019 20:57:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39757) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iN4xT-0007oS-JA for bug-gnu-emacs@gnu.org; Tue, 22 Oct 2019 20:57:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iN4xS-0008KU-BA for bug-gnu-emacs@gnu.org; Tue, 22 Oct 2019 20:57:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51854) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iN4xS-0008KL-55 for bug-gnu-emacs@gnu.org; Tue, 22 Oct 2019 20:57:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iN4xS-0000uJ-0Q for bug-gnu-emacs@gnu.org; Tue, 22 Oct 2019 20:57:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Oct 2019 00:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21922 X-GNU-PR-Package: emacs Original-Received: via spool by 21922-submit@debbugs.gnu.org id=B21922.15717921663422 (code B ref 21922); Wed, 23 Oct 2019 00:57:01 +0000 Original-Received: (at 21922) by debbugs.gnu.org; 23 Oct 2019 00:56:06 +0000 Original-Received: from localhost ([127.0.0.1]:60675 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iN4wX-0000t7-MI for submit@debbugs.gnu.org; Tue, 22 Oct 2019 20:56:05 -0400 Original-Received: from mail-qk1-f174.google.com ([209.85.222.174]:43869) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iN4wU-0000sb-Mo for 21922@debbugs.gnu.org; Tue, 22 Oct 2019 20:56:03 -0400 Original-Received: by mail-qk1-f174.google.com with SMTP id a194so14156179qkg.10 for <21922@debbugs.gnu.org>; Tue, 22 Oct 2019 17:56:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=dLOU0uqc1sV3UIypLIykItGJjQmvcY1JV2BYNdXw2VQ=; b=cg/v2dbf4KOHiN7OXKWV0UYnilv99umnWYbgW/iQYepBC6/2vYMKrylGU9etVwJjlB eFeLAzHoZKGnCPay1qgsbmqPLH569h7iyW5o4E/lAJmpajYp+XA6sv+244MLg1N7FQiJ Xq1+tUJmSmQBvSHgRizqqn+Dl23x8G38SCB3rVySZscqD50azxmbsmxHK/CpYRqwjIrJ q9hk5RvCaNUCnLx+IFaCcqIMT2PTGyNGN5kORRWvIUwguMbHDwlnVTyGhOhvE+CqNyXY +fRwOMOPGtJKrSb5aQIz1rBPY4QPzpRyWx+S7yPq66sUADp68ouVbbeR1uOZr5x8jVlb eyGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=dLOU0uqc1sV3UIypLIykItGJjQmvcY1JV2BYNdXw2VQ=; b=YLpUgfh1Wu1zZm86WWCz6HfUqMpzFlFt8pQLW55SGdzG0NdUAzjBl85hSDEPMUutTJ gAllAW8lMwq0PrZy8lfGvt21z0dvZ+C9UjEVBxnIvSrknYxbI1sN0/khvjZf+ZuK9mlF 2k0uUi9yfLpoM0aG4p8oNiyXZAuf9Xzsx73qZ7lfFiTFy1QcFHaTPMu6C9Zq/408WNKn OCdewVx3VooLKE4CknFyB7Kmo5AA5Kc+xM+VuNvi+wy7AxeRG/rZHtdl7DoVPk4u/vYv IW2pyO6Zl4dtXpDuGyHbtFUI1qXb4eWlCUz8+89yi1jeBiAEsYXAcPYWTI4acCG+JXB3 xNQQ== X-Gm-Message-State: APjAAAXXDI1bsU2Ny88lLADBYpH3RLP5SgkK/tFCfRjoy52vbM0dUOYm +cQ8hdPZAqrFsxuMpu8Laf3VwDJh X-Google-Smtp-Source: APXvYqz+LBGCTtqQ+14YpTy4+xgtUKYiOxOgbc3QPllDnYt7miU+If8c4U4a9bZ4LYEuR80mxIaI1g== X-Received: by 2002:a37:7686:: with SMTP id r128mr5755850qkc.444.1571792156920; Tue, 22 Oct 2019 17:55:56 -0700 (PDT) Original-Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id f14sm787668qkl.63.2019.10.22.17.55.56 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 22 Oct 2019 17:55:56 -0700 (PDT) In-Reply-To: (Luis Henriquez-Perez's message of "Tue, 22 Oct 2019 20:42:38 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:170023 Archived-At: Luis Henriquez-Perez writes: >>> I meant to say (looking-at-p "[[:space:]\n]*quote\\_>") > > I changed "[[:space:]\n]" -> "[[:space:]]\n" because I think that's what > you meant. No, this time I actually managed to write what I meant :) "[[:space:]\n]*" will match any number of whitespace-syntax or newline characters, whereas "[[:space:]]\n*" will match exactly one whitespace-syntax character, followed by any number of newlines. > I'm new to contributing patches. Is there anything else I need to do > to get this into emacs? It would be more convenient to have your change as a patch, rather than just the resulting code. If you have the Emacs git repo, committing locally and attaching the result of 'git format-patch' as described in CONTRIBUTE would be the best way. Otherwise, even just the output of diff -u lisp/emacs-lisp/lisp-mode.el.original lisp/emacs-lisp/lisp-mode.el would be helpful. Oh, and adding a test to test/lisp/emacs-lisp/lisp-mode-tests.el would be good as well (e.g., to catch mistakes like using "[[:space:]]\n*" instead of "[[:space:]\n]*").