From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#33937: 26.1; mhtml-mode fails to capture font-lock-keywords-case-fold-search Date: Wed, 30 Oct 2019 20:26:44 +0100 Message-ID: <87mudiowzv.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="69955"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 33937@debbugs.gnu.org, Stefan Monnier To: Leo Liu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 30 20:27:35 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iPtd1-000I5o-FM for geb-bug-gnu-emacs@m.gmane.org; Wed, 30 Oct 2019 20:27:35 +0100 Original-Received: from localhost ([::1]:43646 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iPtcy-0005xS-N1 for geb-bug-gnu-emacs@m.gmane.org; Wed, 30 Oct 2019 15:27:32 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38532) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iPtcW-0005n1-GZ for bug-gnu-emacs@gnu.org; Wed, 30 Oct 2019 15:27:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iPtcU-0006MO-7A for bug-gnu-emacs@gnu.org; Wed, 30 Oct 2019 15:27:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42679) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iPtcU-0006M8-3m for bug-gnu-emacs@gnu.org; Wed, 30 Oct 2019 15:27:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iPtcT-0005M2-U6 for bug-gnu-emacs@gnu.org; Wed, 30 Oct 2019 15:27:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Oct 2019 19:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33937 X-GNU-PR-Package: emacs Original-Received: via spool by 33937-submit@debbugs.gnu.org id=B33937.157246361220561 (code B ref 33937); Wed, 30 Oct 2019 19:27:01 +0000 Original-Received: (at 33937) by debbugs.gnu.org; 30 Oct 2019 19:26:52 +0000 Original-Received: from localhost ([127.0.0.1]:51500 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iPtcJ-0005LZ-Pm for submit@debbugs.gnu.org; Wed, 30 Oct 2019 15:26:51 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:33322) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iPtcI-0005LQ-1I for 33937@debbugs.gnu.org; Wed, 30 Oct 2019 15:26:50 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iPtcC-0002Za-NN; Wed, 30 Oct 2019 20:26:47 +0100 In-Reply-To: (Leo Liu's message of "Mon, 31 Dec 2018 23:13:39 +0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:170439 Archived-At: Leo Liu writes: > In mhtml-mode moving into doesn't set up > font-lock-keywords-case-fold-search properly, which still has the value > carried over from html-mode. > > The reason is font-lock doesn't make font-lock-keywords-case-fold-search > buffer-local when its value is nil thus it is skipped by > mhtml--construct-submode. This is due to commit 558ca3c1225f6035442733d5d3fb5fd4c40a0a45 Author: Stefan Monnier Date: Tue Feb 12 16:49:21 2008 +0000 (font-lock-set-defaults): Unset previously set variables when needed. which does this with many of the font-lock variables: ;; Case fold during regexp fontification? - (when (nth 2 defaults) - (set (make-local-variable 'font-lock-keywords-case-fold-search) t)) + (if (nth 2 defaults) + (set (make-local-variable 'font-lock-keywords-case-fold-search) t) + (kill-local-variable 'font-lock-keywords-case-fold-search)) It's slightly puzzling -- font-lock-keywords-case-fold-search is permanently buffer-local, but I guess that puzzlement was there before this patch, but the kill-local-variable thing is what makes mhtlm not work. Stefan, do you remember the reason for this change? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no