From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#38011: 27.0.50; [PATCH] WIP on allowing Gnus backends to return header data directly Date: Thu, 30 Apr 2020 06:50:34 +0200 Message-ID: <87mu6t37c5.fsf@gnus.org> References: <87y2x0a9bl.fsf@ericabrahamsen.net> <87a79f3cu3.fsf@gnus.org> <8736f7l9rd.fsf@ericabrahamsen.net> <87eeyqfi4u.fsf@gnus.org> <87mud75l3i.fsf@ericabrahamsen.net> <87k18a3wtc.fsf@gnus.org> <871ruiqc19.fsf@ericabrahamsen.net> <87imnu2foy.fsf@gnus.org> <87tv27rlcz.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="48267"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 38011@debbugs.gnu.org To: Eric Abrahamsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Apr 30 06:52:30 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jU1BW-000CPP-C5 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 30 Apr 2020 06:52:30 +0200 Original-Received: from localhost ([::1]:42828 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jU1BV-0003p3-2d for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 30 Apr 2020 00:52:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50802) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jU1B5-0003or-I6 for bug-gnu-emacs@gnu.org; Thu, 30 Apr 2020 00:52:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jU1B4-0003ZT-PB for bug-gnu-emacs@gnu.org; Thu, 30 Apr 2020 00:52:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33634) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jU1B4-0003ZJ-DU for bug-gnu-emacs@gnu.org; Thu, 30 Apr 2020 00:52:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jU1B4-0003uI-7G for bug-gnu-emacs@gnu.org; Thu, 30 Apr 2020 00:52:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 30 Apr 2020 04:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38011 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 38011-submit@debbugs.gnu.org id=B38011.158822226314949 (code B ref 38011); Thu, 30 Apr 2020 04:52:02 +0000 Original-Received: (at 38011) by debbugs.gnu.org; 30 Apr 2020 04:51:03 +0000 Original-Received: from localhost ([127.0.0.1]:45180 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jU1A0-0003sa-4s for submit@debbugs.gnu.org; Thu, 30 Apr 2020 00:51:03 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:51306) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jU19x-0003sN-Qw for 38011@debbugs.gnu.org; Thu, 30 Apr 2020 00:50:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=+9Xr8sq+XLcxzhAfmtTbaOL375WeT1SytJQp1R78rkQ=; b=P/JpCoC3lLaZWgOXol64VsN4IB GJVXMeKI7MQFel1Y0hS31lhXmIswpxyd3cCshtMDBAivwMODFBVHBgWRk7oo8btdsYEpoGwVj8Tiw V2JSavatVFrQzh4rLuxvMf+sDCSS75bN+PdPQYfvsUNiI5nOpP/qhrx1Ik14z45eBbvI=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jU19f-0005Do-AG; Thu, 30 Apr 2020 06:50:47 +0200 In-Reply-To: <87tv27rlcz.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Sun, 29 Mar 2020 12:50:52 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:179372 Archived-At: Eric Abrahamsen writes: > Can someone explain what exactly this function is supposed to do? Somebody should have written more comments when they wrote that... and, like, made it correct. It transforms this: 64007 Formatting labels used for URL buttons in Gnus articles Narendra Joshi Sun, 19 Apr 2020 00:31:13 +0200 <87eesk2zpq.fsf@gmail.com> 3614 14 Xref: reader01.eternal-september.org gnu.emacs.help:57603 Into this: 64007 Formatting labels used for URL buttons in Gnus articles Narendra Joshi Sun, 19 Apr 2020 00:31:13 +0200 <87eesk2zpq.fsf@gmail.com> 3614 14 Xref: marnie gnu.emacs.help:57603 01.eternal-september.org Which is wrong, of course -- the "01.eternal-september.org" thing shouldn't be there. Anyway, what it's supposed to do it rewrite Xref: reader01.eternal-september.org foo.bar:2523 gnu.emacs.help:57603 zot.bar:3242 to Xref: whatever gnu.emacs.help:57603 foo.bar:2523 zot.bar:3242 That is, put the group/article we're really selecting first in the Xref header, but leave the remaining as they were. This is because we need those to mark the article as read in those other groups, but we primarily need to know where this article really came from (the first entry). Feel free to adapt this to comments in the code. :-) And rewrite to be correct. I don't understand why it's doing all the regexp stuff (wrongly) in the first place -- it should just split the data into a list and then do its work... Perhaps it was marginally faster to do it this way? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no