From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el Date: Tue, 16 Jun 2020 11:26:04 +0100 Message-ID: <87mu53i9xf.fsf@tcd.ie> References: <87bllk2pfc.fsf@thornhill.no> <87sgew7zni.fsf@thornhill.no> <1a426f88-dd6e-77f7-bcbf-30ced285537d@yandex.ru> <87o8pj8sy2.fsf@thornhill.no> <87d05zr13x.fsf@warpmail.net> <87lfkn8q0a.fsf@thornhill.no> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="104414"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 41879@debbugs.gnu.org, "Philip K." , Dmitry Gutov To: Theodor Thornhill Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jun 16 12:27:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jl8oC-000R2j-CX for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 16 Jun 2020 12:27:12 +0200 Original-Received: from localhost ([::1]:35004 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jl8oB-0008Nq-AC for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 16 Jun 2020 06:27:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57814) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jl8o2-0008MF-Oz for bug-gnu-emacs@gnu.org; Tue, 16 Jun 2020 06:27:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36807) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jl8o2-00012E-GE for bug-gnu-emacs@gnu.org; Tue, 16 Jun 2020 06:27:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jl8o2-0002Xx-CS for bug-gnu-emacs@gnu.org; Tue, 16 Jun 2020 06:27:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 16 Jun 2020 10:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41879 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 41879-submit@debbugs.gnu.org id=B41879.15923031759733 (code B ref 41879); Tue, 16 Jun 2020 10:27:02 +0000 Original-Received: (at 41879) by debbugs.gnu.org; 16 Jun 2020 10:26:15 +0000 Original-Received: from localhost ([127.0.0.1]:48353 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jl8nH-0002Wv-H0 for submit@debbugs.gnu.org; Tue, 16 Jun 2020 06:26:15 -0400 Original-Received: from mail-wm1-f52.google.com ([209.85.128.52]:39732) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jl8nE-0002Wh-Qd for 41879@debbugs.gnu.org; Tue, 16 Jun 2020 06:26:13 -0400 Original-Received: by mail-wm1-f52.google.com with SMTP id t194so2493138wmt.4 for <41879@debbugs.gnu.org>; Tue, 16 Jun 2020 03:26:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=uEmO+kgCoi5xZXnMy2WSWelhhAFDZjpVEPETDh/ixek=; b=MYopT6ol+S0qiMGVoKWK6j2vxvF4cvqgj77yEZCdYKVFqEn7L9z15PGmIj7vZhtjaO W2PoRTC2w25c0cNWz5J7wvf4WxCq8+s61m/KXDS3QUpFBkJYUYTBQCmaSYgZIhM6aqVi sUoHkaUCBWQVTp8c35aI/ru4i5uFRx/uu7HGdaO1BcmENhdsAyK5Rh55JnhooJ3JhE69 QHcVf5jrlk60KF9fi9lAFYKclYoKWzuZVf0bLle0e/jQRYU+2f5MgzB1lB9V0wY9iIaS p5msmmCCxT/3euoo37X7VTCR/RfleSnwfVGMAdo1AxMGGLRykDwMBsojjxJdpwSmZy07 E+Bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=uEmO+kgCoi5xZXnMy2WSWelhhAFDZjpVEPETDh/ixek=; b=j7WzYaoIrHqhA9bTxG4GMmeMDksx3dvYXDEvJLpWweV2r53eKGHUsprGWQ56ZI4N/O 8KvQVKFmqk8rUMOeU/bSihsNEDDZDsDHYJpZXcqPMFBibUv9lzzm1G5o3Wyt2wit/KIa feAJ/JT8IyVqyK8az6ziL4UdGwDnSlqn87+ajlYvpMU52rJNn3/RRY7twr1tCPfbznev MCmhFoJBVXZlzNBPrr3Un3L2aJcbTwrO7LEDME7SSWbQHRzwq5T7joPiJ3AXlwrMPGWB QJFlT7qM8+a1mVp6tNgxxMzXNntJ9niWcMkpkHkfDYimW1F5y1k42vuWZEstOrObdVgd 7bWg== X-Gm-Message-State: AOAM530HY5J6SgwO7zZX1cb10iW/vdTAm2zr+HMBWp7Q98qf4IDAnKSU n/JnwF73/hkx1+uZWf7+QNDB3A== X-Google-Smtp-Source: ABdhPJwAFqeYo/+wAWLnHaApdxH19EiPsFYxXNSb2A2VQPZ0/UQT7MIdJuqc9xI7jWfW+6LQakz/Xg== X-Received: by 2002:a7b:c246:: with SMTP id b6mr2361883wmj.96.1592303166871; Tue, 16 Jun 2020 03:26:06 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:1f68:7ff5:120d:64e]) by smtp.gmail.com with ESMTPSA id 4sm23154287wrf.74.2020.06.16.03.26.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jun 2020 03:26:06 -0700 (PDT) In-Reply-To: <87lfkn8q0a.fsf@thornhill.no> (Theodor Thornhill's message of "Tue, 16 Jun 2020 06:49:01 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:182019 Archived-At: Theodor Thornhill writes: > diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el > index 218058b195..a61b29abe6 100644 > --- a/lisp/progmodes/project.el > +++ b/lisp/progmodes/project.el > @@ -753,6 +753,18 @@ project-compile > (default-directory (project-root pr))) > (compile command comint))) > > +;;;###autoload > +(defun project-switch-to-buffer () > + "Switch to a buffer in the current project." > + (interactive) > + (let ((root (project-root (project-current t)))) > + (switch-to-buffer > + (read-buffer > + "Switch-to-buffer: " nil t Nit: For consistency with switch-to-buffer, this should be "Switch to buffer: " without the hyphens. > + (lambda (buffer) > + (when-let ((file (buffer-file-name (cdr buffer)))) Nit: Neither the manual nor read-buffer's docstring documents what (cdr buffer) is here, so a comment mentioning Vbuffer_alist or something along those lines would be nice. > + (file-in-directory-p file root))))))) > + Otherwise LGTM, thanks, -- Basil