From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#44100: Patch Date: Sun, 01 Nov 2020 14:09:54 +0100 Message-ID: <87mu01cjfh.fsf__22645.4371631675$1604236352$gmane$org@gnus.org> References: <4578382.cRamKGfW39@ravel> <21986473.sr7ieKrsik@ravel> <87imaquq6z.fsf@gnu.org> <875z6pu8h5.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5879"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Corwin Brust , emacs-erc@gnu.org, 44100@debbugs.gnu.org, Olivier Certner To: Amin Bandali Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 01 14:12:27 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kZD9n-0001R1-Bv for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 01 Nov 2020 14:12:27 +0100 Original-Received: from localhost ([::1]:54064 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kZD9m-0002Z7-Bp for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 01 Nov 2020 08:12:26 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60028) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kZD8Q-000215-EZ for bug-gnu-emacs@gnu.org; Sun, 01 Nov 2020 08:11:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52620) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kZD8P-00030i-Rj for bug-gnu-emacs@gnu.org; Sun, 01 Nov 2020 08:11:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kZD8P-0006CK-Mu for bug-gnu-emacs@gnu.org; Sun, 01 Nov 2020 08:11:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 01 Nov 2020 13:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44100 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 44100-submit@debbugs.gnu.org id=B44100.160423620923755 (code B ref 44100); Sun, 01 Nov 2020 13:11:01 +0000 Original-Received: (at 44100) by debbugs.gnu.org; 1 Nov 2020 13:10:09 +0000 Original-Received: from localhost ([127.0.0.1]:35933 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZD7Z-0006B4-Ae for submit@debbugs.gnu.org; Sun, 01 Nov 2020 08:10:09 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:34092) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZD7Y-0006Am-0T for 44100@debbugs.gnu.org; Sun, 01 Nov 2020 08:10:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=vrLTv7WugCZ5l4TSheD1yiOB3yVjbSEXCVUbgpEYXqM=; b=siGGfp9k87cBj093t55VdVF9Wx HchhjGxkekCfTTXCg1NQT1mvRqD4YBT9nAyFBTNYMZRVSNFac/7v6J27OXkoSDwMWIGRpgC+Xj9Ek BCUgtF29nM0nDKtEvcWty5e7aCo2hTszLlNkvSFqS5t3dBAUpNhsDL8GQONXg2EX14Bg=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kZD7L-0000Hu-GS; Sun, 01 Nov 2020 14:10:01 +0100 X-Now-Playing: A Certain Ratio's _Loco_: "What's Wrong" In-Reply-To: <875z6pu8h5.fsf@gnu.org> (Amin Bandali's message of "Sat, 31 Oct 2020 22:16:54 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:192364 Archived-At: Amin Bandali writes: > However, I came up with a potentially more proper different fix: I think > the presence of the dotted pair with a non-nil cdr is the main problem, > since it means `erc-modified-channels-alist' does not fully adhere to > the documented structure in its docstring. So I addressed the issue in > `erc-track-modified-channels' by wrapping up single faces in lists too, > ensuring that `erc-modified-channels-alist' never ends in a non-nil cdr. > > Something along the lines of the following patch. Thoughts? [...] > (when erc-face > (put-text-property 0 (length channame) 'face erc-face channame) > - (when (eq erc-face 'erc-default-face) > + (when (eq (car erc-face) 'erc-default-face) > (add-face-text-property 0 (length channame) 'bold t channame))) > channame) Normalising to having a list of faces here sounds like a good idea, if I'm skimming the code correctly, but it would probably help comprehension a bit here if you renamed the parameter from `erc-face' to something like `face-list'. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no