* bug#44358: 27.1; holidays.el
@ 2020-10-31 19:27 André Alexandre Gomes
2020-10-31 23:15 ` Glenn Morris
0 siblings, 1 reply; 9+ messages in thread
From: André Alexandre Gomes @ 2020-10-31 19:27 UTC (permalink / raw)
To: 44358
Notice the comment in calendar-holidays, in the holidays.el package. It
shouldn't be autoloaded.
Thanks.
--
André Alexandre Gomes
"Free Thought, Free World"
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#44358: 27.1; holidays.el
2020-10-31 19:27 bug#44358: 27.1; holidays.el André Alexandre Gomes
@ 2020-10-31 23:15 ` Glenn Morris
2020-11-02 13:31 ` André Alexandre Gomes
0 siblings, 1 reply; 9+ messages in thread
From: Glenn Morris @ 2020-10-31 23:15 UTC (permalink / raw)
To: André Alexandre Gomes; +Cc: 44358
André Alexandre Gomes wrote:
> Notice the comment in calendar-holidays, in the holidays.el package. It
> shouldn't be autoloaded.
The variable calendar-holidays isn't autoloaded. What is your bug report?
(Perhaps you were misled by help-enable-completion-autoload?)
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#44358: 27.1; holidays.el
2020-10-31 23:15 ` Glenn Morris
@ 2020-11-02 13:31 ` André Alexandre Gomes
2020-11-09 13:06 ` André Alexandre Gomes
0 siblings, 1 reply; 9+ messages in thread
From: André Alexandre Gomes @ 2020-11-02 13:31 UTC (permalink / raw)
To: 44358
Glenn Morris <rgm@gnu.org> writes:
> André Alexandre Gomes wrote:
>
>> Notice the comment in calendar-holidays, in the holidays.el package. It
>> shouldn't be autoloaded.
>
> The variable calendar-holidays isn't autoloaded. What is your bug report?
> (Perhaps you were misled by help-enable-completion-autoload?)
In my init.el I have customized variable such as
holiday-general-holidays. However, if I run M-x list-holidays, I notice
that my changes aren't respected.
In the source code of holidays.el one can read:
;; This one should not be autoloaded, else .emacs changes of
;; holiday-general-holidays etc have no effect.
;; FIXME should have some :set-after.
Hope this helps.
--
André Alexandre Gomes
"Free Thought, Free World"
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#44358: 27.1; holidays.el
2020-11-02 13:31 ` André Alexandre Gomes
@ 2020-11-09 13:06 ` André Alexandre Gomes
2020-11-11 21:15 ` Glenn Morris
0 siblings, 1 reply; 9+ messages in thread
From: André Alexandre Gomes @ 2020-11-09 13:06 UTC (permalink / raw)
To: 44358
Hi Glenn Morris,
André Alexandre Gomes <andremegafone@gmail.com> writes:
> In my init.el I have customized variable such as
> holiday-general-holidays. However, if I run M-x list-holidays, I notice
> that my changes aren't respected.
>
> In the source code of holidays.el one can read:
>
> ;; This one should not be autoloaded, else .emacs changes of
> ;; holiday-general-holidays etc have no effect.
> ;; FIXME should have some :set-after.
Sorry to bother again but is there any workaround this?
It seems that I need to run the following s-exp
(setq calendar-holidays (append holiday-general-holidays
holiday-local-holidays
holiday-other-holidays
holiday-christian-holidays
holiday-hebrew-holidays
holiday-islamic-holidays
holiday-bahai-holidays
holiday-oriental-holidays
holiday-solar-holidays))
everytime I open Emacs so that my configuration is respected.
Thanks.
--
André Alexandre Gomes
"Free Thought, Free World"
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#44358: 27.1; holidays.el
2020-11-09 13:06 ` André Alexandre Gomes
@ 2020-11-11 21:15 ` Glenn Morris
2020-11-12 6:28 ` André Alexandre Gomes
0 siblings, 1 reply; 9+ messages in thread
From: Glenn Morris @ 2020-11-11 21:15 UTC (permalink / raw)
To: André Alexandre Gomes; +Cc: 44358
Please use reply-to-all.
Works fine here.
I guess something in your .emacs loads holidays.el too early.
Tested with:
mkdir /tmp/foo
cat <<EOF > /tmp/foo/.emacs
(setq holiday-general-holidays '((holiday-fixed 1 1 "Special Day")))
EOF
HOME=/tmp/foo emacs-27.1
C-h v calendar-holidays
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#44358: 27.1; holidays.el
2020-11-11 21:15 ` Glenn Morris
@ 2020-11-12 6:28 ` André Alexandre Gomes
2020-11-12 19:48 ` Basil L. Contovounesios
0 siblings, 1 reply; 9+ messages in thread
From: André Alexandre Gomes @ 2020-11-12 6:28 UTC (permalink / raw)
To: Glenn Morris; +Cc: 44358
Glenn Morris <rgm@gnu.org> writes:
> Please use reply-to-all.
Oops!
> Works fine here.
> I guess something in your .emacs loads holidays.el too early.
Indeed, it is due to use-package. I'm sure why, but the following
(use-package holidays
:config
(setq holiday-general-holidays '((holiday-fixed 1 1 "Special Day"))))
isn't equivalent to:
(setq holiday-general-holidays '((holiday-fixed 1 1 "Special Day")))
Thank you!
--
André Alexandre Gomes
"Free Thought, Free World"
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#44358: 27.1; holidays.el
2020-11-12 6:28 ` André Alexandre Gomes
@ 2020-11-12 19:48 ` Basil L. Contovounesios
2020-11-13 6:21 ` André Alexandre Gomes
0 siblings, 1 reply; 9+ messages in thread
From: Basil L. Contovounesios @ 2020-11-12 19:48 UTC (permalink / raw)
To: André Alexandre Gomes; +Cc: Glenn Morris, 44358
André Alexandre Gomes <andremegafone@gmail.com> writes:
> I'm sure why, but the following
>
> (use-package holidays
> :config
> (setq holiday-general-holidays '((holiday-fixed 1 1 "Special Day"))))
>
> isn't equivalent to:
>
> (setq holiday-general-holidays '((holiday-fixed 1 1 "Special Day")))
That is because (use-package X :config Y)
translates to (with-eval-after-load 'X Y),
i.e. Y gets evaluated only after X is loaded.
Try using :init or :custom instead.
Is there something left to solve here, or can this bug report be closed?
Thanks,
--
Basil
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#44358: 27.1; holidays.el
2020-11-12 19:48 ` Basil L. Contovounesios
@ 2020-11-13 6:21 ` André Alexandre Gomes
2020-11-13 11:57 ` Basil L. Contovounesios
0 siblings, 1 reply; 9+ messages in thread
From: André Alexandre Gomes @ 2020-11-13 6:21 UTC (permalink / raw)
To: Basil L. Contovounesios; +Cc: Glenn Morris, 44358
"Basil L. Contovounesios" <contovob@tcd.ie> writes:
> André Alexandre Gomes <andremegafone@gmail.com> writes:
>
>> I'm sure why, but the following
>>
>> (use-package holidays
>> :config
>> (setq holiday-general-holidays '((holiday-fixed 1 1 "Special Day"))))
>>
>> isn't equivalent to:
>>
>> (setq holiday-general-holidays '((holiday-fixed 1 1 "Special Day")))
>
> That is because (use-package X :config Y)
> translates to (with-eval-after-load 'X Y),
> i.e. Y gets evaluated only after X is loaded.
I see.
> Try using :init or :custom instead.
:custom exhibits the same behaviour as with :config. :init works great.
> Is there something left to solve here, or can this bug report be closed?
It can be closed. Thank you.
--
André Alexandre Gomes
"Free Thought, Free World"
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#44358: 27.1; holidays.el
2020-11-13 6:21 ` André Alexandre Gomes
@ 2020-11-13 11:57 ` Basil L. Contovounesios
0 siblings, 0 replies; 9+ messages in thread
From: Basil L. Contovounesios @ 2020-11-13 11:57 UTC (permalink / raw)
To: André Alexandre Gomes; +Cc: Glenn Morris, 44358-done
tags 44358 - moreinfo
tags 44358 + notabug
close 44358
quit
André Alexandre Gomes <andremegafone@gmail.com> writes:
> "Basil L. Contovounesios" <contovob@tcd.ie> writes:
>
>> Is there something left to solve here, or can this bug report be closed?
>
> It can be closed. Thank you.
Thanks, done.
--
Basil
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2020-11-13 11:57 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-31 19:27 bug#44358: 27.1; holidays.el André Alexandre Gomes
2020-10-31 23:15 ` Glenn Morris
2020-11-02 13:31 ` André Alexandre Gomes
2020-11-09 13:06 ` André Alexandre Gomes
2020-11-11 21:15 ` Glenn Morris
2020-11-12 6:28 ` André Alexandre Gomes
2020-11-12 19:48 ` Basil L. Contovounesios
2020-11-13 6:21 ` André Alexandre Gomes
2020-11-13 11:57 ` Basil L. Contovounesios
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).