unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
To: Robert Pluim <rpluim@gmail.com>
Cc: 45631@debbugs.gnu.org
Subject: bug#45631: 27.1; regression: message-forward-ignored-headers no longer applies when forwarding as MIME
Date: Tue, 05 Jan 2021 18:25:18 -0500	[thread overview]
Message-ID: <87mtxn6k69.fsf@fifthhorseman.net> (raw)
In-Reply-To: <87y2h71qj5.fsf@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1736 bytes --]

Hi Robert--

Thanks for taking a look into this!

On Tue 2021-01-05 14:06:54 +0100, Robert Pluim wrote:
> Iʼve compared emacs-26 and emacs-27, and the code is the same, which
> leads me to suspect something different in your
> configuration. 'message-forward-ignored-headers' is applied even when
> forwarding as MIME (despite the docstring)

hm, the docstring change was recent, apparently in response to #27715 :

https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=57fbf0cf7bd4a85f2ad6f14aa92494545106b887

that's why i assumed there had been a change.

> except when 'message-forward-show-mml' is nil, or when itʼs 'best' and
> the forwarded message is either signed or encrypted.

Hm, i'm using 'best' for message-forward-show-mml (as the default) and
yes, it looks like the issue is that i just noticed it happening when
i went to forward a signed message.  Maybe it wasn't an issue before
because i wasn't forwarding a signed message?  I no longer have emacs
26.3 installed so i can't check that handily right now.

The message headers (outside of the cryptographic envelope) do *not*
affect the digital signature, so they ought to be safe to trim out
without invalidating the digital signature.  These are the message
headers that i want to trim.

> Or maybe youʼre forwarding from inside the *Article* buffer, I think
> Gnus behaves differently then.

I'm using notmuch-emacs, not gnus, but it reuses a lot of the existing
emacs MUA codebase, which is why i'm reporting it here.

Do you have a suggestion for how i can apply
message-forward-ignored-headers to a signed message?  I only want it to
apply to headers that aren't covered by the digital signature anyway.

      --dkg

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

  reply	other threads:[~2021-01-05 23:25 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-03 17:12 bug#45631: 27.1; regression: message-forward-ignored-headers no longer applies when forwarding as MIME Daniel Kahn Gillmor
2021-01-05 13:06 ` Robert Pluim
2021-01-05 23:25   ` Daniel Kahn Gillmor [this message]
2021-01-06 10:31     ` Robert Pluim
2021-01-10 15:18       ` Lars Ingebrigtsen
2021-01-10 17:25         ` Eli Zaretskii
2021-01-11 15:04           ` Lars Ingebrigtsen
2021-01-10 21:41         ` Daniel Kahn Gillmor
2021-01-11 15:09           ` Lars Ingebrigtsen
2021-01-12 14:57             ` Daniel Kahn Gillmor
2021-01-13  9:25               ` Robert Pluim
2021-01-13 17:35                 ` Daniel Kahn Gillmor
2021-01-18 15:50               ` Lars Ingebrigtsen
2021-01-18 17:43                 ` Daniel Kahn Gillmor
2021-01-19  3:12                   ` Lars Ingebrigtsen
2021-01-19 16:19                     ` Daniel Kahn Gillmor
2021-01-20 16:17                       ` Lars Ingebrigtsen
2021-01-20 19:31                         ` Daniel Kahn Gillmor
2021-01-21 15:46                           ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mtxn6k69.fsf@fifthhorseman.net \
    --to=dkg@fifthhorseman.net \
    --cc=45631@debbugs.gnu.org \
    --cc=rpluim@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).