From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Leon Vack Newsgroups: gmane.emacs.bugs Subject: bug#45340: erc-services.el: Auth-source support for passwords Date: Fri, 15 Jan 2021 11:10:08 GMT Message-ID: <87mtxalals.fsf@sol.hw.lgcl.de> References: <87v9cw7np1.fsf@sol.hw.lgcl.de> <87turnjw84.fsf@sol.hw.lgcl.de> <8735z7e9v5.fsf@gnus.org> <4311421.VgBTkc7HA1@ravel> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34601"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, 45340@debbugs.gnu.org, bandali@gnu.org, dev@lgcl.de To: Olivier Certner Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 15 12:11:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l0N0Y-0008s3-Oh for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 15 Jan 2021 12:11:11 +0100 Original-Received: from localhost ([::1]:51408 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l0N0X-0000nj-MJ for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 15 Jan 2021 06:11:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37434) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l0N0Q-0000mo-0z for bug-gnu-emacs@gnu.org; Fri, 15 Jan 2021 06:11:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56685) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l0N0P-0003QS-Lg for bug-gnu-emacs@gnu.org; Fri, 15 Jan 2021 06:11:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l0N0P-0004KM-Hm for bug-gnu-emacs@gnu.org; Fri, 15 Jan 2021 06:11:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Leon Vack Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 15 Jan 2021 11:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45340 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch fixed X-Debbugs-Original-Cc: bug-gnu-emacs@gnu.org, 45340@debbugs.gnu.org, Amin Bandali , Lars Ingebrigtsen , Leon Vack Original-Received: via spool by submit@debbugs.gnu.org id=B.161070902216587 (code B ref -1); Fri, 15 Jan 2021 11:11:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 15 Jan 2021 11:10:22 +0000 Original-Received: from localhost ([127.0.0.1]:39998 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l0Mzl-0004JS-IW for submit@debbugs.gnu.org; Fri, 15 Jan 2021 06:10:22 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:45538) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l0Mzi-0004JI-At for submit@debbugs.gnu.org; Fri, 15 Jan 2021 06:10:20 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37318) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l0Mzi-0000gb-5i for bug-gnu-emacs@gnu.org; Fri, 15 Jan 2021 06:10:18 -0500 Original-Received: from out1.migadu.com ([2001:41d0:2:863f::]:42174) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l0Mzf-00030m-9b; Fri, 15 Jan 2021 06:10:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lgcl.de; s=key1; t=1610709009; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=J5a1ijhIeV8GdZsqyKc3iDX2Jr9dL8OzKUGzoXH6MWw=; b=CgjIhZFDKiwl2bK7Iw4AbkWnVJ56Ocfg3cYTypDQThtAhR9SOl9dXw7XTbhDBMwIcmkb3C 3za+ahNgGuuJaDVX6ndSlNbdNcPYNo/fg53dK45wiirZCm7bG7AhHaDGA4iHRg9ni8hzMb mdFdtUScFQl2Csx76RSTeSHbPPYiDQtivtjtvfzX4Kyqw1xXn6Hl+FifH/euSGezlM3WHh YgIasg3zk+0fADIUvREfdgfxwz6pbe9ex6CnTwm3emhzePEd5xsFNaCAMdoTRe5XOSwXbC UnBKJ2TWW3NUtWrUE3nhGocIV+SPrJfnbR+Wi6co8QPmCzyAESvbxwMKroeXiQ== X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. In-reply-to: <4311421.VgBTkc7HA1@ravel> X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: dev@lgcl.de Received-SPF: pass client-ip=2001:41d0:2:863f::; envelope-from=dev@lgcl.de; helo=out1.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:197979 Archived-At: Olivier Certner writes: > Hi, > Hello, > Sorry to be late to the party, but what is exactly this bug (and the patch) > about? I'm asking this because I've been using auth source for NickServ > passwords for a while now, without any patch. And I just want to make sure > that this is going to continue to work (of course, I don't mind possibly > changing some configuration variables if required). I've skimmed through the > bug report and the patch, and while I see no particular problem there, I > wonder if some existing things have not been overlooked. > > I have `erc-prompt-for-password' set to nil (not `erc-prompt-for-nickserv- > password'), and indeed I get prompted for a NickServ password. At this point, > I just hit ENTER without entering anything, and my password from auth source > is automatically picked up. So there seems to be an already existing mechanism > for getting the password used for NickServ from auth source. I was not aware of this, but I have done some debugging and the NickServ authentication you use mostly likely does not go through erc-services, but the core erc functionality to connect, which sends a PASS command with a password from auth source. At least freenode accepts this as a way to do NickServ authentication and the patch does not effect this functionality at all. To check if that is indeed the case, maybe try connecting without having the erc-services module loaded. > > Or is it a confusion on my part, and the introduced functionality is in fact > different? > This patch introduces a different functionality as described above, as erc-services, which only handles authentication with actual /nickserv identify commands (not handled by the core connect functionality), did not query auth source before this patch. > Regards. Regards, Leon Vack