From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#46904: Non-unique windows produced by window-state-put Date: Mon, 08 Mar 2021 19:18:16 +0200 Organization: LINKOV.NET Message-ID: <87mtvdd7m7.fsf@mail.linkov.net> References: <877dmo0zdn.fsf@mail.linkov.net> <87a6rj8dhe.fsf@mail.linkov.net> <87lfb2izev.fsf@mail.linkov.net> <8735xar85l.fsf@mail.linkov.net> <9bd9f7dd-a4d5-6d64-f784-f63f532efa10@gmx.at> <87pn0bj617.fsf@mail.linkov.net> <893dde49-dc54-e182-b907-802d4e9ce886@gmx.at> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38898"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: 46904@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Mar 08 19:10:01 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lJKKP-0009yy-Dn for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 08 Mar 2021 19:10:01 +0100 Original-Received: from localhost ([::1]:54526 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lJKKO-0005ys-8y for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 08 Mar 2021 13:10:00 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54918) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lJJoX-0003cu-OU for bug-gnu-emacs@gnu.org; Mon, 08 Mar 2021 12:37:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33149) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lJJoV-0000L6-7V for bug-gnu-emacs@gnu.org; Mon, 08 Mar 2021 12:37:05 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lJJoV-000264-5G for bug-gnu-emacs@gnu.org; Mon, 08 Mar 2021 12:37:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 Mar 2021 17:37:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46904 X-GNU-PR-Package: emacs Original-Received: via spool by 46904-submit@debbugs.gnu.org id=B46904.16152249697980 (code B ref 46904); Mon, 08 Mar 2021 17:37:03 +0000 Original-Received: (at 46904) by debbugs.gnu.org; 8 Mar 2021 17:36:09 +0000 Original-Received: from localhost ([127.0.0.1]:44693 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lJJnd-00024e-6Y for submit@debbugs.gnu.org; Mon, 08 Mar 2021 12:36:09 -0500 Original-Received: from relay8-d.mail.gandi.net ([217.70.183.201]:56331) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lJJnZ-00023k-QA for 46904@debbugs.gnu.org; Mon, 08 Mar 2021 12:36:06 -0500 X-Originating-IP: 91.129.108.46 Original-Received: from mail.gandi.net (m91-129-108-46.cust.tele2.ee [91.129.108.46]) (Authenticated sender: juri@linkov.net) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 69EF41BF20C; Mon, 8 Mar 2021 17:35:59 +0000 (UTC) In-Reply-To: <893dde49-dc54-e182-b907-802d4e9ce886@gmx.at> (martin rudalics's message of "Mon, 8 Mar 2021 09:26:21 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:201855 Archived-At: >> So better to fix callers not to use frame-root-window >> that is unreliable: sometimes frame-root-window returns >> an internal window, sometimes a live window: > > To emulate `set-window-configuration' via `window-state-put' you have > to put the state into the root window. When 'frame-root-window' returns an internal window, then we don't put the state into the root window anyway, we create a new window. The patch does the same for the case when there is only one window too, so both cases will provide the same consistent result.