From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Protesilaos Stavrou Newsgroups: gmane.emacs.bugs Subject: bug#46964: [ELPA]: [PATCH] Replace modus-*-theme with modus-themes from :core Date: Wed, 10 Mar 2021 07:43:20 +0200 Message-ID: <87mtvb1s3r.fsf@protesilaos.com> References: <87y2f0fq8v.fsf@protesilaos.com> <87sg58tkg7.fsf@tcd.ie> <87h7lofe6b.fsf@protesilaos.com> <87mtvfpgf2.fsf@protesilaos.com> <878s6wqq40.fsf@tcd.ie> <874khk6t7d.fsf@protesilaos.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26359"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: "Basil L. Contovounesios" , 46964@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Mar 10 06:44:13 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lJrdl-0006hi-EO for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 10 Mar 2021 06:44:13 +0100 Original-Received: from localhost ([::1]:35710 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lJrdk-0004RE-2G for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 10 Mar 2021 00:44:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35322) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lJrdd-0004Pq-9G for bug-gnu-emacs@gnu.org; Wed, 10 Mar 2021 00:44:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36923) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lJrdZ-0003FT-UI for bug-gnu-emacs@gnu.org; Wed, 10 Mar 2021 00:44:05 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lJrdZ-0007YL-Q3 for bug-gnu-emacs@gnu.org; Wed, 10 Mar 2021 00:44:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Protesilaos Stavrou Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Mar 2021 05:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46964 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 46964-submit@debbugs.gnu.org id=B46964.161535501328991 (code B ref 46964); Wed, 10 Mar 2021 05:44:01 +0000 Original-Received: (at 46964) by debbugs.gnu.org; 10 Mar 2021 05:43:33 +0000 Original-Received: from localhost ([127.0.0.1]:48469 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lJrd6-0007XW-Qy for submit@debbugs.gnu.org; Wed, 10 Mar 2021 00:43:33 -0500 Original-Received: from relay4-d.mail.gandi.net ([217.70.183.196]:46887) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lJrd4-0007XI-P7 for 46964@debbugs.gnu.org; Wed, 10 Mar 2021 00:43:31 -0500 X-Originating-IP: 94.46.225.161 Original-Received: from kronos (unknown [94.46.225.161]) (Authenticated sender: public@protesilaos.com) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 124C3E0005; Wed, 10 Mar 2021 05:43:22 +0000 (UTC) In-Reply-To: (Stefan Monnier's message of "Tue, 09 Mar 2021 22:48:54 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:201959 Archived-At: On 2021-03-09, 22:48 -0500, Stefan Monnier wrote: >>> No, the build always gives me errors. Though I assumed something was >>> wrong on my end (I am not familiar with makefiles). This is not just >>> with the modus-themes. Same for something like project.el. Please see >>> the attached file with the backtrace. >> >> Hmm... indeed. Can you check if the patch below fixes it for you? > > I pushed that workaround along with a more real fix for what I believe > is the same problem that was preventing building new :core packages on > elpa.gnu.org. It no longers returns an error. Thank you! Below is what I get now, provided this: ("modus-themes" :core ("etc/themes/modus-themes.el" "etc/themes/modus-operandi-theme.el" "etc/themes/modus-vivendi-theme.el" "doc/misc/modus-themes.org") :doc "modus-themes.org") make clean make build/modus-themes [...] Linking files for package: modus-themes etc/themes/modus-themes.el -> modus-themes.el etc/themes/modus-operandi-theme.el -> modus-operandi-theme.el etc/themes/modus-vivendi-theme.el -> modus-vivendi-theme.el doc/misc/modus-themes.org -> modus-themes.org The resulting archive does not include the Org file or derivatives: drwxr-xr-x prot/prot 0 modus-themes-1.2.3/ -rw-r--r-- prot/prot 2550 modus-themes-1.2.3/modus-operandi-theme.el -rw-r--r-- prot/prot 2544 modus-themes-1.2.3/modus-vivendi-theme.el -rw-r--r-- prot/prot 397 modus-themes-1.2.3/modus-themes-pkg.el -rw-r--r-- prot/prot 343994 modus-themes-1.2.3/modus-themes.el While in archive-devel, the Org file is present, though the Info file is practically empty: drwxr-xr-x prot/prot 0 modus-themes-1.2.3.0.20210306.91600/ -rw-r--r-- prot/prot 122691 modus-themes-1.2.3.0.20210306.91600/modus-themes.org -rw-r--r-- prot/prot 2550 modus-themes-1.2.3.0.20210306.91600/modus-operandi-theme.el -rw-r--r-- prot/prot 541 modus-themes-1.2.3.0.20210306.91600/dir -rw-r--r-- prot/prot 2544 modus-themes-1.2.3.0.20210306.91600/modus-vivendi-theme.el -rw-r--r-- prot/prot 414 modus-themes-1.2.3.0.20210306.91600/modus-themes-pkg.el -rw-r--r-- prot/prot 343994 modus-themes-1.2.3.0.20210306.91600/modus-themes.el -rw-r--r-- prot/prot 218 modus-themes-1.2.3.0.20210306.91600/modus-themes.info -- Protesilaos Stavrou protesilaos.com