unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Ergus <spacibba@aol.com>
Cc: 47599-done@debbugs.gnu.org
Subject: bug#47599: 28.0.50; Feature request improve/update isearch
Date: Tue, 06 Apr 2021 22:16:24 +0300	[thread overview]
Message-ID: <87mtubrzp3.fsf@mail.linkov.net> (raw)
In-Reply-To: <20210405020725.ob7bewlin7cid4pa@Ergus> (Ergus via's message of "Mon, 5 Apr 2021 04:07:25 +0200")

> Just to follow this:
> https://lists.gnu.org/archive/html/emacs-devel/2021-04/msg00080.html
>
> I open a feature request to suggest some updates in the isearch code and
> the addition of some simple functionalities like:
>
> 1) Option or command to automatically go to the other end on exit.

It seems the conclusion was that it should not be an option.
As for a command, there were objections against binding it to a key,
but without a keybinding such command has little sense.

> 2) Convert isearch-wrap-function,

Thanks for the suggestion.  Customization of wrapping was implemented now
by the new option 'isearch-wrap-pause'.  It also handles numeric arguments
of 'isearch-repeat'.

> isearch-push-state-function,
> isearch-filter-predicate into customs instead of use defvar, improve a
> bit their documentation and provide some handy options.

These functions are intended to be modified by modes, not by users.

> 3) Make some general refactor of isearch code to simplify and remove
> some redundant or useless checks, vars and code. Update the code to use
> some useful modern api like define-minor-mode or easy-mmode-defmap. There
> are some external packages that reimplement the isearch
> functionalities or hack it to produce some of these
> functionalities/behavior and maybe (as an extra) we could consider add
> some customs to make isearch behave like a bit like that; because most
> of them are not very different to what isearch already does now.

Rewriting isearch is a huge and unnecessary task.

More patches were posted directly to emacs-devel now,
so more changes are expected from that discussion.





  reply	other threads:[~2021-04-06 19:16 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210405020725.ob7bewlin7cid4pa.ref@Ergus>
2021-04-05  2:07 ` bug#47599: 28.0.50; Feature request improve/update isearch Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-04-06 19:16   ` Juri Linkov [this message]
2021-04-06 20:38     ` Gregory Heytings
2021-04-06 21:01       ` Gregory Heytings
2021-04-06 21:32         ` Gregory Heytings
2021-04-06 22:39           ` bug#47599: [External] : " Drew Adams
2021-04-06 22:43             ` Gregory Heytings
2021-04-06 23:26               ` Gregory Heytings
2021-04-07 16:20                 ` Juri Linkov
2021-04-07 17:58                   ` Gregory Heytings
2021-04-08 19:05                     ` Juri Linkov
2021-04-07  2:29           ` Eli Zaretskii
2021-04-07 10:44       ` Gregory Heytings
2021-04-07 11:20         ` Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-04-07 11:33           ` Gregory Heytings

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mtubrzp3.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=47599-done@debbugs.gnu.org \
    --cc=spacibba@aol.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).