From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#47957: dired-aux.el: convert comments to doctrings Date: Mon, 03 May 2021 10:27:57 +0200 Message-ID: <87mttcdxwy.fsf_-_@gnus.org> References: <20210422194508.mbsunzjovwdpyp2i@E15-2016.optimum.net> <20210425052212.ao4ugrbsbloxnkon@E15-2016.optimum.net> <83y2d6lqzo.fsf@gnu.org> <20210425091215.jctkznunn4re7su6@E15-2016.optimum.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17952"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 47957@debbugs.gnu.org To: Boruch Baum Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 03 10:29:09 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ldTwz-0004ZC-HA for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 03 May 2021 10:29:09 +0200 Original-Received: from localhost ([::1]:33670 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ldTwy-00008W-LV for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 03 May 2021 04:29:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53334) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ldTws-00008H-Bb for bug-gnu-emacs@gnu.org; Mon, 03 May 2021 04:29:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34597) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ldTws-0004dh-4O for bug-gnu-emacs@gnu.org; Mon, 03 May 2021 04:29:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ldTws-00036M-0Q for bug-gnu-emacs@gnu.org; Mon, 03 May 2021 04:29:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 03 May 2021 08:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47957 X-GNU-PR-Package: emacs Original-Received: via spool by 47957-submit@debbugs.gnu.org id=B47957.162003049411905 (code B ref 47957); Mon, 03 May 2021 08:29:01 +0000 Original-Received: (at 47957) by debbugs.gnu.org; 3 May 2021 08:28:14 +0000 Original-Received: from localhost ([127.0.0.1]:46143 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ldTw5-00035x-LW for submit@debbugs.gnu.org; Mon, 03 May 2021 04:28:13 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:39014) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ldTvz-00035I-11 for 47957@debbugs.gnu.org; Mon, 03 May 2021 04:28:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=8WcA/CC3BSmYyFJQfZACUGGDTDLy9m5YQZm703qRaHM=; b=T6HWPmrReBue0RSQtYi3w5vF9x +nbV2yiJMCBtmMYDBntmtVcmEa/9Ms1zoDXT2y0E/ua+NQ6uA74djgghwbEdRIUHjrUwyLvI/KcOY BEz5hi+DcE+fPYc3i30LEkJ+s18wSy+v/L/uak5Atq+nbE2UaijxfmOHV9xNh/QsP8Wc=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ldTvp-0002FD-Jd; Mon, 03 May 2021 10:27:59 +0200 X-Now-Playing: The Style Council's _The Complete Adventures (1)_: "Long Hot Summer" In-Reply-To: <20210425091215.jctkznunn4re7su6@E15-2016.optimum.net> (Boruch Baum's message of "Sun, 25 Apr 2021 05:12:15 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:205479 Archived-At: Boruch Baum writes: > All your feedback is well-taken, but I'm moving on to other things with > the patch as submitted. If as an improvement over the existing file the > patch isn't good enough to be committed for someone to continue with, > so be it. Looking over the changes -- some look good to me, and some don't. Converting comments to doc strings isn't a mechanical process -- comments should describe what a function does, while internal details should be left as comments. So I'm closing this bug report without applying the patch, because in total I think it's a change for the negative. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no