From: Lars Ingebrigtsen <larsi@gnus.org>
To: Boruch Baum <boruch_baum@gmx.com>
Cc: 47957@debbugs.gnu.org
Subject: bug#47957: dired-aux.el: convert comments to doctrings
Date: Mon, 03 May 2021 10:27:57 +0200 [thread overview]
Message-ID: <87mttcdxwy.fsf_-_@gnus.org> (raw)
In-Reply-To: <20210425091215.jctkznunn4re7su6@E15-2016.optimum.net> (Boruch Baum's message of "Sun, 25 Apr 2021 05:12:15 -0400")
Boruch Baum <boruch_baum@gmx.com> writes:
> All your feedback is well-taken, but I'm moving on to other things with
> the patch as submitted. If as an improvement over the existing file the
> patch isn't good enough to be committed for someone to continue with,
> so be it.
Looking over the changes -- some look good to me, and some don't.
Converting comments to doc strings isn't a mechanical process --
comments should describe what a function does, while internal details
should be left as comments.
So I'm closing this bug report without applying the patch, because in
total I think it's a change for the negative.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2021-05-03 8:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-22 19:45 bug#47957: diredx-aux doctrings [PATCH INCLUDED] Boruch Baum
2021-04-22 20:15 ` bug#47957: [External] : " Drew Adams
2021-04-25 5:22 ` Boruch Baum
2021-04-25 8:15 ` Eli Zaretskii
2021-04-25 9:12 ` Boruch Baum
2021-05-03 8:27 ` Lars Ingebrigtsen [this message]
2021-04-25 18:21 ` Drew Adams
2021-04-25 19:38 ` Boruch Baum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mttcdxwy.fsf_-_@gnus.org \
--to=larsi@gnus.org \
--cc=47957@debbugs.gnu.org \
--cc=boruch_baum@gmx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).