From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#47784: 27.2: ses-header-row [PATCH INCLUDED] Date: Wed, 05 May 2021 15:08:52 +0200 Message-ID: <87mtt95nvf.fsf@gnus.org> References: <20210415033147.a3hoclq24colpjf7@E15-2016.optimum.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38221"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 47784@debbugs.gnu.org To: Boruch Baum Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 05 15:21:18 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1leHSn-0009na-TF for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 05 May 2021 15:21:17 +0200 Original-Received: from localhost ([::1]:33416 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1leHSm-0001pt-SF for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 05 May 2021 09:21:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49802) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1leHHu-0007Kd-HE for bug-gnu-emacs@gnu.org; Wed, 05 May 2021 09:10:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48516) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1leHHu-0001u9-53 for bug-gnu-emacs@gnu.org; Wed, 05 May 2021 09:10:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1leHHt-0005Ns-VS for bug-gnu-emacs@gnu.org; Wed, 05 May 2021 09:10:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 May 2021 13:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47784 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 47784-submit@debbugs.gnu.org id=B47784.162022014320661 (code B ref 47784); Wed, 05 May 2021 13:10:01 +0000 Original-Received: (at 47784) by debbugs.gnu.org; 5 May 2021 13:09:03 +0000 Original-Received: from localhost ([127.0.0.1]:60055 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leHGx-0005NB-Iu for submit@debbugs.gnu.org; Wed, 05 May 2021 09:09:03 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:36510) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leHGv-0005Mk-37 for 47784@debbugs.gnu.org; Wed, 05 May 2021 09:09:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=iqvN1EaSZgTf0j2IhSljw5XsrtUB2KZDzmXzAXgRo1U=; b=iRSnYMDgGNRJQp3QM8MVNse1Kc NNzMUbftgF7osIH0KcLnUoDuh+cB620KIVbpjyQhEgubmjKtiN72zB8mxuA+o6seNWJ0KP0wnk1HG Trgc3vTSxfGa7lB/98xdZmLNOtNHVm0FBLnMpctCRYRUM9unj3gkfFwYBWC//KTgjkeI=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1leHGm-000179-J4; Wed, 05 May 2021 15:08:54 +0200 X-Now-Playing: Kreidler's _Flood_: "Flood V" In-Reply-To: <20210415033147.a3hoclq24colpjf7@E15-2016.optimum.net> (Boruch Baum's message of "Wed, 14 Apr 2021 23:31:47 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:205694 Archived-At: Boruch Baum writes: > Two patch files are attached. > > + ses-header-row.patch > > + Function `ses-set-header-row' was determining the current row based > upon variable `ses--curcell', but that variable is NIL until one > begins an operation on a cell (eg. keybindings '=', '"'), so > navigating to a row was insufficient to select that row, and further > generated an ERROR because the code was not expecting a NIL value for > variable `ses--curcell' > > + Using function `user-error' instead of `error' doesn't spawn a > debug session and backtrace buffer when variable > `toggle-debug-on-error' is set. > > + ses-user-error.patch > > + Quasi-randomly replaces some calls to function `error' with > `user-error'. Looks good to me, so I've applied both patches to Emacs 28. Eli had some questions about the usage of user-error instead of error in the second patch, but as far as I can tell, using `user-error' is indeed the right thing here, because the errors in question seem more user initiated. I've got two tiny comments about the patch. First of all, the whitespace seemed odd: lisp/ses.el:3462: space before tab in indent. + (currow (1+ (car (ses-sym-rowcol curcell))))) So I fixed that up, but I've seen that in other patches -- could you have a look and see what's causing this mixture of tab and spaces? The other comment is that it would be nice to have ChangeLog-style commit messages -- use `C-x 4 a' to format one before sending patches. Less work when applying the patch. :-) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no