bug#48781: adaptive-wrap.el (elpa): Enable lexical binding

bug#48781: adaptive-wrap.el (elpa): Enable lexical binding

[jakanakaevangeli]

@@ -1,4 +1,4 @@
-;;; adaptive-wrap.el --- Smart line-wrapping with wrap-prefix
+;;; adaptive-wrap.el --- Smart line-wrapping with wrap-prefix  -*- lexical-binding: t; -*-

For 'adaptive-wrap.el' from ELPA 
(http://elpa.gnu.org/packages/adaptive-wrap-0.5.el)

After testing for a week, I haven't observed any changes in behaviour.

Best regards.

bug#48781: adaptive-wrap.el (elpa): Enable lexical binding

[Lars Ingebrigtsen]

jakanakaevangeli@chiru.no writes:

> @@ -1,4 +1,4 @@
> -;;; adaptive-wrap.el --- Smart line-wrapping with wrap-prefix
> +;;; adaptive-wrap.el --- Smart line-wrapping with wrap-prefix -*-
> lexical-binding: t; -*-
>
> For 'adaptive-wrap.el' from ELPA 
> (http://elpa.gnu.org/packages/adaptive-wrap-0.5.el)
>
> After testing for a week, I haven't observed any changes in behaviour.

I'm not sure what the range of supported Emacs versions there are for
adaptive-wrap -- lexical binding can't be used in older Emacs versions
(but perhaps there are no version that has both package.el and doesn't
support lexical binding; I forget).

Stefan added to the CCs.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#48781: adaptive-wrap.el (elpa): Enable lexical binding

[Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors]

> -;;; adaptive-wrap.el --- Smart line-wrapping with wrap-prefix
> +;;; adaptive-wrap.el --- Smart line-wrapping with wrap-prefix  -*- lexical-binding: t; -*-
>
> For 'adaptive-wrap.el' from ELPA 
> (http://elpa.gnu.org/packages/adaptive-wrap-0.5.el)
>
> After testing for a week, I haven't observed any changes in behaviour.

Thanks, installed.

Lars wrote:
> I'm not sure what the range of supported Emacs versions there are for
> adaptive-wrap -- lexical binding can't be used in older Emacs versions

To the extent that the code doesn't take advantage of lexical scoping,
it doesn't matter because it will still work just as well as before on
Emacs<24.

> (but perhaps there are no version that has both package.el and doesn't
> support lexical binding; I forget).

The first Emacs that came with `package.el` was Emacs-24, which is also
the first that came with `lexical-binding`.
There have been versions of `package.el` patched to work in Emacs<24
(not sure how far back it worked), but indeed I tend to consider
Emacs-24 as the "baseline" for ELPA packages.


        Stefan

bug#48781: adaptive-wrap.el (elpa): Enable lexical binding

[Lars Ingebrigtsen]

Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of
text editors" <bug-gnu-emacs@gnu.org> writes:

> To the extent that the code doesn't take advantage of lexical scoping,
> it doesn't matter because it will still work just as well as before on
> Emacs<24.

Sure; I was just concerned that somebody might take that as a sign to
add non-compatible code to lexical-bound files (like closures and other
nice stuff) in indeed backwards compatibility beyond Emacs 24 was an
issue (which it doesn't really seem to be).

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#48781: adaptive-wrap.el (elpa): Enable lexical binding

[Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors]

>> To the extent that the code doesn't take advantage of lexical scoping,
>> it doesn't matter because it will still work just as well as before on
>> Emacs<24.
> Sure; I was just concerned that somebody might take that as a sign to
> add non-compatible code to lexical-bound files (like closures and other
> nice stuff) in indeed backwards compatibility beyond Emacs 24 was an
> issue (which it doesn't really seem to be).

AFAIK the desired compatibility for adaptive-wrap is not clearly known.
It hasn't been a problem so far, and if/when it turns into a problem it
should be easy to address ;-)


        Stefan

bug#48781: adaptive-wrap.el (elpa): Enable lexical binding

[Stefan Kangas]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>>> To the extent that the code doesn't take advantage of lexical scoping,
>>> it doesn't matter because it will still work just as well as before on
>>> Emacs<24.
>> Sure; I was just concerned that somebody might take that as a sign to
>> add non-compatible code to lexical-bound files (like closures and other
>> nice stuff) in indeed backwards compatibility beyond Emacs 24 was an
>> issue (which it doesn't really seem to be).
>
> AFAIK the desired compatibility for adaptive-wrap is not clearly known.
> It hasn't been a problem so far, and if/when it turns into a problem it
> should be easy to address ;-)

Should we flip it to use lexical-binding then?

bug#48781: adaptive-wrap.el (elpa): Enable lexical binding

[Lars Ingebrigtsen]

Stefan Kangas <stefan@marxist.se> writes:

> Should we flip it to use lexical-binding then?

Looks like this was done here:

commit 1a3cdaf967dfe1f611b15d177a3f6da7e07624fb
Author:     jakanakaevangeli <jakanakaevangeli@chiru.no>
AuthorDate: Wed Jun 2 09:14:46 2021 -0400

So I'm closing this bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no