From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Trust me I am a Doctor Newsgroups: gmane.emacs.bugs Subject: bug#49069: 28.0.50; [PATCH] Use display-buffer for re-builder Date: Thu, 08 Jul 2021 17:18:33 +0200 Message-ID: <87mtqw6cg8.fsf@riseup.net> References: <87r1h1jnf2.fsf@riseup.net> <87a6npf7pr.fsf@riseup.net> <871r90fsoq.fsf@riseup.net> <87o8boy8cd.fsf@riseup.net> <87pmw4tn2t.fsf@mail.linkov.net> <87czs4xqn7.fsf@riseup.net> <87zgv76skf.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29524"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Constantine Vetoshev , 49069@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 08 17:57:50 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m1WPN-0007Ud-9m for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 08 Jul 2021 17:57:49 +0200 Original-Received: from localhost ([::1]:33594 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m1WPM-00080F-9O for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 08 Jul 2021 11:57:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58596) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1W99-0007ky-My for bug-gnu-emacs@gnu.org; Thu, 08 Jul 2021 11:41:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45753) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m1W98-0006hb-3C for bug-gnu-emacs@gnu.org; Thu, 08 Jul 2021 11:41:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m1W98-0003Cy-1z for bug-gnu-emacs@gnu.org; Thu, 08 Jul 2021 11:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Trust me I am a Doctor Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 08 Jul 2021 15:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49069 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 49069-submit@debbugs.gnu.org id=B49069.162575885412313 (code B ref 49069); Thu, 08 Jul 2021 15:41:02 +0000 Original-Received: (at 49069) by debbugs.gnu.org; 8 Jul 2021 15:40:54 +0000 Original-Received: from localhost ([127.0.0.1]:57299 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m1W90-0003CW-4c for submit@debbugs.gnu.org; Thu, 08 Jul 2021 11:40:54 -0400 Original-Received: from mx1.riseup.net ([198.252.153.129]:60082) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m1W8x-0003CJ-Sy for 49069@debbugs.gnu.org; Thu, 08 Jul 2021 11:40:53 -0400 Original-Received: from fews1.riseup.net (fews1-pn.riseup.net [10.0.1.83]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client CN "*.riseup.net", Issuer "Sectigo RSA Domain Validation Secure Server CA" (not verified)) by mx1.riseup.net (Postfix) with ESMTPS id 4GLL9B10hbzDsCs; Thu, 8 Jul 2021 08:40:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1625758846; bh=ni6Li/JCkBiz7pRqA1AyPlxygNGNhPZIRBgC4+Pxz9c=; h=References:From:To:Cc:Subject:Date:In-reply-to:From; b=qaq5zvoDvbzV1JIOZDeqY7x8vy81cg5KawJ6Lktob93JHw2oIlUjr9HpBGZKuw1Hm GlwoHa6BgSj0YhnMMaZchUTq315hp8pk/WbFJJJr9BvbOfdkqifMAar4nTgTqdQ1Kx +SRbk7rkajLvjNu5MvCUrqNHIkonN7+lPijxuLbI= X-Riseup-User-ID: A454E8F0F3B89308E203DC031C441A33231CF8458FBB1605B7CF491795707857 Original-Received: from [127.0.0.1] (localhost [127.0.0.1]) by fews1.riseup.net (Postfix) with ESMTPSA id 4GLL984Rhbz5vNX; Thu, 8 Jul 2021 08:40:44 -0700 (PDT) In-reply-to: <87zgv76skf.fsf@mail.linkov.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:209699 Archived-At: Juri Linkov writes: >>> Sorry, preventing the users from customizing windows is the wrong thing. >> >> I don't know really, let me explain my rational : some users have a very >> constrained display-buffer-alist and match ".*". You can see such >> rational explained at the end of this page : >> >> https://github.com/nex3/perspective-el > > Thanks for the reference. Now I understand the reason for such absurdity > in org-mode: > > (defmacro org-no-popups (&rest body) > "Suppress popup windows and evaluate BODY." > `(let (pop-up-frames display-buffer-alist) > ,@body)) > > So different packages are fighting with each other: > one package recommends using display-buffer-alist to display > all buffers only in the same window, another package > throws away user customization on such grounds > that users might follow such poor recommendations. To be fair, blaming the different repositories gives no evidence that this macro is a reaction to perspective.el I CC its maintainer, Hi Constantine Vetoshev, While we was discussing window configurations, I introduced the recommendations of your README that I used to follow in a particular situation; in regard of the remarks of Juri, you maybe want to update them? > The correct way to display all buffers in the same window > is documented in (info "(emacs) Window Choice") where > display-buffer-base-action should be customized like this: > > (customize-set-variable > 'display-buffer-base-action > '((display-buffer-reuse-window display-buffer-same-window))) > > And the problem is solved. So please avoid ignoring user customization > with display-buffer-overriding-action because users with such > display-buffer-base-action will be able to customize "*RE-Builder*" with > display-buffer-alist. Ok you convinced me. Thanks for the tip, I installed it on a low-vision setup of a knowledge of me. We will see more in detail the differences that it implies. So it seems that the patch of the Thu, 17 Jun 2021 16:50:07 +0200 was indeed the one we want to keep. I tested it again, with : (customize-set-variable 'display-buffer-base-action '((display-buffer-reuse-window display-buffer-same-window))) (setf (alist-get "*RE-Builder*" display-buffer-alist nil nil #'string=) `((display-buffer-in-direction) (direction . top) (dedicated . t))) (re-builder) And it obeys to display-buffer-alist, be it for an other function or others parameters, and keep being functional ... etc. --