From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#17880: 24.4.50; [FEATURE] abbrev with skeleton Date: Wed, 14 Jul 2021 11:40:16 +0200 Message-ID: <87mtqpkzcv.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12250"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 17880@debbugs.gnu.org, Stefan Monnier To: Leo Liu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jul 14 11:53:37 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m3baC-00030T-SC for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 14 Jul 2021 11:53:36 +0200 Original-Received: from localhost ([::1]:46446 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m3baB-0005xy-Pq for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 14 Jul 2021 05:53:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36218) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m3bO2-0002Lo-QJ for bug-gnu-emacs@gnu.org; Wed, 14 Jul 2021 05:41:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59621) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m3bO2-000709-45 for bug-gnu-emacs@gnu.org; Wed, 14 Jul 2021 05:41:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m3bO2-00070Q-19 for bug-gnu-emacs@gnu.org; Wed, 14 Jul 2021 05:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 14 Jul 2021 09:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17880 X-GNU-PR-Package: emacs Original-Received: via spool by 17880-submit@debbugs.gnu.org id=B17880.162625562926861 (code B ref 17880); Wed, 14 Jul 2021 09:41:01 +0000 Original-Received: (at 17880) by debbugs.gnu.org; 14 Jul 2021 09:40:29 +0000 Original-Received: from localhost ([127.0.0.1]:42929 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m3bNV-0006zA-Il for submit@debbugs.gnu.org; Wed, 14 Jul 2021 05:40:29 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:41440) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m3bNS-0006ys-Vp for 17880@debbugs.gnu.org; Wed, 14 Jul 2021 05:40:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=eIQ/oO3OV2l2Oj7pPk/QDxtpGs+rUadjwcKBqEKByU0=; b=sAVW/6aZT/x2Fx+wTFozKUwx9I d/4dDB6Nl29iU2HMK2cmHqbc7zOdBAJPNeh7m6fURdd8X1gRpu3mD2fhxPMTjQXXDdJXwSiFaLWYB cu6BQN8OsL9j/+kg06CddYqFIA+0SlxaVVmthgdPZ/nNO1zV12JiAmJ+Xe7Ht0ET547c=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m3bNJ-00020M-4d; Wed, 14 Jul 2021 11:40:19 +0200 X-Now-Playing: Kid Sister's _Ultra Violet_: "Get Fresh" In-Reply-To: (Leo Liu's message of "Mon, 30 Jun 2014 09:10:58 +0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:209912 Archived-At: Leo Liu writes: > I was looking for packages to obsolete and find this expand.el. The > skeleton DSL is certainly more powerful. Comments? [...] > === modified file 'lisp/abbrev.el' > --- lisp/abbrev.el 2014-05-27 01:09:45 +0000 > +++ lisp/abbrev.el 2014-06-30 01:02:15 +0000 > @@ -776,7 +776,7 @@ [...] > + ((consp (symbol-value abbrev)) > + (delete-char (- wordstart wordend)) > + (skeleton-insert (symbol-value abbrev)))) I think the conclusion here was that we don't really want to make abbrev.el depend on skeleton here, so the patch was never applied. For the other issue -- I'm going to go ahead and guess that expand.el is still used by people (because it's so simple that some people might prefer it), so obsoleting it would be controversial, I think. So I'm closing this bug report. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no