From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#49704: 28.0.50; erc-response object retained in text-props via erc-button Date: Fri, 23 Jul 2021 13:46:58 +0200 Message-ID: <87mtqddzgt.fsf@gnus.org> References: <874kclh3sn.fsf@neverwas.me> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29443"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 49704@debbugs.gnu.org To: "J.P." Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jul 23 13:48:24 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m6tfD-0007Ts-RJ for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 23 Jul 2021 13:48:23 +0200 Original-Received: from localhost ([::1]:55044 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m6tfC-0006US-HR for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 23 Jul 2021 07:48:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45910) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m6tes-0006UH-Oy for bug-gnu-emacs@gnu.org; Fri, 23 Jul 2021 07:48:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59140) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m6tes-0004V2-Hy for bug-gnu-emacs@gnu.org; Fri, 23 Jul 2021 07:48:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m6tes-0000BX-HR for bug-gnu-emacs@gnu.org; Fri, 23 Jul 2021 07:48:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Jul 2021 11:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49704 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 49704-submit@debbugs.gnu.org id=B49704.162704083131365 (code B ref 49704); Fri, 23 Jul 2021 11:48:02 +0000 Original-Received: (at 49704) by debbugs.gnu.org; 23 Jul 2021 11:47:11 +0000 Original-Received: from localhost ([127.0.0.1]:42451 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6te2-00089f-Kv for submit@debbugs.gnu.org; Fri, 23 Jul 2021 07:47:10 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:37882) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6te0-00083n-AX for 49704@debbugs.gnu.org; Fri, 23 Jul 2021 07:47:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ofJCi22aEtDtHcTAm3qdJq4rKHFvRTAd3x1r7z4kIEQ=; b=ulb7PC2WcNI0WCMyvcZhd7BW9n nayDpkEr8Uk5Lg7EwI9mHVHcjQnJLMFy6AoaB+b/xBwtfTI5BZ9vIipJpCpDAK/rHFyWHUNMgif1B mHb3r753NI41j1Sa667BwJE810Zvq22GUx2mbBph6sMO0bfB5/TPz7NVB06h2YeJHqn4=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m6tdr-0007Et-56; Fri, 23 Jul 2021 13:47:01 +0200 X-Now-Playing: Bill Rieflin & Chris Connelly's _Largo_: "Pray'r" In-Reply-To: <874kclh3sn.fsf@neverwas.me> (J. P.'s message of "Fri, 23 Jul 2021 00:45:12 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:210568 Archived-At: "J.P." writes: > Question: shouldn't the hook functions being run here take care not to > retain references to these objects unless actually needed? I'm not quite sure I understand what problem the current text properties lead to? Is it saving memory-hungry closures in the text properties or something? I had a look at the data in some buttons in an erc buffer, and nothing there really seems excessive? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no