From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#32605: [w64] (random) never returns negative Date: Thu, 12 Aug 2021 15:17:46 +0200 Message-ID: <87mtpmls3p.fsf_-_@gnus.org> References: <855zzpf86u.fsf@gmail.com> <87zhx1ktp0.fsf@gmx.net> <87zhwwhp9i.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6526"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 32605@debbugs.gnu.org To: Andy Moreton Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 12 15:18:20 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mEAbE-0001Xd-0h for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 12 Aug 2021 15:18:20 +0200 Original-Received: from localhost ([::1]:59738 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mEAbC-0001Xo-TQ for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 12 Aug 2021 09:18:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36504) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mEAaw-0001Xe-N0 for bug-gnu-emacs@gnu.org; Thu, 12 Aug 2021 09:18:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54478) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mEAaw-0003gF-ER for bug-gnu-emacs@gnu.org; Thu, 12 Aug 2021 09:18:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mEAaw-00035c-4M for bug-gnu-emacs@gnu.org; Thu, 12 Aug 2021 09:18:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 12 Aug 2021 13:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32605 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 32605-submit@debbugs.gnu.org id=B32605.162877428011869 (code B ref 32605); Thu, 12 Aug 2021 13:18:02 +0000 Original-Received: (at 32605) by debbugs.gnu.org; 12 Aug 2021 13:18:00 +0000 Original-Received: from localhost ([127.0.0.1]:37791 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mEAau-00035N-Fl for submit@debbugs.gnu.org; Thu, 12 Aug 2021 09:18:00 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:40742) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mEAas-000358-5p for 32605@debbugs.gnu.org; Thu, 12 Aug 2021 09:17:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=wY+x3Xb0d5YU2THs0x0wLlucNW63vZUuz5omRiqYsLM=; b=MOxbfg6UdHsXEj1pd3uuUtxGni BYiAUZfOB9NqFS+C+8F3NGGpO33UyYeOR6yya6RaG0CkcFhaDr+zN/pL4j5jMqVQKf3BmHw6ttYLR GmqH5lwuPq79/S2t89l9P8nAW6ZTUCnkIZTxZGX0ia7sM1fMEQgIKjMzlOyfTraw4e0o=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mEAah-00067R-Nk; Thu, 12 Aug 2021 15:17:51 +0200 In-Reply-To: (Andy Moreton's message of "Wed, 05 Sep 2018 14:20:48 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:211670 Archived-At: Andy Moreton writes: >> This bug seems specific to 64 bit Windows builds. > > ON 64bit Windows, sysdep.c sets RAND_BITS to 31, but random (in w32.c) > only provides 30 bits. It looks like the mixing in get_random does not > result in the top fixnum bit being set. So it's this: int random (void) { /* rand_as183 () gives us 15 random bits...hack together 30 bits. */ return ((rand_as183 () << 15) | rand_as183 ()); } So running rand_as183 and taking another bit from that might do the trick? Eli, do you have any comments here? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no