From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#50067: Context menus Date: Wed, 18 Aug 2021 21:06:11 +0300 Organization: LINKOV.NET Message-ID: <87mtpepqzw.fsf@mail.linkov.net> References: <74BC00E9-2509-47DA-9428-1523FF7F3B33@acm.org> <87v942pvcj.fsf@mail.linkov.net> <83zgte3asy.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4645"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: alan@idiocy.org, mattiase@acm.org, homeros.misasa@gmail.com, tkk@misasa.okayama-u.ac.jp, larsi@gnus.org, 50067@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 18 20:07:15 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mGPy6-00012C-FP for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 18 Aug 2021 20:07:14 +0200 Original-Received: from localhost ([::1]:52740 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mGPy4-0003Wy-KQ for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 18 Aug 2021 14:07:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44156) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mGPxu-0003Wq-AR for bug-gnu-emacs@gnu.org; Wed, 18 Aug 2021 14:07:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46014) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mGPxu-00088t-4I for bug-gnu-emacs@gnu.org; Wed, 18 Aug 2021 14:07:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mGPxt-0004Ij-Vu for bug-gnu-emacs@gnu.org; Wed, 18 Aug 2021 14:07:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 18 Aug 2021 18:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50067 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 50067-submit@debbugs.gnu.org id=B50067.162931000616510 (code B ref 50067); Wed, 18 Aug 2021 18:07:01 +0000 Original-Received: (at 50067) by debbugs.gnu.org; 18 Aug 2021 18:06:46 +0000 Original-Received: from localhost ([127.0.0.1]:57560 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mGPxd-0004ID-R4 for submit@debbugs.gnu.org; Wed, 18 Aug 2021 14:06:46 -0400 Original-Received: from relay11.mail.gandi.net ([217.70.178.231]:56383) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mGPxc-0004Hz-D0 for 50067@debbugs.gnu.org; Wed, 18 Aug 2021 14:06:44 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by relay11.mail.gandi.net (Postfix) with ESMTPSA id 0EA6F100007; Wed, 18 Aug 2021 18:06:34 +0000 (UTC) In-Reply-To: <83zgte3asy.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 18 Aug 2021 20:46:53 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:212173 Archived-At: >> diff --git a/lisp/mouse.el b/lisp/mouse.el >> index 9b7d4c240f..5193994231 100644 >> --- a/lisp/mouse.el >> +++ b/lisp/mouse.el >> @@ -304,7 +304,7 @@ context-menu-filter-function >> (defun context-menu-map () >> "Return composite menu map." >> - (let ((menu (make-sparse-keymap "Context Menu"))) >> + (let ((menu (make-sparse-keymap))) >> (run-hook-wrapped 'context-menu-functions >> (lambda (fun) >> (setq menu (funcall fun menu)) > > I see you already pushed this, but it's a bad idea: it makes ugly > context menus on TTYs (and AFAIU also on non-toolkit X builds): these > _require_ the menu name because they display a caption which looks bad > with an empty name. I guess the presence of the title should be platform-dependent. For example, without a title it looks great on the GTK build.