From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#18875: 25.0.50; Dired -- add support for ls --time-style with a space Date: Sun, 22 Aug 2021 11:32:07 +0300 Message-ID: <87mtpahtw8.fsf@mail.linkov.net> References: <877dgh7c79.fsf@gnus.org> <87wnoh5xcy.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13482"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: 18875@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Aug 22 10:40:13 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mHj1Z-0003NL-3A for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 22 Aug 2021 10:40:13 +0200 Original-Received: from localhost ([::1]:43486 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mHj1X-0006yw-Ff for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 22 Aug 2021 04:40:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37650) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mHj1O-0006sQ-AO for bug-gnu-emacs@gnu.org; Sun, 22 Aug 2021 04:40:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54848) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mHj1O-0002rG-1F for bug-gnu-emacs@gnu.org; Sun, 22 Aug 2021 04:40:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mHj1N-0000QL-Uc for bug-gnu-emacs@gnu.org; Sun, 22 Aug 2021 04:40:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 22 Aug 2021 08:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18875 X-GNU-PR-Package: emacs Original-Received: via spool by 18875-submit@debbugs.gnu.org id=B18875.16296215651557 (code B ref 18875); Sun, 22 Aug 2021 08:40:01 +0000 Original-Received: (at 18875) by debbugs.gnu.org; 22 Aug 2021 08:39:25 +0000 Original-Received: from localhost ([127.0.0.1]:38154 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mHj0m-0000P2-Nk for submit@debbugs.gnu.org; Sun, 22 Aug 2021 04:39:24 -0400 Original-Received: from relay5-d.mail.gandi.net ([217.70.183.197]:41103) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mHj0k-0000Oo-72 for 18875@debbugs.gnu.org; Sun, 22 Aug 2021 04:39:23 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 3B1961C0002; Sun, 22 Aug 2021 08:39:14 +0000 (UTC) In-Reply-To: <87wnoh5xcy.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 19 Aug 2021 16:21:17 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:212400 Archived-At: >> So... dired supports spaces in command line arguments, but you have to >> quote the argument, so I'm closing this bug report. However, there's a >> bug in `split-string-and-unquote', so I'm opening a new report for that. > > Or... the problem isn't in that function -- it works as designed, and > parses a Lisp-style string correctly. > > `insert-directory' should be using `split-string-shell-command' instead, > and I've now done that in Emacs 28. The commit 04f723dec944eaa7b5e99373840a8bf920ba5fdd broke my config with the error signaled by insert-directory: (error "Listing directory failed but ‘access-file’ worked") When dired-listing-switches is customized to "-Alv --block-size='1" split-string-and-unquote parses switches correctly: ("--dired" "-Alv" ""--block-size='1" "-t") But split-string-shell-command does a wrong thing: ("--dired" "-Alv"" "--block-size=1 -t") and ls fails: /bin/ls: invalid suffix in --block-size argument '1 -t'