unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Drew Adams <drew.adams@oracle.com>
Cc: 14925@debbugs.gnu.org
Subject: bug#14925: 24.3.50; `image-dired.el' code (minor)
Date: Mon, 06 Sep 2021 12:12:31 +0200	[thread overview]
Message-ID: <87mtoqgghc.fsf@gnus.org> (raw)
In-Reply-To: <6a9c11fa-71ad-44f9-9771-35626a56ee01@default> (Drew Adams's message of "Sun, 21 Jul 2013 12:37:24 -0700 (PDT)")

Drew Adams <drew.adams@oracle.com> writes:

> 1. `image-dired-dired-file-marked-p' uses regexp "^ .*$", which I think
> is the same as "^ " (which is simpler).  I also wonder why it does not
> just use `dired-re-mark'.

I've now changed this function to use `dired-re-mark' instead in Emacs
28.

As for the other two points -- changing the names of all these dired
commands -- I don't think the gain we get from more regular function
names in this area outweighs the pain we'd inflict on users that may be
using the old names.  So I'm closing this bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  parent reply	other threads:[~2021-09-06 10:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-21 19:37 bug#14925: 24.3.50; `image-dired.el' code (minor) Drew Adams
2013-07-21 19:54 ` Drew Adams
2013-07-25 19:13 ` Stefan Monnier
2013-07-26  1:02   ` Drew Adams
2013-07-26  5:31     ` Drew Adams
2021-09-06 10:12 ` Lars Ingebrigtsen [this message]
2021-09-06 21:49   ` bug#14925: [External] : " Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mtoqgghc.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=14925@debbugs.gnu.org \
    --cc=drew.adams@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).