From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#50344: C-x v keybinding for vc-print-branch-log Date: Thu, 07 Oct 2021 20:27:07 +0300 Organization: LINKOV.NET Message-ID: <87mtnkvk5h.fsf@mail.linkov.net> References: <87mtoux1ha.fsf@mail.linkov.net> <1f39aa34-6626-3d0b-d764-2c9908787d99@yandex.ru> <87o8998wf4.fsf@mail.linkov.net> <84e4e2ef-6c8d-3645-9e1e-3129981dd45f@yandex.ru> <875yvgvohe.fsf@gnus.org> <87y28burzd.fsf@mail.linkov.net> <87o896kt5k.fsf@gnus.org> <87sfyhj3qw.fsf@mail.linkov.net> <87zgsoctoc.fsf@gnus.org> <59a05468-2309-c6e7-5a2a-51426c208966@yandex.ru> <87tuiv4hvc.fsf@gnus.org> <87fsudsngq.fsf@mail.linkov.net> <85dfa858-091b-80df-b9d1-bd1136c2b91e@yandex.ru> <878rz72wqg.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14080"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: 50344@debbugs.gnu.org, Lars Ingebrigtsen , Dmitry Gutov To: Filipp Gunbin Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 07 19:44:09 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mYXRA-0003Vu-TB for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 07 Oct 2021 19:44:08 +0200 Original-Received: from localhost ([::1]:48984 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mYXR9-0002TY-M9 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 07 Oct 2021 13:44:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34584) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mYXGQ-0005C7-Er for bug-gnu-emacs@gnu.org; Thu, 07 Oct 2021 13:33:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36806) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mYXGQ-0003Ol-6L for bug-gnu-emacs@gnu.org; Thu, 07 Oct 2021 13:33:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mYXGP-0002QU-UV for bug-gnu-emacs@gnu.org; Thu, 07 Oct 2021 13:33:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 07 Oct 2021 17:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50344 X-GNU-PR-Package: emacs Original-Received: via spool by 50344-submit@debbugs.gnu.org id=B50344.16336279819320 (code B ref 50344); Thu, 07 Oct 2021 17:33:01 +0000 Original-Received: (at 50344) by debbugs.gnu.org; 7 Oct 2021 17:33:01 +0000 Original-Received: from localhost ([127.0.0.1]:48351 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mYXGO-0002QE-NQ for submit@debbugs.gnu.org; Thu, 07 Oct 2021 13:33:00 -0400 Original-Received: from relay10.mail.gandi.net ([217.70.178.230]:56701) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mYXGL-0002Pv-BK for 50344@debbugs.gnu.org; Thu, 07 Oct 2021 13:32:59 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by relay10.mail.gandi.net (Postfix) with ESMTPSA id C58F0240005; Thu, 7 Oct 2021 17:32:48 +0000 (UTC) In-Reply-To: (Filipp Gunbin's message of "Thu, 07 Oct 2021 15:46:47 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:216673 Archived-At: > Thanks, two very minor doc comments: > >> +;;;###autoload >> +(defun vc-retrieve-tag (dir name &optional branchp) >> "For each file in or below DIR, retrieve their tagged version NAME. >> NAME can name a branch, in which case this command will switch to the >> named branch in the directory DIR. >> @@ -2375,15 +2413,21 @@ vc-retrieve-tag >> (read-directory-name "Directory: " default-directory nil t)))) >> (list >> dir >> - (vc-read-revision (format-prompt "Tag name to retrieve" "latest revisions") >> + (vc-read-revision (format-prompt >> + (if current-prefix-arg >> + "Branch name to retrieve" >> + "Tag name to retrieve") >> + "latest revisions") > > Mention prefix arg in the docstring? Thanks for noticing, will be added in the next version of the patch. >> +(defun vc-switch-branch (dir name) >> + "Switch to the branch NAME in the directory DIR. >> +If NAME is empty, it refers to the latest revisions of the current branch. >> +Uses `vc-retrieve-tag' with the non-nil arg `branchp'." > > "latest revision" instead of plural? This text was copied from vc-retrieve-tag, and Robert explained why it's plural. But since this phrase is too confusing, maybe it would be possible to rephrase it with a better text?