From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ingo Lohmar Newsgroups: gmane.emacs.bugs Subject: bug#51270: 28.0.50; xref core package 1.3.0 published, breaks etags Date: Mon, 18 Oct 2021 21:12:37 +0000 Message-ID: <87mtn6ca0q.fsf@kenko.localhost.com> References: <87sfwyej4f.fsf@kenko.localhost.com> <35441e56-49ed-480c-7a60-ffce7c173912@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33385"; mail-complaints-to="usenet@ciao.gmane.io" To: Dmitry Gutov , 51270@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Oct 18 23:14:13 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mcZxV-0008Qc-G3 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 18 Oct 2021 23:14:13 +0200 Original-Received: from localhost ([::1]:33246 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mcZxT-0007Y2-I8 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 18 Oct 2021 17:14:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44536) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mcZxL-0007WD-4B for bug-gnu-emacs@gnu.org; Mon, 18 Oct 2021 17:14:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37202) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mcZxK-00042W-Qj for bug-gnu-emacs@gnu.org; Mon, 18 Oct 2021 17:14:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mcZxK-0002Oh-CL for bug-gnu-emacs@gnu.org; Mon, 18 Oct 2021 17:14:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ingo Lohmar Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Oct 2021 21:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51270 X-GNU-PR-Package: emacs Original-Received: via spool by 51270-submit@debbugs.gnu.org id=B51270.16345915839141 (code B ref 51270); Mon, 18 Oct 2021 21:14:02 +0000 Original-Received: (at 51270) by debbugs.gnu.org; 18 Oct 2021 21:13:03 +0000 Original-Received: from localhost ([127.0.0.1]:48748 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mcZw8-0002Mq-DQ for submit@debbugs.gnu.org; Mon, 18 Oct 2021 17:13:03 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:46239) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mcZw5-0002Ma-AK for 51270@debbugs.gnu.org; Mon, 18 Oct 2021 17:12:46 -0400 Original-Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id DE97A240103 for <51270@debbugs.gnu.org>; Mon, 18 Oct 2021 23:12:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1634591558; bh=7BCFDDmVR5t1FKR/pP112JCwePfS5mJeN0n/94txn7U=; h=From:To:Subject:Date:From; b=JYqbH82VRBulFTPIYdLpqLQF3T0/eyKAoknEVTIq/DGTFycMAhdS/TPCu2tyzzBFY uR+itHB0qKRAB3U/K1CYwirp85UdXxcoR6Cclwhk8fSWav59zl0d/+P5Uso9VPlYsO 10SgHYRMxpt+Vg2C3HgcJzgEwLXfaJ5z4wKQwsd9VciXQe/6WcL/Rg6B7O54OUUFR3 jGHy0w+43IUMd9OkJYZr69HkxXRlVOirKvGpZbaEEfPPN+1nJiCpSuPv90GWVI+c0f KHABhQsofsCKIddRugWagkMPu8Wh5kbLNKuaq6W9NWmrMdZpuvtEDyQ0MTBStWBQjz fY038LqmQY1zA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4HY8j15jGTz9rxP; Mon, 18 Oct 2021 23:12:37 +0200 (CEST) In-Reply-To: <35441e56-49ed-480c-7a60-ffce7c173912@yandex.ru> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:217523 Archived-At: On Mon, Oct 18 2021 23:38 (+0300), Dmitry Gutov wrote: >> The breakage happens because xref 1.3.0 has been published on GNU ELPA >> https://elpa.gnu.org/packages/ (although the details page shows 1.2.2 as >> the latest version, don't know why). I am using the "eglot" package, >> which requires xref (at a lower minimum version), and when upgrading >> packages this morning, I got xref 1.3.0. > > Which version of Emacs are you using? I understand Emacs 26 might have a > problem with :noinline instructions in the new struct definitions. I am using the feature/pgtk branch, which is currently based on an older master (roughly 3m ago) it seems. > But as for loading eieio and defining the xref-location class, the > top-level version check at the beginning of xref.el should supposedly > help. It looks like: > > (eval-and-compile > (when (version< emacs-version "28") > ;; etags.el in Emacs 26 and 27 uses EIEIO, and its location type > ;; inherits from `xref-location'. > (require 'eieio) > (with-no-warnings > (defclass xref-location () () > :documentation "...")))) Ah, I did not look at the 1.3.0 file. So the above will help for all released emacs versions, but will just not run for a non-recent master of Emacs 28, get it. I don't have a backtrace yet, but can provide one if it's helpful for related questions. I guess I will just manually move xref-1.3.0 out of the way until I can update to a newer Emacs master (which will then include the coordinated xref/etags changes). Yeah, the packaging story is not really robust yet. I only mentioned "semantic versioning" as a general concept, but I am aware that the package repositories and the dependency format are just not prepared to make use of it anyway. Thanks for your help!